Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55098/?format=api
{ "id": 55098, "url": "http://patches.dpdk.org/api/patches/55098/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190619185958.27306-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190619185958.27306-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190619185958.27306-3-stephen@networkplumber.org", "date": "2019-06-19T18:59:52", "name": "[v4,2/8] kni: use netdev_alloc_skb", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "90099b272c4c852a8204644d5e9e81ec81b54c23", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190619185958.27306-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 5091, "url": "http://patches.dpdk.org/api/series/5091/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5091", "date": "2019-06-19T18:59:50", "name": "kni: fixes and cleanups", "version": 4, "mbox": "http://patches.dpdk.org/series/5091/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55098/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55098/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 485981D167;\n\tWed, 19 Jun 2019 21:00:09 +0200 (CEST)", "from mail-pf1-f193.google.com (mail-pf1-f193.google.com\n\t[209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 6D1121D123\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 21:00:04 +0200 (CEST)", "by mail-pf1-f193.google.com with SMTP id d126so153176pfd.2\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 12:00:04 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tg8sm18613397pfi.8.2019.06.19.12.00.01\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tWed, 19 Jun 2019 12:00:02 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=+OFQZiHQfZ8LMLFPBeuGB6NyWoetkG0/c/wPapE/X44=;\n\tb=g/bcA+5QWXWrb3sH3L7jCymdduN8yGq295Lak4tDcFh8cNaKx9BgU5NAYEJS7xqJ2I\n\tS+aQUNRfqDkSX5qnlL1esAqfZJ1S/YRwI99IuT40rFEBSKO7pmY15/Gh19I7U6a86kzq\n\tr5QzNfoSMFy8EqUnrp6yYKa6/6gbiw++23/uXjnp5FvEuiWTYhlGk3BQqnQiBXqC7kNd\n\tab2C9Zs5t1RFBtjdI9u/HX3FTuvT1cePiF1Aihyauvd010bOPyayBc1EkWAImrcrqfnj\n\tF9hovAAoNW9zWmzcpJlZseDaX/rJsJ6yRzYWpR2uy1k2bGAI01lPG4CnQubz+CTEaAHL\n\tmDvA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=+OFQZiHQfZ8LMLFPBeuGB6NyWoetkG0/c/wPapE/X44=;\n\tb=nMxIBA3BTEaOekoJxOt90vDLVUwnS+UMRAaE5MISIhweJALEXHjRzCdTV16ZVJF93G\n\t4e1qBYPINhuU2IRktKXrQyFmPzkNjNxCvmMWLauNVCweHEA03yhT2D518KabgKA13Kuo\n\tHjadsLhex5L2ReiVUqqet6NuGlQ82aagH+A2ZXSAZaFTaFhVrRko4rwTa1Ut2cmVEuY4\n\tVgcwlW6l6E7QqdsbV30n0dskXC1yDZbljP2tyfzOwYJgrKMTQimY4yYhqoXy99jffVpG\n\tTVuFH1M6qIqBa4nHqgf/QMmWociKDFOST3fVYT7noUstAo+Jg217Z6oE0CJB9sR5HQvc\n\tSB0Q==", "X-Gm-Message-State": "APjAAAWPCZ2tHZmw66EK0N/zpHCmgBltjbhLsbInC3azio5gaDKsvtP8\n\tbctBr6kOeEgPoNdxtZEkQPuKypxl9dg=", "X-Google-Smtp-Source": "APXvYqwaXCoZDADByCDsmWP2cYMy/3jaBcdRT2UJvO7ply19gC+YTfmkk7upejWsqdpaWBl9kJ0jEQ==", "X-Received": "by 2002:a63:3d0f:: with SMTP id\n\tk15mr9145385pga.343.1560970803355; \n\tWed, 19 Jun 2019 12:00:03 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <sthemmin@microsoft.com>,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 19 Jun 2019 11:59:52 -0700", "Message-Id": "<20190619185958.27306-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190619185958.27306-1-stephen@networkplumber.org>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190619185958.27306-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 2/8] kni: use netdev_alloc_skb", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <sthemmin@microsoft.com>\n\nnetdev_alloc_skb is optimized to any alignment or setup\nof skb->dev that is required. The kernel has chosen to not pad\npackets on x86 (for many years), because it is faster.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_net.c | 17 +++--------------\n 1 file changed, 3 insertions(+), 14 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c\nindex c86337d099ab..cce5e7eb991f 100644\n--- a/kernel/linux/kni/kni_net.c\n+++ b/kernel/linux/kni/kni_net.c\n@@ -340,16 +340,13 @@ kni_net_rx_normal(struct kni_dev *kni)\n \t\tdata_kva = kva2data_kva(kva);\n \t\tkni->va[i] = pa2va(kni->pa[i], kva);\n \n-\t\tskb = dev_alloc_skb(len + 2);\n+\t\tskb = netdev_alloc_skb(dev, len);\n \t\tif (!skb) {\n \t\t\t/* Update statistics */\n \t\t\tkni->stats.rx_dropped++;\n \t\t\tcontinue;\n \t\t}\n \n-\t\t/* Align IP on 16B boundary */\n-\t\tskb_reserve(skb, 2);\n-\n \t\tif (kva->nb_segs == 1) {\n \t\t\tmemcpy(skb_put(skb, len), data_kva, len);\n \t\t} else {\n@@ -368,7 +365,6 @@ kni_net_rx_normal(struct kni_dev *kni)\n \t\t\t}\n \t\t}\n \n-\t\tskb->dev = dev;\n \t\tskb->protocol = eth_type_trans(skb, dev);\n \t\tskb->ip_summed = CHECKSUM_UNNECESSARY;\n \n@@ -512,26 +508,20 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni)\n \t\tdata_kva = kva2data_kva(kva);\n \t\tkni->va[i] = pa2va(kni->pa[i], kva);\n \n-\t\tskb = dev_alloc_skb(len + 2);\n+\t\tskb = netdev_alloc_skb(dev, len);\n \t\tif (skb) {\n-\t\t\t/* Align IP on 16B boundary */\n-\t\t\tskb_reserve(skb, 2);\n \t\t\tmemcpy(skb_put(skb, len), data_kva, len);\n-\t\t\tskb->dev = dev;\n \t\t\tskb->ip_summed = CHECKSUM_UNNECESSARY;\n \t\t\tdev_kfree_skb(skb);\n \t\t}\n \n \t\t/* Simulate real usage, allocate/copy skb twice */\n-\t\tskb = dev_alloc_skb(len + 2);\n+\t\tskb = netdev_alloc_skb(dev, len);\n \t\tif (skb == NULL) {\n \t\t\tkni->stats.rx_dropped++;\n \t\t\tcontinue;\n \t\t}\n \n-\t\t/* Align IP on 16B boundary */\n-\t\tskb_reserve(skb, 2);\n-\n \t\tif (kva->nb_segs == 1) {\n \t\t\tmemcpy(skb_put(skb, len), data_kva, len);\n \t\t} else {\n@@ -550,7 +540,6 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni)\n \t\t\t}\n \t\t}\n \n-\t\tskb->dev = dev;\n \t\tskb->ip_summed = CHECKSUM_UNNECESSARY;\n \n \t\tkni->stats.rx_bytes += len;\n", "prefixes": [ "v4", "2/8" ] }