Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55095/?format=api
{ "id": 55095, "url": "http://patches.dpdk.org/api/patches/55095/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190619185746.26866-9-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190619185746.26866-9-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190619185746.26866-9-stephen@networkplumber.org", "date": "2019-06-19T18:57:46", "name": "[v3,8/8] kni: fix style issues", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "db75a754b7d67bbd4d31df173fc30316011783ea", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190619185746.26866-9-stephen@networkplumber.org/mbox/", "series": [ { "id": 5090, "url": "http://patches.dpdk.org/api/series/5090/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5090", "date": "2019-06-19T18:57:38", "name": "kni: cleanups and fixes", "version": 3, "mbox": "http://patches.dpdk.org/series/5090/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55095/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/55095/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 218F41D14E;\n\tWed, 19 Jun 2019 20:58:19 +0200 (CEST)", "from mail-pl1-f196.google.com (mail-pl1-f196.google.com\n\t[209.85.214.196]) by dpdk.org (Postfix) with ESMTP id ACC501D0FE\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 20:58:05 +0200 (CEST)", "by mail-pl1-f196.google.com with SMTP id i2so203930plt.1\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 11:58:05 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tb8sm24774858pff.20.2019.06.19.11.58.03\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tWed, 19 Jun 2019 11:58:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=61Tz9e51iFsr64UJR+4GBKGdoy7QED4nKBXU34vTxeM=;\n\tb=jrih7eR2+RX3bunEg0yfKdKQOynrGr8a3l+0YQmT4y6DFPbyW5qY6Qs4IKq6tEo+Ym\n\tf+P8IqzWpoX3u3CFy6wJuM5neORAvdx22bVJ3nfd9DqcvoDNfh+m+47p2rKmVCOa5vNQ\n\txVweopKiY05wIvME2PgZzhgMBk/OGQ2yE/DcyB6DOadYElXdRpY/uXXdXC6hvC+z/74r\n\tWuME1j8kQ7VZ4SxhjCTaSFpVwUT8bZpm7QomRhHEQvxlW0qA6VdfN3eYZ8F4gFKu3M5X\n\tRxTlCHH8/jUST+204rPCTye2JXffrb4cOtlRjesZq30jOZATZ3Nx1U0IahCfln2cgAho\n\tqZQQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=61Tz9e51iFsr64UJR+4GBKGdoy7QED4nKBXU34vTxeM=;\n\tb=TKpi+7kbtuFJZJNzmR2THXEjjqYJREVKwSl+8mwuOPexTn3Y692NJoyFDKzocRQrzD\n\tmGA2k4wno96Q+//UTI3vyfB5MxY+4B5wn0B5KfAU1VeIR6wPPTkZUwUPPL66FXhO+rSh\n\tNAk6+ii7DeajIKGkweywCa5ccJCqKwe8rAemT2jD0nKCz2dDFj9KdieUGifSU4wZKGFy\n\t6eYlMiOaBu4zpVE3rMbC2ZFBPVN0iWB6QJosiVnh7cin7fWkDeMqUeKatwW7aE1QUGPy\n\tN/LPxHtUFbLxMrgubDg3920aTwMqzsi/nh8uU0Umpq9Q/+7VCdgBlnOXKy+nMPCDDUvQ\n\t+xHw==", "X-Gm-Message-State": "APjAAAV8fKtq3wQMvGChYlqZ3xLvh+T0lD7K+e6u6VF+Li09Ugv43Nkh\n\tSD+nMl0M3+BZ+cDeq7FZbt4XRnsuXkY=", "X-Google-Smtp-Source": "APXvYqwsGYWg3o53QDbFrPfchLgt6MZe0gnw4RbIkqDTXe58S8mFbLGYWBxO4tHCUq2aGtLYXhTleQ==", "X-Received": "by 2002:a17:902:27e6:: with SMTP id\n\ti35mr119944944plg.190.1560970684681; \n\tWed, 19 Jun 2019 11:58:04 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <sthemmin@microsoft.com>,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 19 Jun 2019 11:57:46 -0700", "Message-Id": "<20190619185746.26866-9-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190619185746.26866-1-stephen@networkplumber.org>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190619185746.26866-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 8/8] kni: fix style issues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <sthemmin@microsoft.com>\n\nrte_kni does not follow standard style rules.\nNoticed some extra \\ line continuation etc.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_kni/rte_kni.c | 38 +++++++++++++++++++-------------------\n 1 file changed, 19 insertions(+), 19 deletions(-)", "diff": "diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c\nindex e29d0cc7df3c..9b6acc382fc3 100644\n--- a/lib/librte_kni/rte_kni.c\n+++ b/lib/librte_kni/rte_kni.c\n@@ -59,7 +59,7 @@ struct rte_kni {\n \tuint16_t group_id; /**< Group ID of KNI devices */\n \tuint32_t slot_id; /**< KNI pool slot ID */\n \tstruct rte_mempool *pktmbuf_pool; /**< pkt mbuf mempool */\n-\tunsigned mbuf_size; /**< mbuf size */\n+\tunsigned int mbuf_size; /**< mbuf size */\n \n \tconst struct rte_memzone *m_tx_q; /**< TX queue memzone */\n \tconst struct rte_memzone *m_rx_q; /**< RX queue memzone */\n@@ -78,7 +78,7 @@ struct rte_kni {\n \t/* For request & response */\n \tstruct rte_kni_fifo *req_q; /**< Request queue */\n \tstruct rte_kni_fifo *resp_q; /**< Response queue */\n-\tvoid * sync_addr; /**< Req/Resp Mem address */\n+\tvoid *sync_addr; /**< Req/Resp Mem address */\n \n \tstruct rte_kni_ops ops; /**< operations for request */\n };\n@@ -473,7 +473,7 @@ kni_config_promiscusity(uint16_t port_id, uint8_t to_on)\n int\n rte_kni_handle_request(struct rte_kni *kni)\n {\n-\tunsigned ret;\n+\tunsigned int ret;\n \tstruct rte_kni_request *req = NULL;\n \n \tif (kni == NULL)\n@@ -498,8 +498,8 @@ rte_kni_handle_request(struct rte_kni *kni)\n \t\tbreak;\n \tcase RTE_KNI_REQ_CFG_NETWORK_IF: /* Set network interface up/down */\n \t\tif (kni->ops.config_network_if)\n-\t\t\treq->result = kni->ops.config_network_if(\\\n-\t\t\t\t\tkni->ops.port_id, req->if_up);\n+\t\t\treq->result = kni->ops.config_network_if(kni->ops.port_id,\n+\t\t\t\t\t\t\t\t req->if_up);\n \t\tbreak;\n \tcase RTE_KNI_REQ_CHANGE_MAC_ADDR: /* Change MAC Address */\n \t\tif (kni->ops.config_mac_address)\n@@ -534,7 +534,7 @@ rte_kni_handle_request(struct rte_kni *kni)\n }\n \n unsigned\n-rte_kni_tx_burst(struct rte_kni *kni, struct rte_mbuf **mbufs, unsigned num)\n+rte_kni_tx_burst(struct rte_kni *kni, struct rte_mbuf **mbufs, unsigned int num)\n {\n \tvoid *phy_mbufs[num];\n \tunsigned int ret;\n@@ -552,9 +552,9 @@ rte_kni_tx_burst(struct rte_kni *kni, struct rte_mbuf **mbufs, unsigned num)\n }\n \n unsigned\n-rte_kni_rx_burst(struct rte_kni *kni, struct rte_mbuf **mbufs, unsigned num)\n+rte_kni_rx_burst(struct rte_kni *kni, struct rte_mbuf **mbufs, unsigned int num)\n {\n-\tunsigned ret = kni_fifo_get(kni->tx_q, (void **)mbufs, num);\n+\tunsigned int ret = kni_fifo_get(kni->tx_q, (void **)mbufs, num);\n \n \t/* If buffers removed, allocate mbufs and then put them into alloc_q */\n \tif (ret)\n@@ -605,7 +605,7 @@ kni_allocate_mbufs(struct rte_kni *kni)\n \t\treturn;\n \t}\n \n-\tallocq_free = (kni->alloc_q->read - kni->alloc_q->write - 1) \\\n+\tallocq_free = (kni->alloc_q->read - kni->alloc_q->write - 1)\n \t\t\t& (MAX_MBUF_BURST_NUM - 1);\n \tfor (i = 0; i < allocq_free; i++) {\n \t\tpkts[i] = rte_pktmbuf_alloc(kni->pktmbuf_pool);\n@@ -659,35 +659,35 @@ static enum kni_ops_status\n kni_check_request_register(struct rte_kni_ops *ops)\n {\n \t/* check if KNI request ops has been registered*/\n-\tif( NULL == ops )\n+\tif (ops == NULL)\n \t\treturn KNI_REQ_NO_REGISTER;\n \n-\tif ((ops->change_mtu == NULL)\n-\t\t&& (ops->config_network_if == NULL)\n-\t\t&& (ops->config_mac_address == NULL)\n-\t\t&& (ops->config_promiscusity == NULL))\n+\tif (ops->change_mtu == NULL\n+\t && ops->config_network_if == NULL\n+\t && ops->config_mac_address == NULL\n+\t && ops->config_promiscusity == NULL)\n \t\treturn KNI_REQ_NO_REGISTER;\n \n \treturn KNI_REQ_REGISTERED;\n }\n \n int\n-rte_kni_register_handlers(struct rte_kni *kni,struct rte_kni_ops *ops)\n+rte_kni_register_handlers(struct rte_kni *kni, struct rte_kni_ops *ops)\n {\n \tenum kni_ops_status req_status;\n \n-\tif (NULL == ops) {\n+\tif (ops == NULL) {\n \t\tRTE_LOG(ERR, KNI, \"Invalid KNI request operation.\\n\");\n \t\treturn -1;\n \t}\n \n-\tif (NULL == kni) {\n+\tif (kni == NULL) {\n \t\tRTE_LOG(ERR, KNI, \"Invalid kni info.\\n\");\n \t\treturn -1;\n \t}\n \n \treq_status = kni_check_request_register(&kni->ops);\n-\tif ( KNI_REQ_REGISTERED == req_status) {\n+\tif (req_status == KNI_REQ_REGISTERED) {\n \t\tRTE_LOG(ERR, KNI, \"The KNI request operation has already registered.\\n\");\n \t\treturn -1;\n \t}\n@@ -699,7 +699,7 @@ rte_kni_register_handlers(struct rte_kni *kni,struct rte_kni_ops *ops)\n int\n rte_kni_unregister_handlers(struct rte_kni *kni)\n {\n-\tif (NULL == kni) {\n+\tif (kni == NULL) {\n \t\tRTE_LOG(ERR, KNI, \"Invalid kni info.\\n\");\n \t\treturn -1;\n \t}\n", "prefixes": [ "v3", "8/8" ] }