Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55092/?format=api
{ "id": 55092, "url": "http://patches.dpdk.org/api/patches/55092/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190619185746.26866-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190619185746.26866-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190619185746.26866-6-stephen@networkplumber.org", "date": "2019-06-19T18:57:43", "name": "[v3,5/8] kni: use proper type for kni fifo's", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ea3b0b24974d20d15fdf8bcacf32c23a1df694bb", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190619185746.26866-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 5090, "url": "http://patches.dpdk.org/api/series/5090/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5090", "date": "2019-06-19T18:57:38", "name": "kni: cleanups and fixes", "version": 3, "mbox": "http://patches.dpdk.org/series/5090/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55092/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/55092/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AA1891D12D;\n\tWed, 19 Jun 2019 20:58:12 +0200 (CEST)", "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n\t[209.85.214.194]) by dpdk.org (Postfix) with ESMTP id ACEC81D0EF\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 20:58:01 +0200 (CEST)", "by mail-pl1-f194.google.com with SMTP id p1so202209plo.2\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 11:58:01 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tb8sm24774858pff.20.2019.06.19.11.57.59\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tWed, 19 Jun 2019 11:57:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=KIWdTWngvMzOCsjHwiLdXVCXjGw42l15HHKsPengMUk=;\n\tb=AEYEP+/jcnGHAoSfpSnYnMKABq+0iYKCVr5B+JAqIVl17MxLo0/6KEYdJqt5s37puv\n\tFqWdRYkJnQ0DbSJXn5WLfUizrNxGqiiZYfrYvv6+ghcyJz4UFjA7Uu6cUdwoSvTLD1lY\n\tPjhmAl7h2ESf8rKZokNyd/WRFKZQd6nrSfnl+SJ1/fnDfi8q1eVDV6dE/RdKaX7pYujd\n\tEtiAIR/jCMkiN3+HESPzJzsg7ZR1Uv2s6uqfholjBwomS4z73NPASvlzy6IKh23uhpYv\n\taqLJbIXx+G8k6aKBwtsFPqi+ZBRKrArt+OMUBCa2hBBn7fRHjn2ADzs7K27E9xtSaNRx\n\tWRkA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=KIWdTWngvMzOCsjHwiLdXVCXjGw42l15HHKsPengMUk=;\n\tb=MT02QoGeiQulsaNgnQxfRVBThCZsHUGdZjncN5hMMNROoEZKhVYaUm9AoBD03JWAr9\n\tXk/6zl7yLBx+4RdJPa0l18ArYgU69oKqZkJvjJxapycCDHo3O1XUnDf0BHSszxJ6cKiL\n\tT5jNZCeR4Y0bubyMl6mDTkgQDMhoSKs8rhDjD4cevjNDzQCZdxmYFQi/AQlTI1DRxSSa\n\thDrFMFOgbi+k5v5lC5i6PIeagZ4hfgWB/Dxr09DovXvOA39NxcD2D+mY4XsVziTDLTzA\n\tXRyxDUsZLWMmMgKb3hH7rkvHhtatp9rKloc5am62fVLLq90uz7hDV2vOTQkP+kGUqJXG\n\tB9Ig==", "X-Gm-Message-State": "APjAAAXdKeTJLCts1OGm5f9AwhCEL+Z8E5TJMyEbnmgA6SConXvGgfSw\n\tfoXilWE+qxBugdgSG5C9veAS8JBUREc=", "X-Google-Smtp-Source": "APXvYqxIPKay/XCWBAU3BnnLnzY0gy6zD+5f17YuuRQor3Sfv424/gUWMwv1mj1r0WxkOuYiYOK2LQ==", "X-Received": "by 2002:a17:902:f087:: with SMTP id\n\tgo7mr94492745plb.330.1560970680712; \n\tWed, 19 Jun 2019 11:58:00 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <sthemmin@microsoft.com>,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 19 Jun 2019 11:57:43 -0700", "Message-Id": "<20190619185746.26866-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190619185746.26866-1-stephen@networkplumber.org>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190619185746.26866-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 5/8] kni: use proper type for kni fifo's", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <sthemmin@microsoft.com>\n\nUsing void * instead of proper type is unsafe practice.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_dev.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h\nindex f3e6c3ca4efa..ceba5f73c1d9 100644\n--- a/kernel/linux/kni/kni_dev.h\n+++ b/kernel/linux/kni/kni_dev.h\n@@ -51,22 +51,22 @@ struct kni_dev {\n \tstruct net_device *net_dev;\n \n \t/* queue for packets to be sent out */\n-\tvoid *tx_q;\n+\tstruct rte_kni_fifo *tx_q;\n \n \t/* queue for the packets received */\n-\tvoid *rx_q;\n+\tstruct rte_kni_fifo *rx_q;\n \n \t/* queue for the allocated mbufs those can be used to save sk buffs */\n-\tvoid *alloc_q;\n+\tstruct rte_kni_fifo *alloc_q;\n \n \t/* free queue for the mbufs to be freed */\n-\tvoid *free_q;\n+\tstruct rte_kni_fifo *free_q;\n \n \t/* request queue */\n-\tvoid *req_q;\n+\tstruct rte_kni_fifo *req_q;\n \n \t/* response queue */\n-\tvoid *resp_q;\n+\tstruct rte_kni_fifo *resp_q;\n \n \tvoid *sync_kva;\n \tvoid *sync_va;\n", "prefixes": [ "v3", "5/8" ] }