Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55054/?format=api
{ "id": 55054, "url": "http://patches.dpdk.org/api/patches/55054/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190619151846.113820-62-leyi.rong@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190619151846.113820-62-leyi.rong@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190619151846.113820-62-leyi.rong@intel.com", "date": "2019-06-19T15:18:38", "name": "[v3,61/69] net/ice/base: use the specified size for ice zero bitmap", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dfd876c637ebb3908c09e80ebea070a5db09f902", "submitter": { "id": 1204, "url": "http://patches.dpdk.org/api/people/1204/?format=api", "name": "Leyi Rong", "email": "leyi.rong@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190619151846.113820-62-leyi.rong@intel.com/mbox/", "series": [ { "id": 5083, "url": "http://patches.dpdk.org/api/series/5083/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5083", "date": "2019-06-19T15:17:37", "name": "shared code update", "version": 3, "mbox": "http://patches.dpdk.org/series/5083/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55054/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/55054/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AF8531C609;\n\tWed, 19 Jun 2019 17:22:46 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 76C551C553\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 17:21:32 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Jun 2019 08:21:32 -0700", "from lrong-srv-03.sh.intel.com ([10.67.119.177])\n\tby orsmga006.jf.intel.com with ESMTP; 19 Jun 2019 08:21:31 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,392,1557212400\"; d=\"scan'208\";a=\"165050575\"", "From": "Leyi Rong <leyi.rong@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Leyi Rong <leyi.rong@intel.com>,\n\tJacob Keller <jacob.e.keller@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Wed, 19 Jun 2019 23:18:38 +0800", "Message-Id": "<20190619151846.113820-62-leyi.rong@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190619151846.113820-1-leyi.rong@intel.com>", "References": "<20190611155221.2703-1-leyi.rong@intel.com>\n\t<20190619151846.113820-1-leyi.rong@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 61/69] net/ice/base: use the specified size\n\tfor ice zero bitmap", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "A couple of places in the code use a 'sizeof(bitmap) * BITS_PER_BYTE'\nconstruction to calculate the size of the bitmap when calling\nice_zero_bitmap. Instead of doing this, just use the same value as in\nthe ice_declare_bitmap declaration.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Leyi Rong <leyi.rong@intel.com>\n---\n drivers/net/ice/base/ice_sched.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_sched.c b/drivers/net/ice/base/ice_sched.c\nindex 0f4153146..2d80af731 100644\n--- a/drivers/net/ice/base/ice_sched.c\n+++ b/drivers/net/ice/base/ice_sched.c\n@@ -5259,8 +5259,7 @@ void ice_sched_replay_agg(struct ice_hw *hw)\n \t\t\t\t\t ICE_MAX_TRAFFIC_CLASS);\n \t\t\tenum ice_status status;\n \n-\t\t\tice_zero_bitmap(replay_bitmap,\n-\t\t\t\t\tsizeof(replay_bitmap) * BITS_PER_BYTE);\n+\t\t\tice_zero_bitmap(replay_bitmap, ICE_MAX_TRAFFIC_CLASS);\n \t\t\tice_sched_get_ena_tc_bitmap(pi,\n \t\t\t\t\t\t agg_info->replay_tc_bitmap,\n \t\t\t\t\t\t replay_bitmap);\n@@ -5396,7 +5395,7 @@ ice_sched_replay_vsi_agg(struct ice_hw *hw, u16 vsi_handle)\n \tstruct ice_sched_agg_info *agg_info;\n \tenum ice_status status;\n \n-\tice_zero_bitmap(replay_bitmap, sizeof(replay_bitmap) * BITS_PER_BYTE);\n+\tice_zero_bitmap(replay_bitmap, ICE_MAX_TRAFFIC_CLASS);\n \tif (!ice_is_vsi_valid(hw, vsi_handle))\n \t\treturn ICE_ERR_PARAM;\n \tagg_info = ice_get_vsi_agg_info(hw, vsi_handle);\n", "prefixes": [ "v3", "61/69" ] }