Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55022/?format=api
{ "id": 55022, "url": "http://patches.dpdk.org/api/patches/55022/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190619151846.113820-31-leyi.rong@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190619151846.113820-31-leyi.rong@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190619151846.113820-31-leyi.rong@intel.com", "date": "2019-06-19T15:18:07", "name": "[v3,30/69] net/ice/base: disable Tx pacing option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "97361c148804d1d28bbf8777015d9b4afacb541c", "submitter": { "id": 1204, "url": "http://patches.dpdk.org/api/people/1204/?format=api", "name": "Leyi Rong", "email": "leyi.rong@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190619151846.113820-31-leyi.rong@intel.com/mbox/", "series": [ { "id": 5083, "url": "http://patches.dpdk.org/api/series/5083/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5083", "date": "2019-06-19T15:17:37", "name": "shared code update", "version": 3, "mbox": "http://patches.dpdk.org/series/5083/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55022/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/55022/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2CE541C547;\n\tWed, 19 Jun 2019 17:21:23 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 84F191C4C7\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 17:20:51 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Jun 2019 08:20:51 -0700", "from lrong-srv-03.sh.intel.com ([10.67.119.177])\n\tby orsmga006.jf.intel.com with ESMTP; 19 Jun 2019 08:20:50 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,392,1557212400\"; d=\"scan'208\";a=\"165050375\"", "From": "Leyi Rong <leyi.rong@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Leyi Rong <leyi.rong@intel.com>,\n\tChinh T Cao <chinh.t.cao@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Wed, 19 Jun 2019 23:18:07 +0800", "Message-Id": "<20190619151846.113820-31-leyi.rong@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190619151846.113820-1-leyi.rong@intel.com>", "References": "<20190611155221.2703-1-leyi.rong@intel.com>\n\t<20190619151846.113820-1-leyi.rong@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 30/69] net/ice/base: disable Tx pacing option", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "With the current NVM, after GLOBR, before the first link up event, FW\nwill return to base driver, the pacing value of 20 percents for some\nreason, in the get-link-status AQ command. We then use this value as\nthe pacing param for the set-mac-info AQ command. As result, we are\nlimited to 20 percents of the available bandwidth until the first\nset-mac-info AQ call after the link up event.\n\nSigned-off-by: Chinh T Cao <chinh.t.cao@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Leyi Rong <leyi.rong@intel.com>\n---\n drivers/net/ice/base/ice_common.c | 19 -------------------\n 1 file changed, 19 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex 5490c1dfd..8af1be9a3 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -449,11 +449,7 @@ ice_aq_set_mac_cfg(struct ice_hw *hw, u16 max_frame_size, struct ice_sq_cd *cd)\n {\n \tu16 fc_threshold_val, tx_timer_val;\n \tstruct ice_aqc_set_mac_cfg *cmd;\n-\tstruct ice_port_info *pi;\n \tstruct ice_aq_desc desc;\n-\tenum ice_status status;\n-\tu8 port_num = 0;\n-\tbool link_up;\n \tu32 reg_val;\n \n \tcmd = &desc.params.set_mac_cfg;\n@@ -465,21 +461,6 @@ ice_aq_set_mac_cfg(struct ice_hw *hw, u16 max_frame_size, struct ice_sq_cd *cd)\n \n \tcmd->max_frame_size = CPU_TO_LE16(max_frame_size);\n \n-\t/* Retrieve the current data_pacing value in FW*/\n-\tpi = &hw->port_info[port_num];\n-\n-\t/* We turn on the get_link_info so that ice_update_link_info(...)\n-\t * can be called.\n-\t */\n-\tpi->phy.get_link_info = 1;\n-\n-\tstatus = ice_get_link_status(pi, &link_up);\n-\n-\tif (status)\n-\t\treturn status;\n-\n-\tcmd->params = pi->phy.link_info.pacing;\n-\n \t/* We read back the transmit timer and fc threshold value of\n \t * LFC. Thus, we will use index =\n \t * PRTMAC_HSEC_CTL_TX_PAUSE_QUANTA_MAX_INDEX.\n", "prefixes": [ "v3", "30/69" ] }