List comments

GET /api/patches/55/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 310,
        "web_url": "http://patches.dpdk.org/comment/310/",
        "msgid": "<20140807105849.62a80fc1@haswell.linuxnetplumber.net>",
        "date": "2014-08-07T17:58:49",
        "subject": "Re: [dpdk-dev] [PATCH 1/2] lib/librte_vhost: vhost library support\n\tto facilitate integration with vswitch.",
        "submitter": {
            "id": 27,
            "url": "http://patches.dpdk.org/api/people/27/",
            "name": "Stephen Hemminger",
            "email": "stephen@networkplumber.org"
        },
        "content": "On Fri, 18 Jul 2014 13:39:05 +0800\nHuawei Xie <huawei.xie@intel.com> wrote:\n\n> Signed-off-by: Huawei Xie <huawei.xie@intel.com>\n> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n> Acked-by: Thomos Long <thomas.long@intel.com>\n\nThis looks good, but there are some style convention issues:\n\n1. Please don't use really long lines. About 100 or 120 characters is maximum\n   reasonable length in an editor\n\n2. Don't put space here in function decl.\n\nERROR: space prohibited after that '*' (ctx:BxW)\n#1183: FILE: lib/librte_vhost/vhost-net-cdev.h:102:\n+\tint (* set_vring_kick)(struct vhost_device_ctx, struct vhost_vring_file *);\n \t     ^\n\n3. Use BSD and kernel style brace\nNot:\n\n+void\n+put_files_struct (struct files_struct *files)\n+{\n+\tif (atomic_dec_and_test (&files->count))\n+\t{\n+\t\tBUG ();\n+\t}\n+}\n\nInstead:\n+void\n+put_files_struct (struct files_struct *files)\n+{\n+\tif (atomic_dec_and_test (&files->count)) {\n+\t\tBUG ();\n+\t}\n+}\n\n4. All functions that are not used in other files should be marked static.\n   For example put_files_struct\n\n5. Switch should be indented at same level as case:\nNot:\n+\tswitch (ioctl)\n+\t{\n+\t\tcase EVENTFD_COPY:\n+\t\t\tif (copy_from_user (&eventfd_copy, argp, sizeof (struct eventfd_copy)))\n+\t\t\t\treturn -EFAULT;\n+\n\nInstead:\n+\tswitch (ioctl) {\n+\tcase EVENTFD_COPY:\n+\t\tif (copy_from_user (&eventfd_copy, argp, sizeof (struct eventfd_copy)))\n+\t\t\treturn -EFAULT",
        "headers": {
            "Return-Path": "<stephen@networkplumber.org>",
            "References": "<1405661946-12534-1-git-send-email-huawei.xie@intel.com>\n\t<1405661946-12534-2-git-send-email-huawei.xie@intel.com>",
            "X-Mailman-Version": "2.1.15",
            "Date": "Thu, 7 Aug 2014 10:58:49 -0700",
            "X-List-Received-Date": "Thu, 07 Aug 2014 17:56:25 -0000",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Type": "text/plain; charset=US-ASCII",
            "X-BeenThere": "dev@dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-type:content-transfer-encoding;\n\tbh=wUxFkJOsDPvUBLkZZsCTZz2vk5RIUhdAI68pLhOWmOM=;\n\tb=QKZQLI2++ew3tAffanpZt7cg2ma1LdOMoHCxmVtmdKOhSS+jhs1uaZdsXWXvx0dApq\n\tMBnWjI5YXiVCUki6i5pPktsyHIC37LMOql2HpNTJRkku1HDNWZS9Tt/dvX6QXSs3Pf8W\n\tn2Oc2aLmlrULWBU95ytcB8M57lK7aX3Pq4/r2xufbVpsTkg86V7SYc3e6TyV/VHwfFQO\n\tbCNgjg3WDancv2AFXuhhwgdjUlxQozz5rpmqZA0OgM9WpEKa8mLUvf5zD3NhjCkA2Qi3\n\tKslRM4TmYKc/MCZIyL3x2vY5yR7Xem8Yug3Mrj1YbfJrw46Gft0VmLFu4/9uc06hEpzI\n\tP1qA==",
            "Received": [
                "from mail-pa0-f54.google.com (mail-pa0-f54.google.com\n\t[209.85.220.54]) by dpdk.org (Postfix) with ESMTP id AA47918F\n\tfor <dev@dpdk.org>; Thu,  7 Aug 2014 19:56:24 +0200 (CEST)",
                "by mail-pa0-f54.google.com with SMTP id fa1so5850785pad.27\n\tfor <dev@dpdk.org>; Thu, 07 Aug 2014 10:58:57 -0700 (PDT)",
                "from haswell.linuxnetplumber.net\n\t(static-50-53-65-80.bvtn.or.frontiernet.net. [50.53.65.80])\n\tby mx.google.com with ESMTPSA id\n\tkt2sm489045pbc.83.2014.08.07.10.58.56 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 07 Aug 2014 10:58:56 -0700 (PDT)"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 1/2] lib/librte_vhost: vhost library support\n\tto facilitate integration with vswitch.",
            "X-Received": "by 10.68.112.225 with SMTP id it1mr19298765pbb.23.1407434336948; \n\tThu, 07 Aug 2014 10:58:56 -0700 (PDT)",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Message-ID": "<20140807105849.62a80fc1@haswell.linuxnetplumber.net>",
            "Precedence": "list",
            "X-Gm-Message-State": "ALoCoQlwVX2LYy5lA3m2wVZwmrzO8W/ljbGWmJn+4rIRnoIO+0NXom7btVYHhIG3YtzTT7Qg9NjE",
            "From": "Stephen Hemminger <stephen@networkplumber.org>",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "dev@dpdk.org",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "In-Reply-To": "<1405661946-12534-2-git-send-email-huawei.xie@intel.com>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "7bit",
            "To": "Huawei Xie <huawei.xie@intel.com>"
        }
    },
    {
        "id": 316,
        "web_url": "http://patches.dpdk.org/comment/316/",
        "msgid": "<C37D651A908B024F974696C65296B57B0F25D13F@SHSMSX101.ccr.corp.intel.com>",
        "date": "2014-08-08T05:51:44",
        "subject": "Re: [dpdk-dev] [PATCH 1/2] lib/librte_vhost: vhost library support\n\tto facilitate integration with vswitch.",
        "submitter": {
            "id": 16,
            "url": "http://patches.dpdk.org/api/people/16/",
            "name": "Huawei Xie",
            "email": "huawei.xie@intel.com"
        },
        "content": "> -----Original Message-----\n> From: Stephen Hemminger [mailto:stephen@networkplumber.org]\n> Sent: Friday, August 08, 2014 1:59 AM\n> To: Xie, Huawei\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH 1/2] lib/librte_vhost: vhost library support to\n> facilitate integration with vswitch.\n> \n> On Fri, 18 Jul 2014 13:39:05 +0800\n> Huawei Xie <huawei.xie@intel.com> wrote:\n> \n> > Signed-off-by: Huawei Xie <huawei.xie@intel.com>\n> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n> > Acked-by: Thomos Long <thomas.long@intel.com>\n> \n> This looks good, but there are some style convention issues:\n> \n> 1. Please don't use really long lines. About 100 or 120 characters is maximum\n>    reasonable length in an editor\n> \nI plan to fix the length issues in subsequent patch. There are plenty of them, which are inherited from old vhost code. \n> 2. Don't put space here in function decl.\n> \n> ERROR: space prohibited after that '*' (ctx:BxW)\n> #1183: FILE: lib/librte_vhost/vhost-net-cdev.h:102:\n> +\tint (* set_vring_kick)(struct vhost_device_ctx, struct vhost_vring_file *);\n>  \t     ^\n> \nIn this patch, I only run checkpatch.pl against the source file I modified rather than the patch itself, so missed these checking.  I had sent the V3 patch in which those kind of issues are fixed. Please refer to the latest V3 patch.\n> 3. Use BSD and kernel style brace\n> Not:\n> \n> +void\n> +put_files_struct (struct files_struct *files)\n> +{\n> +\tif (atomic_dec_and_test (&files->count))\n> +\t{\n> +\t\tBUG ();\n> +\t}\n> +}\n> \n> Instead:\n> +void\n> +put_files_struct (struct files_struct *files)\n> +{\n> +\tif (atomic_dec_and_test (&files->count)) {\n> +\t\tBUG ();\n> +\t}\n> +}\n> \n> 4. All functions that are not used in other files should be marked static.\n>    For example put_files_struct\n> \n> 5. Switch should be indented at same level as case:\n> Not:\n> +\tswitch (ioctl)\n> +\t{\n> +\t\tcase EVENTFD_COPY:\n> +\t\t\tif (copy_from_user (&eventfd_copy, argp, sizeof (struct\n> eventfd_copy)))\n> +\t\t\t\treturn -EFAULT;\n> +\n> \n> Instead:\n> +\tswitch (ioctl) {\n> +\tcase EVENTFD_COPY:\n> +\t\tif (copy_from_user (&eventfd_copy, argp, sizeof (struct\n> eventfd_copy)))\n> +\t\t\treturn -EFAULT\n\nThanks. As stated above, have fixed all the style issues except 80 length warning in v3 patch.",
        "headers": {
            "Return-Path": "<huawei.xie@intel.com>",
            "References": "<1405661946-12534-1-git-send-email-huawei.xie@intel.com>\n\t<1405661946-12534-2-git-send-email-huawei.xie@intel.com>\n\t<20140807105849.62a80fc1@haswell.linuxnetplumber.net>",
            "X-Mailman-Version": "2.1.15",
            "X-IronPort-AV": "E=Sophos;i=\"5.01,823,1400050800\"; d=\"scan'208\";a=\"581810361\"",
            "From": "\"Xie, Huawei\" <huawei.xie@intel.com>",
            "x-originating-ip": "[10.239.127.40]",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Thread-Index": "AQHPsmlGnwUtxN6tnEGVzBFuCq/OEZvGDKBw",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "Thread-Topic": "[dpdk-dev] [PATCH 1/2] lib/librte_vhost: vhost library support\n\tto facilitate integration with vswitch.",
            "Accept-Language": "en-US",
            "X-List-Received-Date": "Fri, 08 Aug 2014 05:49:14 -0000",
            "Received": [
                "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id B2A8268B0\n\tfor <dev@dpdk.org>; Fri,  8 Aug 2014 07:49:13 +0200 (CEST)",
                "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 07 Aug 2014 22:51:48 -0700",
                "from fmsmsx103.amr.corp.intel.com ([10.19.9.34])\n\tby fmsmga002.fm.intel.com with ESMTP; 07 Aug 2014 22:51:47 -0700",
                "from fmsmsx102.amr.corp.intel.com (10.18.124.200) by\n\tFMSMSX103.amr.corp.intel.com (10.19.9.34) with Microsoft SMTP Server\n\t(TLS) id 14.3.123.3; Thu, 7 Aug 2014 22:51:47 -0700",
                "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n\tFMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP\n\tServer (TLS) id 14.3.123.3; Thu, 7 Aug 2014 22:51:47 -0700",
                "from shsmsx101.ccr.corp.intel.com ([169.254.1.252]) by\n\tshsmsx102.ccr.corp.intel.com ([169.254.2.172]) with mapi id\n\t14.03.0195.001; Fri, 8 Aug 2014 13:51:45 +0800"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 1/2] lib/librte_vhost: vhost library support\n\tto facilitate integration with vswitch.",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Content-Language": "en-US",
            "Message-ID": "<C37D651A908B024F974696C65296B57B0F25D13F@SHSMSX101.ccr.corp.intel.com>",
            "X-MS-Has-Attach": "",
            "X-BeenThere": "dev@dpdk.org",
            "Date": "Fri, 8 Aug 2014 05:51:44 +0000",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-ExtLoop1": "1",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Precedence": "list",
            "In-Reply-To": "<20140807105849.62a80fc1@haswell.linuxnetplumber.net>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "quoted-printable",
            "To": "Stephen Hemminger <stephen@networkplumber.org>",
            "X-MS-TNEF-Correlator": ""
        }
    }
]