Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 54992,
    "url": "http://patches.dpdk.org/api/patches/54992/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560957293-17294-26-git-send-email-ndragazis@arrikto.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1560957293-17294-26-git-send-email-ndragazis@arrikto.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1560957293-17294-26-git-send-email-ndragazis@arrikto.com",
    "date": "2019-06-19T15:14:50",
    "name": "[25/28] examples/vhost_scsi: add virtio-vhost-user support",
    "commit_ref": null,
    "pull_url": null,
    "state": "rfc",
    "archived": true,
    "hash": "6535f6674aa3db706e386d7f28cc2152071ce68c",
    "submitter": {
        "id": 1339,
        "url": "http://patches.dpdk.org/api/people/1339/?format=api",
        "name": "Nikos Dragazis",
        "email": "ndragazis@arrikto.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560957293-17294-26-git-send-email-ndragazis@arrikto.com/mbox/",
    "series": [
        {
            "id": 5082,
            "url": "http://patches.dpdk.org/api/series/5082/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5082",
            "date": "2019-06-19T15:14:25",
            "name": "vhost: add virtio-vhost-user transport",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/5082/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/54992/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/54992/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E759B1C44A;\n\tWed, 19 Jun 2019 17:16:47 +0200 (CEST)",
            "from mx0.arrikto.com (mx0.arrikto.com [212.71.252.59])\n\tby dpdk.org (Postfix) with ESMTP id B09FC1C3A1\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 17:15:47 +0200 (CEST)",
            "from troi.prod.arr (mail.arr [10.99.0.5])\n\tby mx0.arrikto.com (Postfix) with ESMTP id 8FF3118201D;\n\tWed, 19 Jun 2019 18:15:47 +0300 (EEST)",
            "from localhost.localdomain (unknown [10.89.50.133])\n\tby troi.prod.arr (Postfix) with ESMTPSA id 1219C32C;\n\tWed, 19 Jun 2019 18:15:47 +0300 (EEST)"
        ],
        "From": "Nikos Dragazis <ndragazis@arrikto.com>",
        "To": "dev@dpdk.org",
        "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tTiwei Bie <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>,\n\tStefan Hajnoczi <stefanha@redhat.com>, Wei Wang <wei.w.wang@intel.com>,\n\tStojaczyk Dariusz <dariusz.stojaczyk@intel.com>,\n\tVangelis Koukis <vkoukis@arrikto.com>",
        "Date": "Wed, 19 Jun 2019 18:14:50 +0300",
        "Message-Id": "<1560957293-17294-26-git-send-email-ndragazis@arrikto.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1560957293-17294-1-git-send-email-ndragazis@arrikto.com>",
        "References": "<1560957293-17294-1-git-send-email-ndragazis@arrikto.com>",
        "Subject": "[dpdk-dev] [PATCH 25/28] examples/vhost_scsi: add virtio-vhost-user\n\tsupport",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Stefan Hajnoczi <stefanha@redhat.com>\n\nThe new --virtio-vhost-user-pci command-line argument uses\nvirtio-vhost-user instead of the default AF_UNIX transport.\n\nSigned-off-by: Stefan Hajnoczi <stefanha@redhat.com>\n---\n examples/vhost_scsi/vhost_scsi.c | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/examples/vhost_scsi/vhost_scsi.c b/examples/vhost_scsi/vhost_scsi.c\nindex d2d02fd..020f4a0 100644\n--- a/examples/vhost_scsi/vhost_scsi.c\n+++ b/examples/vhost_scsi/vhost_scsi.c\n@@ -27,6 +27,7 @@\n \n /* Path to folder where character device will be created. Can be set by user. */\n static char dev_pathname[PATH_MAX] = \"\";\n+static uint64_t dev_flags; /* for rte_vhost_driver_register() */\n \n static struct vhost_scsi_ctrlr *g_vhost_ctrlr;\n static int g_should_stop;\n@@ -408,7 +409,7 @@ vhost_scsi_ctrlr_construct(void)\n \tint ret;\n \tstruct vhost_scsi_ctrlr *ctrlr;\n \n-\tif (rte_vhost_driver_register(dev_pathname, 0) != 0) {\n+\tif (rte_vhost_driver_register(dev_pathname, dev_flags) != 0) {\n \t\tfprintf(stderr, \"socket %s already exists\\n\", dev_pathname);\n \t\treturn NULL;\n \t}\n@@ -444,7 +445,8 @@ static void\n set_dev_pathname(const char *path)\n {\n \tif (dev_pathname[0])\n-\t\trte_exit(EXIT_FAILURE, \"--socket-file can only be given once.\\n\");\n+\t\trte_exit(EXIT_FAILURE, \"Only one of --socket-file or \"\n+\t\t\t \"--virtio-vhost-user-pci can be given.\\n\");\n \n \tsnprintf(dev_pathname, sizeof(dev_pathname), \"%s\", path);\n }\n@@ -453,7 +455,8 @@ static void\n vhost_scsi_usage(const char *prgname)\n {\n \tfprintf(stderr, \"%s [EAL options] --\\n\"\n-\t\"    --socket-file PATH: The path of the UNIX domain socket\\n\",\n+\t\"    --socket-file PATH: The path of the UNIX domain socket\\n\"\n+\t\"    --virtio-vhost-user-pci DomBDF: PCI adapter address\\n\",\n \t\tprgname);\n }\n \n@@ -465,6 +468,7 @@ vhost_scsi_parse_args(int argc, char **argv)\n \tconst char *prgname = argv[0];\n \tstatic struct option long_option[] = {\n \t\t{\"socket-file\", required_argument, NULL, 0},\n+\t\t{\"virtio-vhost-user-pci\", required_argument, NULL, 0},\n \t\t{NULL, 0, 0, 0},\n \t};\n \n@@ -475,6 +479,10 @@ vhost_scsi_parse_args(int argc, char **argv)\n \t\t\tif (!strcmp(long_option[option_index].name,\n \t\t\t\t    \"socket-file\")) {\n \t\t\t\tset_dev_pathname(optarg);\n+\t\t\t} else if (!strcmp(long_option[option_index].name,\n+\t\t\t\t   \"virtio-vhost-user-pci\")) {\n+\t\t\t\tset_dev_pathname(optarg);\n+\t\t\t\tdev_flags = RTE_VHOST_USER_VIRTIO_TRANSPORT;\n \t\t\t}\n \t\t\tbreak;\n \t\tdefault:\n",
    "prefixes": [
        "25/28"
    ]
}