Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54959/?format=api
{ "id": 54959, "url": "http://patches.dpdk.org/api/patches/54959/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560957293-17294-6-git-send-email-ndragazis@arrikto.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560957293-17294-6-git-send-email-ndragazis@arrikto.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560957293-17294-6-git-send-email-ndragazis@arrikto.com", "date": "2019-06-19T15:14:30", "name": "[05/28] vhost: move start server/client calls", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "7e7ce8356a34713b8990a41619228eaa24cac55a", "submitter": { "id": 1339, "url": "http://patches.dpdk.org/api/people/1339/?format=api", "name": "Nikos Dragazis", "email": "ndragazis@arrikto.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560957293-17294-6-git-send-email-ndragazis@arrikto.com/mbox/", "series": [ { "id": 5082, "url": "http://patches.dpdk.org/api/series/5082/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5082", "date": "2019-06-19T15:14:25", "name": "vhost: add virtio-vhost-user transport", "version": 1, "mbox": "http://patches.dpdk.org/series/5082/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54959/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54959/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 922201C3A9;\n\tWed, 19 Jun 2019 17:15:50 +0200 (CEST)", "from mx0.arrikto.com (mx0.arrikto.com [212.71.252.59])\n\tby dpdk.org (Postfix) with ESMTP id 3FB581C386\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 17:15:38 +0200 (CEST)", "from troi.prod.arr (mail.arr [10.99.0.5])\n\tby mx0.arrikto.com (Postfix) with ESMTP id 0D37B182009;\n\tWed, 19 Jun 2019 18:15:38 +0300 (EEST)", "from localhost.localdomain (unknown [10.89.50.133])\n\tby troi.prod.arr (Postfix) with ESMTPSA id 8A62C2B2;\n\tWed, 19 Jun 2019 18:15:37 +0300 (EEST)" ], "From": "Nikos Dragazis <ndragazis@arrikto.com>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tTiwei Bie <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>,\n\tStefan Hajnoczi <stefanha@redhat.com>, Wei Wang <wei.w.wang@intel.com>,\n\tStojaczyk Dariusz <dariusz.stojaczyk@intel.com>,\n\tVangelis Koukis <vkoukis@arrikto.com>", "Date": "Wed, 19 Jun 2019 18:14:30 +0300", "Message-Id": "<1560957293-17294-6-git-send-email-ndragazis@arrikto.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1560957293-17294-1-git-send-email-ndragazis@arrikto.com>", "References": "<1560957293-17294-1-git-send-email-ndragazis@arrikto.com>", "Subject": "[dpdk-dev] [PATCH 05/28] vhost: move start server/client calls", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stefan Hajnoczi <stefanha@redhat.com>\n\nIntroduce a vhost_transport_ops->socket_start() interface so the\ntransport can begin establishing vhost-user connections. This is part\nof the AF_UNIX transport refactoring and removes AF_UNIX code from\nvhost.h and socket.c.\n\nSigned-off-by: Stefan Hajnoczi <stefanha@redhat.com>\n---\n lib/librte_vhost/socket.c | 5 +----\n lib/librte_vhost/trans_af_unix.c | 16 ++++++++++++++--\n lib/librte_vhost/vhost.h | 16 +++++++++++++---\n 3 files changed, 28 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c\nindex 3b5608c..df6d707 100644\n--- a/lib/librte_vhost/socket.c\n+++ b/lib/librte_vhost/socket.c\n@@ -564,8 +564,5 @@ rte_vhost_driver_start(const char *path)\n \t\t}\n \t}\n \n-\tif (vsocket->is_server)\n-\t\treturn vhost_user_start_server(vsocket);\n-\telse\n-\t\treturn vhost_user_start_client(vsocket);\n+\treturn vsocket->trans_ops->socket_start(vsocket);\n }\ndiff --git a/lib/librte_vhost/trans_af_unix.c b/lib/librte_vhost/trans_af_unix.c\nindex f23bb9c..93d11f7 100644\n--- a/lib/librte_vhost/trans_af_unix.c\n+++ b/lib/librte_vhost/trans_af_unix.c\n@@ -22,6 +22,8 @@ struct af_unix_socket {\n };\n \n static int create_unix_socket(struct vhost_user_socket *vsocket);\n+static int vhost_user_start_server(struct vhost_user_socket *vsocket);\n+static int vhost_user_start_client(struct vhost_user_socket *vsocket);\n static void vhost_user_read_cb(int connfd, void *dat, int *remove);\n \n /*\n@@ -280,7 +282,7 @@ create_unix_socket(struct vhost_user_socket *vsocket)\n \treturn 0;\n }\n \n-int\n+static int\n vhost_user_start_server(struct vhost_user_socket *vsocket)\n {\n \tstruct af_unix_socket *af_vsocket =\n@@ -438,7 +440,7 @@ vhost_user_reconnect_init(void)\n \treturn ret;\n }\n \n-int\n+static int\n vhost_user_start_client(struct vhost_user_socket *vsocket)\n {\n \tstruct af_unix_socket *af_vsocket =\n@@ -529,6 +531,15 @@ af_unix_socket_cleanup(struct vhost_user_socket *vsocket)\n }\n \n static int\n+af_unix_socket_start(struct vhost_user_socket *vsocket)\n+{\n+\tif (vsocket->is_server)\n+\t\treturn vhost_user_start_server(vsocket);\n+\telse\n+\t\treturn vhost_user_start_client(vsocket);\n+}\n+\n+static int\n af_unix_vring_call(struct virtio_net *dev __rte_unused,\n \t\t struct vhost_virtqueue *vq)\n {\n@@ -541,5 +552,6 @@ const struct vhost_transport_ops af_unix_trans_ops = {\n \t.socket_size = sizeof(struct af_unix_socket),\n \t.socket_init = af_unix_socket_init,\n \t.socket_cleanup = af_unix_socket_cleanup,\n+\t.socket_start = af_unix_socket_start,\n \t.vring_call = af_unix_vring_call,\n };\ndiff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h\nindex 40b5c25..c74753b 100644\n--- a/lib/librte_vhost/vhost.h\n+++ b/lib/librte_vhost/vhost.h\n@@ -324,6 +324,19 @@ struct vhost_transport_ops {\n \tvoid (*socket_cleanup)(struct vhost_user_socket *vsocket);\n \n \t/**\n+\t * Start establishing vhost-user connections. This function is\n+\t * asynchronous and connections may be established after it has\n+\t * returned. Call vhost_user_add_connection() to register new\n+\t * connections.\n+\t *\n+\t * @param vsocket\n+\t * vhost socket\n+\t * @return\n+\t * 0 on success, -1 on failure\n+\t */\n+\tint (*socket_start)(struct vhost_user_socket *vsocket);\n+\n+\t/**\n \t * Notify the guest that used descriptors have been added to the vring.\n \t * The VRING_AVAIL_F_NO_INTERRUPT flag and event idx have already been checked\n \t * so this function just needs to perform the notification.\n@@ -458,9 +471,6 @@ struct vhost_user {\n \n extern struct vhost_user vhost_user;\n \n-int vhost_user_start_server(struct vhost_user_socket *vsocket);\n-int vhost_user_start_client(struct vhost_user_socket *vsocket);\n-\n extern pthread_t reconn_tid;\n \n int vhost_user_reconnect_init(void);\n", "prefixes": [ "05/28" ] }