Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54957/?format=api
{ "id": 54957, "url": "http://patches.dpdk.org/api/patches/54957/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560957293-17294-4-git-send-email-ndragazis@arrikto.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560957293-17294-4-git-send-email-ndragazis@arrikto.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560957293-17294-4-git-send-email-ndragazis@arrikto.com", "date": "2019-06-19T15:14:28", "name": "[03/28] vhost: allocate per-socket transport state", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "0337f4dc6cb1001351a68058b14439ef2351ba31", "submitter": { "id": 1339, "url": "http://patches.dpdk.org/api/people/1339/?format=api", "name": "Nikos Dragazis", "email": "ndragazis@arrikto.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560957293-17294-4-git-send-email-ndragazis@arrikto.com/mbox/", "series": [ { "id": 5082, "url": "http://patches.dpdk.org/api/series/5082/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5082", "date": "2019-06-19T15:14:25", "name": "vhost: add virtio-vhost-user transport", "version": 1, "mbox": "http://patches.dpdk.org/series/5082/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54957/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54957/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 143141C39B;\n\tWed, 19 Jun 2019 17:15:45 +0200 (CEST)", "from mx0.arrikto.com (mx0.arrikto.com [212.71.252.59])\n\tby dpdk.org (Postfix) with ESMTP id 9E8871C387\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 17:15:37 +0200 (CEST)", "from troi.prod.arr (mail.arr [10.99.0.5])\n\tby mx0.arrikto.com (Postfix) with ESMTP id 56EE8182007;\n\tWed, 19 Jun 2019 18:15:37 +0300 (EEST)", "from localhost.localdomain (unknown [10.89.50.133])\n\tby troi.prod.arr (Postfix) with ESMTPSA id D5A9D2B2;\n\tWed, 19 Jun 2019 18:15:36 +0300 (EEST)" ], "From": "Nikos Dragazis <ndragazis@arrikto.com>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tTiwei Bie <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>,\n\tStefan Hajnoczi <stefanha@redhat.com>, Wei Wang <wei.w.wang@intel.com>,\n\tStojaczyk Dariusz <dariusz.stojaczyk@intel.com>,\n\tVangelis Koukis <vkoukis@arrikto.com>", "Date": "Wed, 19 Jun 2019 18:14:28 +0300", "Message-Id": "<1560957293-17294-4-git-send-email-ndragazis@arrikto.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1560957293-17294-1-git-send-email-ndragazis@arrikto.com>", "References": "<1560957293-17294-1-git-send-email-ndragazis@arrikto.com>", "Subject": "[dpdk-dev] [PATCH 03/28] vhost: allocate per-socket transport state", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stefan Hajnoczi <stefanha@redhat.com>\n\nvhost-user transports have per-socket state (like file descriptors).\nMake it possible for transports to keep state beyond what is included in\nstruct vhost_user_socket.\n\nThis patch makes it possible to move AF_UNIX-specific fields from struct\nvhost_user_socket into trans_af_unix.c in later patches.\n\nSigned-off-by: Stefan Hajnoczi <stefanha@redhat.com>\n---\n lib/librte_vhost/socket.c | 6 ++++--\n lib/librte_vhost/trans_af_unix.c | 5 +++++\n lib/librte_vhost/vhost.h | 9 +++++++++\n 3 files changed, 18 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c\nindex a993b67..60d3546 100644\n--- a/lib/librte_vhost/socket.c\n+++ b/lib/librte_vhost/socket.c\n@@ -316,6 +316,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)\n {\n \tint ret = -1;\n \tstruct vhost_user_socket *vsocket;\n+\tconst struct vhost_transport_ops *trans_ops = &af_unix_trans_ops;\n \n \tif (!path)\n \t\treturn -1;\n@@ -328,10 +329,11 @@ rte_vhost_driver_register(const char *path, uint64_t flags)\n \t\tgoto out;\n \t}\n \n-\tvsocket = malloc(sizeof(struct vhost_user_socket));\n+\tvsocket = malloc(trans_ops->socket_size);\n \tif (!vsocket)\n \t\tgoto out;\n-\tmemset(vsocket, 0, sizeof(struct vhost_user_socket));\n+\tmemset(vsocket, 0, trans_ops->socket_size);\n+\tvsocket->trans_ops = trans_ops;\n \tvsocket->path = strdup(path);\n \tif (vsocket->path == NULL) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\ndiff --git a/lib/librte_vhost/trans_af_unix.c b/lib/librte_vhost/trans_af_unix.c\nindex 89a5b7d..4de2579 100644\n--- a/lib/librte_vhost/trans_af_unix.c\n+++ b/lib/librte_vhost/trans_af_unix.c\n@@ -13,6 +13,10 @@\n \n #define MAX_VIRTIO_BACKLOG 128\n \n+struct af_unix_socket {\n+\tstruct vhost_user_socket socket; /* must be the first field! */\n+};\n+\n static void vhost_user_read_cb(int connfd, void *dat, int *remove);\n \n /*\n@@ -501,5 +505,6 @@ af_unix_vring_call(struct virtio_net *dev __rte_unused,\n }\n \n const struct vhost_transport_ops af_unix_trans_ops = {\n+\t.socket_size = sizeof(struct af_unix_socket),\n \t.vring_call = af_unix_vring_call,\n };\ndiff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h\nindex c363369..9615392 100644\n--- a/lib/librte_vhost/vhost.h\n+++ b/lib/librte_vhost/vhost.h\n@@ -296,6 +296,9 @@ struct virtio_net;\n * A structure containing function pointers for transport-specific operations.\n */\n struct vhost_transport_ops {\n+\t/** Size of struct vhost_user_socket-derived per-socket state */\n+\tsize_t socket_size;\n+\n \t/**\n \t * Notify the guest that used descriptors have been added to the vring.\n \t * The VRING_AVAIL_F_NO_INTERRUPT flag and event idx have already been checked\n@@ -374,6 +377,11 @@ TAILQ_HEAD(vhost_user_connection_list, vhost_user_connection);\n /*\n * Every time rte_vhost_driver_register() is invoked, an associated\n * vhost_user_socket struct will be created.\n+ *\n+ * Transport-specific per-socket state can be kept by embedding this struct at\n+ * the beginning of a transport-specific struct. Set\n+ * vhost_transport_ops->socket_size to the size of the transport-specific\n+ * struct.\n */\n struct vhost_user_socket {\n \tstruct vhost_user_connection_list conn_list;\n@@ -407,6 +415,7 @@ struct vhost_user_socket {\n \tint vdpa_dev_id;\n \n \tstruct vhost_device_ops const *notify_ops;\n+\tstruct vhost_transport_ops const *trans_ops;\n };\n \n struct vhost_user_connection {\n", "prefixes": [ "03/28" ] }