Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54922/?format=api
{ "id": 54922, "url": "http://patches.dpdk.org/api/patches/54922/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190618161636.23748-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190618161636.23748-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190618161636.23748-5-stephen@networkplumber.org", "date": "2019-06-18T16:16:32", "name": "[v3,4/8] kni: drop unused fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d37da3341adf7a1fb44c4ee0e3dabb6d169aabf3", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190618161636.23748-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 5063, "url": "http://patches.dpdk.org/api/series/5063/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5063", "date": "2019-06-18T16:16:28", "name": "kni: fixes and cleanups", "version": 3, "mbox": "http://patches.dpdk.org/series/5063/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54922/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54922/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5D02E1C235;\n\tTue, 18 Jun 2019 18:16:57 +0200 (CEST)", "from mail-pf1-f196.google.com (mail-pf1-f196.google.com\n\t[209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 4863F1C220\n\tfor <dev@dpdk.org>; Tue, 18 Jun 2019 18:16:50 +0200 (CEST)", "by mail-pf1-f196.google.com with SMTP id t16so7928562pfe.11\n\tfor <dev@dpdk.org>; Tue, 18 Jun 2019 09:16:50 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\t3sm15485385pfp.114.2019.06.18.09.16.47\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tTue, 18 Jun 2019 09:16:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=NfmHrhNMiW6Al7ZFuvaqHgd6S0UgmkcDx6rgSHyEXUI=;\n\tb=AcIW7F3Z98R23smpk7FC/pi7Bqfw/P2dB8i4YovYqh4n8EyyO4C6rJ6t7YHlyf7CEa\n\tGoZb/Wv89xv6Iiy06AtjcrvKJOucL1zVh/T0xLEm0vg4LBP1c5vxVu4q5Bei5/4Wt8nL\n\tMQk0/K4FGZLcWyv4oUEBFlSb9ziG4HcA1bj5YnrFuU1l6RTRFwprvgHyueW+ZwYS4PG6\n\tDKNEG26sbsFnwn4FaBW9V9frjsvwOT9CU3ZRkdn4nnNegfSzvQUNKitG+mA4BZz6cENs\n\toS5g8XRDTPsGeeeboiMmr2PZl/iSOe130oSNQ+u9XHreoWU11E9GOFQfw+67TjIz76R9\n\tvtUw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=NfmHrhNMiW6Al7ZFuvaqHgd6S0UgmkcDx6rgSHyEXUI=;\n\tb=fTJGvzA4APXmi4g/59vDrpLCEw9MVpPhHxqbJKD8OVNpvBCyGpd0YdM42aG30I94UU\n\trL9sypMySmLXzJ3j4L5pRqWmN8T8mtZp4rif2EuzQkN6V1BeOy7j/dzwQ3MFUCwe8ha8\n\tieV55GHmmyniups98HHlaYsiKVqcVWlEaKTkTwYQh6PTLU0pwxHsIL7/yliA5kOdJiyg\n\trHXt7D7p/dg0YTCfgmN4bKRKwdTQ3Y0T2YNRmEVWkvAmbJDf3tgO8qqCVm0jxfBiQl39\n\tH02MGDYUJ9x+3FZ3kw+SXxSCYBVfbMLOSke2aJL26RAVFMTbmpJQDpSi3BwAx0l1Ix8l\n\tbAWg==", "X-Gm-Message-State": "APjAAAWmpq2FuEnAS1RPQf8WXWak98tg/a/unDcI15ocodhBL9Rgb36Q\n\t7/FUHB/YEOrdfgtXUST4gjAuKf+iJ/g=", "X-Google-Smtp-Source": "APXvYqwQgM996CMCwY5kVBFRlxnuKH6zv1SNqLVR0bqIbrnbnWlm6dOyzFnDkkrvtBW3ShziOPrcEw==", "X-Received": "by 2002:a17:90a:d814:: with SMTP id\n\ta20mr6053213pjv.48.1560874609186; \n\tTue, 18 Jun 2019 09:16:49 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 18 Jun 2019 09:16:32 -0700", "Message-Id": "<20190618161636.23748-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190618161636.23748-1-stephen@networkplumber.org>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190618161636.23748-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 4/8] kni: drop unused fields", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The kni net structure only exists in driver no API/ABI.\nSeveral fields were either totally unused or set and never used.\n\nThe fields in dev_info do need to stay in the ABI but\nkernel can ignore them.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n\nkni: drop unused status element\n\nYet another ethtool leftover.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_dev.h | 5 -----\n kernel/linux/kni/kni_misc.c | 1 -\n 2 files changed, 6 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h\nindex 21e4b0d92368..f3e6c3ca4efa 100644\n--- a/kernel/linux/kni/kni_dev.h\n+++ b/kernel/linux/kni/kni_dev.h\n@@ -39,8 +39,6 @@ struct kni_dev {\n \t/* kni list */\n \tstruct list_head list;\n \n-\tint status;\n-\tuint16_t group_id; /* Group ID of a group of KNI devices */\n \tuint32_t core_id; /* Core ID to bind */\n \tchar name[RTE_KNI_NAMESIZE]; /* Network device name */\n \tstruct task_struct *pthread;\n@@ -79,9 +77,6 @@ struct kni_dev {\n \t/* mbuf size */\n \tuint32_t mbuf_size;\n \n-\t/* synchro for request processing */\n-\tunsigned long synchro;\n-\n \t/* buffers */\n \tvoid *pa[MBUF_BURST_SZ];\n \tvoid *va[MBUF_BURST_SZ];\ndiff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c\nindex 1fc5eeb9c8ca..b59cf24c2184 100644\n--- a/kernel/linux/kni/kni_misc.c\n+++ b/kernel/linux/kni/kni_misc.c\n@@ -346,7 +346,6 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,\n \tkni = netdev_priv(net_dev);\n \n \tkni->net_dev = net_dev;\n-\tkni->group_id = dev_info.group_id;\n \tkni->core_id = dev_info.core_id;\n \tstrncpy(kni->name, dev_info.name, RTE_KNI_NAMESIZE);\n \n", "prefixes": [ "v3", "4/8" ] }