Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 54919,
    "url": "http://patches.dpdk.org/api/patches/54919/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190618161636.23748-2-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190618161636.23748-2-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190618161636.23748-2-stephen@networkplumber.org",
    "date": "2019-06-18T16:16:29",
    "name": "[v3,1/8] kni: don't need stubs for rx_mode or ioctl",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "9c9aa64c52b5d81df7e947bcc60369bead3d8682",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190618161636.23748-2-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 5063,
            "url": "http://patches.dpdk.org/api/series/5063/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5063",
            "date": "2019-06-18T16:16:28",
            "name": "kni: fixes and cleanups",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/5063/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/54919/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/54919/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 36A9C1C219;\n\tTue, 18 Jun 2019 18:16:49 +0200 (CEST)",
            "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n\t[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 1E9101C10C\n\tfor <dev@dpdk.org>; Tue, 18 Jun 2019 18:16:46 +0200 (CEST)",
            "by mail-pg1-f195.google.com with SMTP id n2so7945467pgp.11\n\tfor <dev@dpdk.org>; Tue, 18 Jun 2019 09:16:46 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\t3sm15485385pfp.114.2019.06.18.09.16.43\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tTue, 18 Jun 2019 09:16:43 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=;\n\tb=cUzmyQu3W5XUJI+sE/fxeNAxi289bSWfx/NNFtX8+dPLBxqdeUY1vFWtkzrYIt+P5c\n\tOHBZ3qt9wjX5qlyYxS0ih+9E/StWaoaS7Q8EyJxN7erZSXJf8BEK/tTxG50M0bahb8gJ\n\tYb9TT4L18mLLzQaleUqqee9fM0N8h1BZHSg0frlX4AL49XCss7mxmuTcz5NIKgZPe/KM\n\t11+tgrMXg0ufloXERCsXZKF6j5hLJMMJ5DDWUOdMLwpChPlWGauWccsLn92P0Poss7e8\n\tNbMsqQuPNhfnDfNilk4lsSROArW5fJytjS7X3nG39NSpEY5MIGDrCN7F5vFdZuQ1+NnP\n\tXWdQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=;\n\tb=fKDtrqMVEi2nw/tizXHqHiE6Mw5C/RrwjCLsv6rT5ij+OmagFfSE8XkRBChazeo16G\n\tHZXT0+/aAUVK/8xlFQD8ByxqclxaUT4PSfF7WMv83E1b3eHYsjxpiZ/mFhU1bbiTAVoA\n\ttc4EJiODiA5R80geBmEnPIqRdc2jSHxI/BTS2XD3+u1DoaM+B0JKIeIQDYfzaHs2rlL8\n\tF1qXu9rY/mkAnirHG/lShDAFzsexTVrBQZIjZ041FejjvIMnHdgZrhmR4jStNaEGVIYm\n\tFQLcaPA5q7rMFzJT2yKSesuqgBsRTdbvDfvMgwh4u1zbN3DJrOrKRe3qV8VWkkiB8lzq\n\t28TQ==",
        "X-Gm-Message-State": "APjAAAXVnyUtkd+cDE63dgXTJ9zDbaTkdp4ScFtszc6KzejX19WWLizu\n\t5uAszlZcqj+SzoFxNAm4MTCAcj8qKYU=",
        "X-Google-Smtp-Source": "APXvYqywg3FnjNY+OYMXzB7fMH/jCwCmOVFkWJc7WY74jFL0lJYbp4vAz6cB53KSXLS2+xwuO3p57w==",
        "X-Received": "by 2002:a17:90a:19d:: with SMTP id\n\t29mr6119777pjc.71.1560874604979; \n\tTue, 18 Jun 2019 09:16:44 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Tue, 18 Jun 2019 09:16:29 -0700",
        "Message-Id": "<20190618161636.23748-2-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190618161636.23748-1-stephen@networkplumber.org>",
        "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190618161636.23748-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v3 1/8] kni: don't need stubs for rx_mode or ioctl",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The netdev subsystem already handles case where\nnetwork sevice does not support ioctl.\n\nIf device has no rx_mode hook it is not called.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_net.c | 19 -------------------\n 1 file changed, 19 deletions(-)",
    "diff": "diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c\nindex ad8365877cda..c86337d099ab 100644\n--- a/kernel/linux/kni/kni_net.c\n+++ b/kernel/linux/kni/kni_net.c\n@@ -593,23 +593,6 @@ kni_net_tx_timeout(struct net_device *dev)\n \tnetif_wake_queue(dev);\n }\n \n-/*\n- * Ioctl commands\n- */\n-static int\n-kni_net_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)\n-{\n-\tpr_debug(\"kni_net_ioctl group:%d cmd:%d\\n\",\n-\t\t((struct kni_dev *)netdev_priv(dev))->group_id, cmd);\n-\n-\treturn -EOPNOTSUPP;\n-}\n-\n-static void\n-kni_net_set_rx_mode(struct net_device *dev)\n-{\n-}\n-\n static int\n kni_net_change_mtu(struct net_device *dev, int new_mtu)\n {\n@@ -758,8 +741,6 @@ static const struct net_device_ops kni_net_netdev_ops = {\n \t.ndo_change_rx_flags = kni_net_set_promiscusity,\n \t.ndo_start_xmit = kni_net_tx,\n \t.ndo_change_mtu = kni_net_change_mtu,\n-\t.ndo_do_ioctl = kni_net_ioctl,\n-\t.ndo_set_rx_mode = kni_net_set_rx_mode,\n \t.ndo_get_stats = kni_net_stats,\n \t.ndo_tx_timeout = kni_net_tx_timeout,\n \t.ndo_set_mac_address = kni_net_set_mac,\n",
    "prefixes": [
        "v3",
        "1/8"
    ]
}