Patch Comment List
List patch comments
GET /api/patches/54900/comments/?format=api
[ { "id": 97278, "web_url": "http://patches.dpdk.org/comment/97278/", "msgid": "<fbd8bc00-9c8e-12e4-ef41-87ec86e5786b@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/fbd8bc00-9c8e-12e4-ef41-87ec86e5786b@redhat.com", "date": "2019-06-19T12:34:40", "subject": "Re: [dpdk-dev] [PATCH 1/4] net/virtio: fix memory leak in in-order\n\tRx", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "content": "On 6/18/19 9:41 AM, Tiwei Bie wrote:\n> When there is no enough segments for a packet in in-order\n> mergeable Rx path, we should free the whole mbuf chain instead\n> of just the last segment.\n\nI would write instead:\n\n\"\nwe should free the whole mbuf chain instead of just recycling the last \nsegment.\n\"\n\nBecause what was done before the patch it to refill the VQ with the last\nsegment. With your patch, the full chain is freed, then the refill is\ndone afterwards.\n\nDo you agree?\n\nOther than that:\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n\nThanks!\nMaxime\n\n> \n> Fixes: e5f456a98d3c (\"net/virtio: support in-order Rx and Tx\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>\n> ---\n> drivers/net/virtio/virtio_rxtx.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\n> index 1f1178467..bdb3a2f18 100644\n> --- a/drivers/net/virtio/virtio_rxtx.c\n> +++ b/drivers/net/virtio/virtio_rxtx.c\n> @@ -1555,7 +1555,7 @@ virtio_recv_pkts_inorder(void *rx_queue,\n> \t\t} else {\n> \t\t\tPMD_RX_LOG(ERR,\n> \t\t\t\t\t\"No enough segments for packet.\");\n> -\t\t\tvirtio_discard_rxbuf_inorder(vq, prev);\n> +\t\t\trte_pktmbuf_free(rx_pkts[nb_rx]);\n> \t\t\trxvq->stats.errors++;\n> \t\t\tbreak;\n> \t\t}\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3563C1C2C2;\n\tWed, 19 Jun 2019 14:34:51 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id E21DE1C291;\n\tWed, 19 Jun 2019 14:34:49 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 09FE7B2DCE;\n\tWed, 19 Jun 2019 12:34:44 +0000 (UTC)", "from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id E17091001E61;\n\tWed, 19 Jun 2019 12:34:41 +0000 (UTC)" ], "To": "Tiwei Bie <tiwei.bie@intel.com>, zhihong.wang@intel.com, dev@dpdk.org", "Cc": "stable@dpdk.org", "References": "<20190618074159.3322-1-tiwei.bie@intel.com>\n\t<20190618074159.3322-2-tiwei.bie@intel.com>", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Message-ID": "<fbd8bc00-9c8e-12e4-ef41-87ec86e5786b@redhat.com>", "Date": "Wed, 19 Jun 2019 14:34:40 +0200", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1", "MIME-Version": "1.0", "In-Reply-To": "<20190618074159.3322-2-tiwei.bie@intel.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Language": "en-US", "Content-Transfer-Encoding": "7bit", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]); Wed, 19 Jun 2019 12:34:44 +0000 (UTC)", "Subject": "Re: [dpdk-dev] [PATCH 1/4] net/virtio: fix memory leak in in-order\n\tRx", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 97304, "web_url": "http://patches.dpdk.org/comment/97304/", "msgid": "<20190620015628.GA2367@___>", "list_archive_url": "https://inbox.dpdk.org/dev/20190620015628.GA2367@___", "date": "2019-06-20T01:56:28", "subject": "Re: [dpdk-dev] [PATCH 1/4] net/virtio: fix memory leak in in-order\n\tRx", "submitter": { "id": 617, "url": "http://patches.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "content": "On Wed, Jun 19, 2019 at 02:34:40PM +0200, Maxime Coquelin wrote:\n> On 6/18/19 9:41 AM, Tiwei Bie wrote:\n> > When there is no enough segments for a packet in in-order\n> > mergeable Rx path, we should free the whole mbuf chain instead\n> > of just the last segment.\n> \n> I would write instead:\n> \n> \"\n> we should free the whole mbuf chain instead of just recycling the last\n> segment.\n> \"\n> \n> Because what was done before the patch it to refill the VQ with the last\n> segment. With your patch, the full chain is freed, then the refill is\n> done afterwards.\n> \n> Do you agree?\n\nYeah, I totally agree :)\n\nThanks!\nTiwei\n\n> \n> Other than that:\n> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n> \n> Thanks!\n> Maxime\n> \n> > \n> > Fixes: e5f456a98d3c (\"net/virtio: support in-order Rx and Tx\")\n> > Cc: stable@dpdk.org\n> > \n> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>\n> > ---\n> > drivers/net/virtio/virtio_rxtx.c | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\n> > index 1f1178467..bdb3a2f18 100644\n> > --- a/drivers/net/virtio/virtio_rxtx.c\n> > +++ b/drivers/net/virtio/virtio_rxtx.c\n> > @@ -1555,7 +1555,7 @@ virtio_recv_pkts_inorder(void *rx_queue,\n> > \t\t} else {\n> > \t\t\tPMD_RX_LOG(ERR,\n> > \t\t\t\t\t\"No enough segments for packet.\");\n> > -\t\t\tvirtio_discard_rxbuf_inorder(vq, prev);\n> > +\t\t\trte_pktmbuf_free(rx_pkts[nb_rx]);\n> > \t\t\trxvq->stats.errors++;\n> > \t\t\tbreak;\n> > \t\t}\n> >", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ABCFC1D07B;\n\tThu, 20 Jun 2019 03:57:46 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 75D901D071;\n\tThu, 20 Jun 2019 03:57:45 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Jun 2019 18:57:44 -0700", "from npg-dpdk-virtio-tbie-2.sh.intel.com (HELO ___)\n\t([10.67.104.151])\n\tby fmsmga004.fm.intel.com with ESMTP; 19 Jun 2019 18:57:41 -0700" ], "X-Amp-Result": "UNKNOWN", "X-Amp-Original-Verdict": "FILE UNKNOWN", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,394,1557212400\"; d=\"scan'208\";a=\"182919828\"", "Date": "Thu, 20 Jun 2019 09:56:28 +0800", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Cc": "zhihong.wang@intel.com, dev@dpdk.org, stable@dpdk.org", "Message-ID": "<20190620015628.GA2367@___>", "References": "<20190618074159.3322-1-tiwei.bie@intel.com>\n\t<20190618074159.3322-2-tiwei.bie@intel.com>\n\t<fbd8bc00-9c8e-12e4-ef41-87ec86e5786b@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "In-Reply-To": "<fbd8bc00-9c8e-12e4-ef41-87ec86e5786b@redhat.com>", "User-Agent": "Mutt/1.9.4 (2018-02-28)", "Subject": "Re: [dpdk-dev] [PATCH 1/4] net/virtio: fix memory leak in in-order\n\tRx", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]