Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54848/?format=api
{ "id": 54848, "url": "http://patches.dpdk.org/api/patches/54848/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560783924-5355-3-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560783924-5355-3-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560783924-5355-3-git-send-email-david.marchand@redhat.com", "date": "2019-06-17T15:05:23", "name": "[2/3] net/bnx2x: fix invalid free on unplug", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1517ac70e3dd62c9aa16407dc0037c14d3ac193c", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560783924-5355-3-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 5035, "url": "http://patches.dpdk.org/api/series/5035/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5035", "date": "2019-06-17T15:05:21", "name": "ethdev mac_addrs cleanups", "version": 1, "mbox": "http://patches.dpdk.org/series/5035/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54848/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/54848/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 267891BF3E;\n\tMon, 17 Jun 2019 17:06:01 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 680B22BE6;\n\tMon, 17 Jun 2019 17:05:59 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2313530C084B;\n\tMon, 17 Jun 2019 15:05:50 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.205.71])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 98A335F5A4;\n\tMon, 17 Jun 2019 15:05:46 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, stable@dpdk.org,\n\tRasesh Mody <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>", "Date": "Mon, 17 Jun 2019 17:05:23 +0200", "Message-Id": "<1560783924-5355-3-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1560783924-5355-1-git-send-email-david.marchand@redhat.com>", "References": "<1560783924-5355-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.46]); Mon, 17 Jun 2019 15:05:55 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 2/3] net/bnx2x: fix invalid free on unplug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "mac_addrs points to a field in dev_private.\nWe can't let ethdev free it.\n\nFixes: e16adf08e54d (\"ethdev: free all common data when releasing port\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/bnx2x/bnx2x_ethdev.c | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c\nindex 45c6c36..f47a73c 100644\n--- a/drivers/net/bnx2x/bnx2x_ethdev.c\n+++ b/drivers/net/bnx2x/bnx2x_ethdev.c\n@@ -701,6 +701,13 @@ void bnx2x_periodic_stop(void *param)\n \treturn bnx2x_common_dev_init(eth_dev, 1);\n }\n \n+static int eth_bnx2x_dev_uninit(struct rte_eth_dev *eth_dev)\n+{\n+\t/* mac_addrs must not be freed alone because part of dev_private */\n+\teth_dev->data->mac_addrs = NULL;\n+\treturn 0;\n+}\n+\n static struct rte_pci_driver rte_bnx2x_pmd;\n static struct rte_pci_driver rte_bnx2xvf_pmd;\n \n@@ -719,7 +726,7 @@ static int eth_bnx2x_pci_probe(struct rte_pci_driver *pci_drv,\n \n static int eth_bnx2x_pci_remove(struct rte_pci_device *pci_dev)\n {\n-\treturn rte_eth_dev_pci_generic_remove(pci_dev, NULL);\n+\treturn rte_eth_dev_pci_generic_remove(pci_dev, eth_bnx2x_dev_uninit);\n }\n \n static struct rte_pci_driver rte_bnx2x_pmd = {\n", "prefixes": [ "2/3" ] }