Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54847/?format=api
http://patches.dpdk.org/api/patches/54847/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560783924-5355-2-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560783924-5355-2-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560783924-5355-2-git-send-email-david.marchand@redhat.com", "date": "2019-06-17T15:05:22", "name": "[1/3] net/nfb: avoid memory leak on unplug", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "83f116bcb7d96ac81ea0702f18d0de01b6ff0756", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560783924-5355-2-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 5035, "url": "http://patches.dpdk.org/api/series/5035/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5035", "date": "2019-06-17T15:05:21", "name": "ethdev mac_addrs cleanups", "version": 1, "mbox": "http://patches.dpdk.org/series/5035/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54847/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/54847/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 466891BEF6;\n\tMon, 17 Jun 2019 17:05:52 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 2F5A92BE6\n\tfor <dev@dpdk.org>; Mon, 17 Jun 2019 17:05:51 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 27C36356E8;\n\tMon, 17 Jun 2019 15:05:46 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.205.71])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D760E5944E;\n\tMon, 17 Jun 2019 15:05:40 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com,\n\tRastislav Cernay <cernay@netcope.com>, Jan Remes <remes@netcope.com>", "Date": "Mon, 17 Jun 2019 17:05:22 +0200", "Message-Id": "<1560783924-5355-2-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1560783924-5355-1-git-send-email-david.marchand@redhat.com>", "References": "<1560783924-5355-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]); Mon, 17 Jun 2019 15:05:48 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 1/3] net/nfb: avoid memory leak on unplug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Clearing mac_addrs on remove will prevent ethdev from freeing it.\n\nFixes: 6435f9a0ac22 (\"net/nfb: add new netcope driver\")\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/nfb/nfb_ethdev.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c\nindex fdd0e70..6f77864 100644\n--- a/drivers/net/nfb/nfb_ethdev.c\n+++ b/drivers/net/nfb/nfb_ethdev.c\n@@ -510,8 +510,6 @@\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n \tstruct rte_pci_addr *pci_addr = &pci_dev->addr;\n \n-\tdev->data->mac_addrs = NULL;\n-\n \tnfb_nc_rxmac_deinit(internals->rxmac, internals->max_rxmac);\n \tnfb_nc_txmac_deinit(internals->txmac, internals->max_txmac);\n \n", "prefixes": [ "1/3" ] }{ "id": 54847, "url": "