Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54831/?format=api
{ "id": 54831, "url": "http://patches.dpdk.org/api/patches/54831/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560680229-8166-1-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560680229-8166-1-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560680229-8166-1-git-send-email-arybchenko@solarflare.com", "date": "2019-06-16T10:17:08", "name": "[v3,1/2] net/virtio: add Tx preparation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "85e18468acd85979e0b7a35b506197ad3a1d8691", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560680229-8166-1-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 5025, "url": "http://patches.dpdk.org/api/series/5025/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5025", "date": "2019-06-16T10:17:08", "name": "[v3,1/2] net/virtio: add Tx preparation", "version": 3, "mbox": "http://patches.dpdk.org/series/5025/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54831/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54831/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 97E021BB0B;\n\tSun, 16 Jun 2019 12:17:31 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 8DB1C1B9F5;\n\tSun, 16 Jun 2019 12:17:30 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t3D0A0140066; Sun, 16 Jun 2019 10:17:28 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Sun, 16 Jun 2019 03:17:25 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Sun, 16 Jun 2019 03:17:25 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx5GAHNQa025359; Sun, 16 Jun 2019 11:17:23 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tE2600161621; Sun, 16 Jun 2019 11:17:23 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie\n\t<tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>", "CC": "<dev@dpdk.org>, Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>,\n\t<stable@dpdk.org>", "Date": "Sun, 16 Jun 2019 11:17:08 +0100", "Message-ID": "<1560680229-8166-1-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1559587805-1637-1-git-send-email-arybchenko@solarflare.com>", "References": "<1559587805-1637-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24682.005", "X-TM-AS-Result": "No-5.898300-4.000000-10", "X-TMASE-MatchedRID": "ubjSOKZrdK2jJwaIeQ4C0EdAWPMBu8kQNU8z+tFJHR2sBbMjHUED8LER\n\tMpuIU2oe4XHxYgeGSGV1F2UJ40Hu5gVQ1xLwjqxoHcQQBuf4ZFsmKH/Kj46+VZGhAvBSa2i/e/p\n\twbu325eoCx1zwFcslvVO9V994jC9DrSKKfw/QqNV8nLwuiNHSSEtc8DbogbSE31GU/N5W5BA0NS\n\tC223LgVWvHBlNaXPoaZ0xJsWXSiHBUf9SbrSddM0f49ONH0RaSQG0p9pfNzlFFpeiWAzLHcV1o7\n\twPE6VhYj5vFt7iE12CAMuqetGVetnyef22ep6XYOwBXM346/+yCQ5wxnGR7bEUFZNuztA/Dxdwa\n\t5ubVxJYusX8bjl+R0LlNaftDsRep", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--5.898300-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24682.005", "X-MDID": "1560680248-HmvB0UMY5vHP", "Subject": "[dpdk-dev] [PATCH v3 1/2] net/virtio: add Tx preparation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>\n\nVirtio requires pseudo-header checksum in TCP/UDP checksum to do\noffload, but it was lost when Tx prepare is introduced. Also\nrte_validate_tx_offload() should be used to validate Tx offloads.\n\nAlso it is incorrect to do virtio_tso_fix_cksum() after prepend\nto mbuf without taking prepended size into account, since layer 2/3/4\nlengths provide incorrect offsets after prepend.\n\nFixes: 4fb7e803eb1a (\"ethdev: add Tx preparation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\nv3:\n - add a patch to move soft VLAN insertion to Tx prepare\n\n drivers/net/virtio/virtio_ethdev.c | 1 +\n drivers/net/virtio/virtio_ethdev.h | 3 +++\n drivers/net/virtio/virtio_rxtx.c | 32 +++++++++++++++++++++++++++++-\n 3 files changed, 35 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex c4570bbf8..97d3c293e 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1473,6 +1473,7 @@ set_rxtx_funcs(struct rte_eth_dev *eth_dev)\n {\n \tstruct virtio_hw *hw = eth_dev->data->dev_private;\n \n+\teth_dev->tx_pkt_prepare = virtio_xmit_pkts_prepare;\n \tif (vtpci_packed_queue(hw)) {\n \t\tPMD_INIT_LOG(INFO,\n \t\t\t\"virtio: using packed ring %s Tx path on port %u\",\ndiff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h\nindex 45e96f32b..20d331795 100644\n--- a/drivers/net/virtio/virtio_ethdev.h\n+++ b/drivers/net/virtio/virtio_ethdev.h\n@@ -89,6 +89,9 @@ uint16_t virtio_recv_mergeable_pkts_packed(void *rx_queue,\n uint16_t virtio_recv_pkts_inorder(void *rx_queue,\n \t\tstruct rte_mbuf **rx_pkts, uint16_t nb_pkts);\n \n+uint16_t virtio_xmit_pkts_prepare(void *tx_queue, struct rte_mbuf **tx_pkts,\n+\t\tuint16_t nb_pkts);\n+\n uint16_t virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\tuint16_t nb_pkts);\n uint16_t virtio_xmit_pkts_packed(void *tx_queue, struct rte_mbuf **tx_pkts,\ndiff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex 1f1178467..07f8f47de 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -559,7 +559,6 @@ virtqueue_xmit_offload(struct virtio_net_hdr *hdr,\n \n \t\t/* TCP Segmentation Offload */\n \t\tif (cookie->ol_flags & PKT_TX_TCP_SEG) {\n-\t\t\tvirtio_tso_fix_cksum(cookie);\n \t\t\thdr->gso_type = (cookie->ol_flags & PKT_TX_IPV6) ?\n \t\t\t\tVIRTIO_NET_HDR_GSO_TCPV6 :\n \t\t\t\tVIRTIO_NET_HDR_GSO_TCPV4;\n@@ -1949,6 +1948,37 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,\n \treturn nb_rx;\n }\n \n+uint16_t\n+virtio_xmit_pkts_prepare(void *tx_queue __rte_unused, struct rte_mbuf **tx_pkts,\n+\t\t\tuint16_t nb_pkts)\n+{\n+\tuint16_t nb_tx;\n+\tint error;\n+\n+\tfor (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) {\n+\t\tstruct rte_mbuf *m = tx_pkts[nb_tx];\n+\n+#ifdef RTE_LIBRTE_ETHDEV_DEBUG\n+\t\terror = rte_validate_tx_offload(m);\n+\t\tif (unlikely(error)) {\n+\t\t\trte_errno = -error;\n+\t\t\tbreak;\n+\t\t}\n+#endif\n+\n+\t\terror = rte_net_intel_cksum_prepare(m);\n+\t\tif (unlikely(error)) {\n+\t\t\trte_errno = -error;\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tif (m->ol_flags & PKT_TX_TCP_SEG)\n+\t\t\tvirtio_tso_fix_cksum(m);\n+\t}\n+\n+\treturn nb_tx;\n+}\n+\n uint16_t\n virtio_xmit_pkts_packed(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\tuint16_t nb_pkts)\n", "prefixes": [ "v3", "1/2" ] }