Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54761/?format=api
{ "id": 54761, "url": "http://patches.dpdk.org/api/patches/54761/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190613092117.7252-3-marcinx.hajkowski@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190613092117.7252-3-marcinx.hajkowski@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190613092117.7252-3-marcinx.hajkowski@intel.com", "date": "2019-06-13T09:21:17", "name": "[v4,2/2] doc: update according to the fifo per core impl", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "71398b660e68b3e4dea0581908eed9257151d6d7", "submitter": { "id": 1246, "url": "http://patches.dpdk.org/api/people/1246/?format=api", "name": "Marcin Hajkowski", "email": "marcinx.hajkowski@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190613092117.7252-3-marcinx.hajkowski@intel.com/mbox/", "series": [ { "id": 4997, "url": "http://patches.dpdk.org/api/series/4997/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4997", "date": "2019-06-13T09:21:15", "name": "Fifo per core", "version": 4, "mbox": "http://patches.dpdk.org/series/4997/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54761/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54761/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4F7BD1D388;\n\tThu, 13 Jun 2019 11:23:08 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id B5C311D2D5\n\tfor <dev@dpdk.org>; Thu, 13 Jun 2019 11:23:03 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Jun 2019 02:23:03 -0700", "from mhajkowx-mobl.ger.corp.intel.com ([10.104.12.161])\n\tby fmsmga001.fm.intel.com with ESMTP; 13 Jun 2019 02:23:01 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Hajkowski <marcinx.hajkowski@intel.com>", "To": "david.hunt@intel.com", "Cc": "dev@dpdk.org, Marcin Hajkowski <marcinx.hajkowski@intel.com>,\n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>,\n\tLukasz Gosiewski <lukaszx.gosiewski@intel.com>", "Date": "Thu, 13 Jun 2019 11:21:17 +0200", "Message-Id": "<20190613092117.7252-3-marcinx.hajkowski@intel.com>", "X-Mailer": "git-send-email 2.20.1.windows.1", "In-Reply-To": "<20190613092117.7252-1-marcinx.hajkowski@intel.com>", "References": "<20190424082152.5396-1-lukaszx.gosiewski@intel.com>\n\t<20190613092117.7252-1-marcinx.hajkowski@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 2/2] doc: update according to the fifo per\n\tcore impl", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Marcin Hajkowski <marcinx.hajkowski@intel.com>\n\nUpdated power management docs for fifo JSON API.\nRemoved from JSON API:\n* 'name'\n* 'resource_id'\n* 'core_list'\n\nSigned-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\nSigned-off-by: Lukasz Gosiewski <lukaszx.gosiewski@intel.com>\n---\n .../sample_app_ug/vm_power_management.rst | 61 +++++--------------\n 1 file changed, 14 insertions(+), 47 deletions(-)", "diff": "diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst\nindex 5d9a26172..0ffff835e 100644\n--- a/doc/guides/sample_app_ug/vm_power_management.rst\n+++ b/doc/guides/sample_app_ug/vm_power_management.rst\n@@ -380,9 +380,16 @@ parsing functionality will not be present in the app.\n \n Sending a command or policy to the power manager application is achieved by\n simply opening a fifo file, writing a JSON string to that fifo, and closing\n-the file.\n+the file. In actual implementation every core has own dedicated fifo[0..n],\n+where n is number of the last available core.\n+Having a dedicated fifo file per core allows using standard filesystem permissions\n+to ensure a given container can only write JSON commands into fifos it is allowed\n+to use.\n \n-The fifo is at /tmp/powermonitor/fifo\n+The fifo is at /tmp/powermonitor/fifo[0..n]\n+\n+For example all cmds put to the /tmp/powermonitor/fifo7, will have\n+effect only on CPU[7].\n \n The JSON string can be a policy or instruction, and takes the following\n format:\n@@ -405,19 +412,6 @@ arrays, etc. Examples of policies follow later in this document. The allowed\n names and value types are as follows:\n \n \n-:Pair Name: \"name\"\n-:Description: Name of the VM or Host. Allows the parser to associate the\n- policy with the relevant VM or Host OS.\n-:Type: string\n-:Values: any valid string\n-:Required: yes\n-:Example:\n-\n- .. code-block:: javascript\n-\n- \"name\", \"ubuntu2\"\n-\n-\n :Pair Name: \"command\"\n :Description: The type of packet we're sending to the power manager. We can be\n creating or destroying a policy, or sending a direct command to adjust\n@@ -509,17 +503,6 @@ names and value types are as follows:\n \n \"max_packet_thresh\": 500000\n \n-:Pair Name: \"core_list\"\n-:Description: The cores to which to apply the policy.\n-:Type: array of integers\n-:Values: array with list of virtual CPUs.\n-:Required: only policy CREATE/DESTROY\n-:Example:\n-\n- .. code-block:: javascript\n-\n- \"core_list\":[ 10, 11 ]\n-\n :Pair Name: \"workload\"\n :Description: When our policy is of type WORKLOAD, we need to specify how\n heavy our workload is.\n@@ -566,17 +549,6 @@ names and value types are as follows:\n \n \"unit\", \"SCALE_MAX\"\n \n-:Pair Name: \"resource_id\"\n-:Description: The core to which to apply the power command.\n-:Type: integer\n-:Values: valid core id for VM or host OS.\n-:Required: only POWER instruction\n-:Example:\n-\n- .. code-block:: javascript\n-\n- \"resource_id\": 10\n-\n JSON API Examples\n ~~~~~~~~~~~~~~~~~\n \n@@ -585,12 +557,10 @@ Profile create example:\n .. code-block:: javascript\n \n {\"policy\": {\n- \"name\": \"ubuntu\",\n \"command\": \"create\",\n \"policy_type\": \"TIME\",\n \"busy_hours\":[ 17, 18, 19, 20, 21, 22, 23 ],\n- \"quiet_hours\":[ 2, 3, 4, 5, 6 ],\n- \"core_list\":[ 11 ]\n+ \"quiet_hours\":[ 2, 3, 4, 5, 6 ]\n }}\n \n Profile destroy example:\n@@ -598,8 +568,7 @@ Profile destroy example:\n .. code-block:: javascript\n \n {\"policy\": {\n- \"name\": \"ubuntu\",\n- \"command\": \"destroy\",\n+ \"command\": \"destroy\"\n }}\n \n Power command example:\n@@ -607,18 +576,16 @@ Power command example:\n .. code-block:: javascript\n \n {\"instruction\": {\n- \"name\": \"ubuntu\",\n \"command\": \"power\",\n- \"unit\": \"SCALE_MAX\",\n- \"resource_id\": 10\n+ \"unit\": \"SCALE_MAX\"\n }}\n \n To send a JSON string to the Power Manager application, simply paste the\n-example JSON string into a text file and cat it into the fifo:\n+example JSON string into a text file and cat it into the proper fifo:\n \n .. code-block:: console\n \n- cat file.json >/tmp/powermonitor/fifo\n+ cat file.json >/tmp/powermonitor/fifo[0..n]\n \n The console of the Power Manager application should indicate the command that\n was just received via the fifo.\n", "prefixes": [ "v4", "2/2" ] }