Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54717/?format=api
{ "id": 54717, "url": "http://patches.dpdk.org/api/patches/54717/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190611155221.2703-60-leyi.rong@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190611155221.2703-60-leyi.rong@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190611155221.2703-60-leyi.rong@intel.com", "date": "2019-06-11T15:52:14", "name": "[v2,59/66] net/ice/base: rework API for ice zero bitmap", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4cb35825dcfdfd420453ff314d044e86278af17e", "submitter": { "id": 1204, "url": "http://patches.dpdk.org/api/people/1204/?format=api", "name": "Leyi Rong", "email": "leyi.rong@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190611155221.2703-60-leyi.rong@intel.com/mbox/", "series": [ { "id": 4981, "url": "http://patches.dpdk.org/api/series/4981/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4981", "date": "2019-06-11T15:51:15", "name": "shared code update", "version": 2, "mbox": "http://patches.dpdk.org/series/4981/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54717/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54717/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 35D431C60F;\n\tTue, 11 Jun 2019 17:55:45 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 7205C1C486\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 17:54:52 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Jun 2019 08:54:52 -0700", "from lrong-srv-03.sh.intel.com ([10.67.119.177])\n\tby orsmga001.jf.intel.com with ESMTP; 11 Jun 2019 08:54:50 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Leyi Rong <leyi.rong@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Leyi Rong <leyi.rong@intel.com>,\n\tJacob Keller <jacob.e.keller@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Tue, 11 Jun 2019 23:52:14 +0800", "Message-Id": "<20190611155221.2703-60-leyi.rong@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190611155221.2703-1-leyi.rong@intel.com>", "References": "<20190604054248.68510-1-leyi.rong@intel.com>\n\t<20190611155221.2703-1-leyi.rong@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 59/66] net/ice/base: rework API for ice zero\n\tbitmap", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix ice_zero_bitmap to zero the entire storage.\n\nFixes: c9e37832c95f (\"net/ice/base: rework on bit ops\")\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Leyi Rong <leyi.rong@intel.com>\n---\n drivers/net/ice/base/ice_bitops.h | 19 ++++++-------------\n 1 file changed, 6 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_bitops.h b/drivers/net/ice/base/ice_bitops.h\nindex f52713021..aca5529a6 100644\n--- a/drivers/net/ice/base/ice_bitops.h\n+++ b/drivers/net/ice/base/ice_bitops.h\n@@ -147,22 +147,15 @@ ice_test_and_set_bit(u16 nr, ice_bitmap_t *bitmap)\n * @bmp: bitmap to set zeros\n * @size: Size of the bitmaps in bits\n *\n- * This function sets bits of a bitmap to zero.\n+ * Set all of the bits in a bitmap to zero. Note that this function assumes it\n+ * operates on an ice_bitmap_t which was declared using ice_declare_bitmap. It\n+ * will zero every bit in the last chunk, even if those bits are beyond the\n+ * size.\n */\n static inline void ice_zero_bitmap(ice_bitmap_t *bmp, u16 size)\n {\n-\tice_bitmap_t mask;\n-\tu16 i;\n-\n-\t/* Handle all but last chunk*/\n-\tfor (i = 0; i < BITS_TO_CHUNKS(size) - 1; i++)\n-\t\tbmp[i] = 0;\n-\t/* For the last chunk, we want to take care of not to modify bits\n-\t * outside the size boundary. ~mask take care of all the bits outside\n-\t * the boundary.\n-\t */\n-\tmask = LAST_CHUNK_MASK(size);\n-\tbmp[i] &= ~mask;\n+\tice_memset(bmp, 0, BITS_TO_CHUNKS(size) * sizeof(ice_bitmap_t),\n+\t\t ICE_NONDMA_MEM);\n }\n \n /**\n", "prefixes": [ "v2", "59/66" ] }