Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54702/?format=api
http://patches.dpdk.org/api/patches/54702/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190611155221.2703-44-leyi.rong@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190611155221.2703-44-leyi.rong@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190611155221.2703-44-leyi.rong@intel.com", "date": "2019-06-11T15:51:58", "name": "[v2,43/66] net/ice/base: add new API to dealloc flow entry", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "acdd4c6335348acfe688bfb3dc0e3bc30af2c678", "submitter": { "id": 1204, "url": "http://patches.dpdk.org/api/people/1204/?format=api", "name": "Leyi Rong", "email": "leyi.rong@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190611155221.2703-44-leyi.rong@intel.com/mbox/", "series": [ { "id": 4981, "url": "http://patches.dpdk.org/api/series/4981/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4981", "date": "2019-06-11T15:51:15", "name": "shared code update", "version": 2, "mbox": "http://patches.dpdk.org/series/4981/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54702/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54702/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 99BA31C5A8;\n\tTue, 11 Jun 2019 17:55:16 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 9FBCE1C520\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 17:54:31 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Jun 2019 08:54:31 -0700", "from lrong-srv-03.sh.intel.com ([10.67.119.177])\n\tby orsmga001.jf.intel.com with ESMTP; 11 Jun 2019 08:54:30 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Leyi Rong <leyi.rong@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Leyi Rong <leyi.rong@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Tue, 11 Jun 2019 23:51:58 +0800", "Message-Id": "<20190611155221.2703-44-leyi.rong@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190611155221.2703-1-leyi.rong@intel.com>", "References": "<20190604054248.68510-1-leyi.rong@intel.com>\n\t<20190611155221.2703-1-leyi.rong@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 43/66] net/ice/base: add new API to dealloc\n\tflow entry", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Decouple ice_dealloc_flow_entry from ice_flow_rem_entry_sync.\n\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Leyi Rong <leyi.rong@intel.com>\n---\n drivers/net/ice/base/ice_flow.c | 35 ++++++++++++++++++++++++---------\n 1 file changed, 26 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c\nindex 48cfa897d..0dad62010 100644\n--- a/drivers/net/ice/base/ice_flow.c\n+++ b/drivers/net/ice/base/ice_flow.c\n@@ -932,17 +932,15 @@ ice_flow_find_prof_id(struct ice_hw *hw, enum ice_block blk, u64 prof_id)\n }\n \n /**\n- * ice_flow_rem_entry_sync - Remove a flow entry\n+ * ice_dealloc_flow_entry - Deallocate flow entry memory\n * @hw: pointer to the HW struct\n * @entry: flow entry to be removed\n */\n-static enum ice_status\n-ice_flow_rem_entry_sync(struct ice_hw *hw, struct ice_flow_entry *entry)\n+static void\n+ice_dealloc_flow_entry(struct ice_hw *hw, struct ice_flow_entry *entry)\n {\n \tif (!entry)\n-\t\treturn ICE_ERR_BAD_PTR;\n-\n-\tLIST_DEL(&entry->l_entry);\n+\t\treturn;\n \n \tif (entry->entry)\n \t\tice_free(hw, entry->entry);\n@@ -954,6 +952,22 @@ ice_flow_rem_entry_sync(struct ice_hw *hw, struct ice_flow_entry *entry)\n \t}\n \n \tice_free(hw, entry);\n+}\n+\n+/**\n+ * ice_flow_rem_entry_sync - Remove a flow entry\n+ * @hw: pointer to the HW struct\n+ * @entry: flow entry to be removed\n+ */\n+static enum ice_status\n+ice_flow_rem_entry_sync(struct ice_hw *hw, struct ice_flow_entry *entry)\n+{\n+\tif (!entry)\n+\t\treturn ICE_ERR_BAD_PTR;\n+\n+\tLIST_DEL(&entry->l_entry);\n+\n+\tice_dealloc_flow_entry(hw, entry);\n \n \treturn ICE_SUCCESS;\n }\n@@ -1392,9 +1406,12 @@ ice_flow_add_entry(struct ice_hw *hw, enum ice_block blk, u64 prof_id,\n \t\tgoto out;\n \t}\n \n-\tice_acquire_lock(&prof->entries_lock);\n-\tLIST_ADD(&e->l_entry, &prof->entries);\n-\tice_release_lock(&prof->entries_lock);\n+\tif (blk != ICE_BLK_ACL) {\n+\t\t/* ACL will handle the entry management */\n+\t\tice_acquire_lock(&prof->entries_lock);\n+\t\tLIST_ADD(&e->l_entry, &prof->entries);\n+\t\tice_release_lock(&prof->entries_lock);\n+\t}\n \n \t*entry_h = ICE_FLOW_ENTRY_HNDL(e);\n \n", "prefixes": [ "v2", "43/66" ] }{ "id": 54702, "url": "