Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 54700,
    "url": "http://patches.dpdk.org/api/patches/54700/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190611155221.2703-42-leyi.rong@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190611155221.2703-42-leyi.rong@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190611155221.2703-42-leyi.rong@intel.com",
    "date": "2019-06-11T15:51:56",
    "name": "[v2,41/66] net/ice/base: silent semantic parser warnings",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "3837f355aba84f70b07ca20dc22b24297265b42a",
    "submitter": {
        "id": 1204,
        "url": "http://patches.dpdk.org/api/people/1204/?format=api",
        "name": "Leyi Rong",
        "email": "leyi.rong@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "http://patches.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190611155221.2703-42-leyi.rong@intel.com/mbox/",
    "series": [
        {
            "id": 4981,
            "url": "http://patches.dpdk.org/api/series/4981/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4981",
            "date": "2019-06-11T15:51:15",
            "name": "shared code update",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/4981/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/54700/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/54700/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9A3A41C5A0;\n\tTue, 11 Jun 2019 17:55:13 +0200 (CEST)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 305EA1C509\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 17:54:29 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Jun 2019 08:54:28 -0700",
            "from lrong-srv-03.sh.intel.com ([10.67.119.177])\n\tby orsmga001.jf.intel.com with ESMTP; 11 Jun 2019 08:54:27 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "From": "Leyi Rong <leyi.rong@intel.com>",
        "To": "qi.z.zhang@intel.com",
        "Cc": "dev@dpdk.org, Leyi Rong <leyi.rong@intel.com>,\n\tBruce Allan <bruce.w.allan@intel.com>,\n\tKevin Scott <kevin.c.scott@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>",
        "Date": "Tue, 11 Jun 2019 23:51:56 +0800",
        "Message-Id": "<20190611155221.2703-42-leyi.rong@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20190611155221.2703-1-leyi.rong@intel.com>",
        "References": "<20190604054248.68510-1-leyi.rong@intel.com>\n\t<20190611155221.2703-1-leyi.rong@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 41/66] net/ice/base: silent semantic parser\n\twarnings",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Eliminate some semantic warnings, static analysis warnings.\n\nSigned-off-by: Bruce Allan <bruce.w.allan@intel.com>\nSigned-off-by: Kevin Scott <kevin.c.scott@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Leyi Rong <leyi.rong@intel.com>\n---\n drivers/net/ice/base/ice_flex_pipe.c     | 8 ++++----\n drivers/net/ice/base/ice_flow.c          | 5 +----\n drivers/net/ice/base/ice_nvm.c           | 4 ++--\n drivers/net/ice/base/ice_protocol_type.h | 1 +\n drivers/net/ice/base/ice_switch.c        | 8 +++-----\n drivers/net/ice/base/ice_type.h          | 7 ++++++-\n 6 files changed, 17 insertions(+), 16 deletions(-)",
    "diff": "diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex f7d6d9194..d5f0707b6 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -134,7 +134,7 @@ static struct ice_buf_table *ice_find_buf_table(struct ice_seg *ice_seg)\n \tnvms = (struct ice_nvm_table *)(ice_seg->device_table +\n \t\tLE32_TO_CPU(ice_seg->device_table_count));\n \n-\treturn (struct ice_buf_table *)\n+\treturn (_FORCE_ struct ice_buf_table *)\n \t\t(nvms->vers + LE32_TO_CPU(nvms->table_count));\n }\n \n@@ -2937,7 +2937,7 @@ static void ice_fill_tbl(struct ice_hw *hw, enum ice_block block_id, u32 sid)\n \t\tcase ICE_SID_XLT2_ACL:\n \t\tcase ICE_SID_XLT2_PE:\n \t\t\txlt2 = (struct ice_xlt2_section *)sect;\n-\t\t\tsrc = (u8 *)xlt2->value;\n+\t\t\tsrc = (_FORCE_ u8 *)xlt2->value;\n \t\t\tsect_len = LE16_TO_CPU(xlt2->count) *\n \t\t\t\tsizeof(*hw->blk[block_id].xlt2.t);\n \t\t\tdst = (u8 *)hw->blk[block_id].xlt2.t;\n@@ -3889,7 +3889,7 @@ ice_update_fd_swap(struct ice_hw *hw, u16 prof_id, struct ice_fv_word *es)\n \n \t/* fill in the swap array */\n \tsi = hw->blk[ICE_BLK_FD].es.fvw - 1;\n-\tdo {\n+\twhile (si >= 0) {\n \t\tu8 indexes_used = 1;\n \n \t\t/* assume flat at this index */\n@@ -3921,7 +3921,7 @@ ice_update_fd_swap(struct ice_hw *hw, u16 prof_id, struct ice_fv_word *es)\n \t\t}\n \n \t\tsi -= indexes_used;\n-\t} while (si >= 0);\n+\t}\n \n \t/* for each set of 4 swap indexes, write the appropriate register */\n \tfor (j = 0; j < hw->blk[ICE_BLK_FD].es.fvw / 4; j++) {\ndiff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c\nindex 795abe98f..48cfa897d 100644\n--- a/drivers/net/ice/base/ice_flow.c\n+++ b/drivers/net/ice/base/ice_flow.c\n@@ -415,9 +415,6 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params)\n \t\tconst ice_bitmap_t *src;\n \t\tu32 hdrs;\n \n-\t\tif (i > 0 && (i + 1) < prof->segs_cnt)\n-\t\t\tcontinue;\n-\n \t\thdrs = prof->segs[i].hdrs;\n \n \t\tif (hdrs & ICE_FLOW_SEG_HDR_ETH) {\n@@ -1425,7 +1422,7 @@ enum ice_status ice_flow_rem_entry(struct ice_hw *hw, u64 entry_h)\n \tif (entry_h == ICE_FLOW_ENTRY_HANDLE_INVAL)\n \t\treturn ICE_ERR_PARAM;\n \n-\tentry = ICE_FLOW_ENTRY_PTR((unsigned long)entry_h);\n+\tentry = ICE_FLOW_ENTRY_PTR(entry_h);\n \n \t/* Retain the pointer to the flow profile as the entry will be freed */\n \tprof = entry->prof;\ndiff --git a/drivers/net/ice/base/ice_nvm.c b/drivers/net/ice/base/ice_nvm.c\nindex fa9c348ce..76cfedb29 100644\n--- a/drivers/net/ice/base/ice_nvm.c\n+++ b/drivers/net/ice/base/ice_nvm.c\n@@ -127,7 +127,7 @@ ice_read_sr_word_aq(struct ice_hw *hw, u16 offset, u16 *data)\n \n \tstatus = ice_read_sr_aq(hw, offset, 1, data, true);\n \tif (!status)\n-\t\t*data = LE16_TO_CPU(*(__le16 *)data);\n+\t\t*data = LE16_TO_CPU(*(_FORCE_ __le16 *)data);\n \n \treturn status;\n }\n@@ -185,7 +185,7 @@ ice_read_sr_buf_aq(struct ice_hw *hw, u16 offset, u16 *words, u16 *data)\n \t} while (words_read < *words);\n \n \tfor (i = 0; i < *words; i++)\n-\t\tdata[i] = LE16_TO_CPU(((__le16 *)data)[i]);\n+\t\tdata[i] = LE16_TO_CPU(((_FORCE_ __le16 *)data)[i]);\n \n read_nvm_buf_aq_exit:\n \t*words = words_read;\ndiff --git a/drivers/net/ice/base/ice_protocol_type.h b/drivers/net/ice/base/ice_protocol_type.h\nindex e572dd320..82822fb74 100644\n--- a/drivers/net/ice/base/ice_protocol_type.h\n+++ b/drivers/net/ice/base/ice_protocol_type.h\n@@ -189,6 +189,7 @@ struct ice_udp_tnl_hdr {\n \tu16 field;\n \tu16 proto_type;\n \tu16 vni;\n+\tu16 reserved;\n };\n \n struct ice_nvgre {\ndiff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex faaedd4c8..77bcf9aa8 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -859,7 +859,7 @@ ice_aq_add_update_mir_rule(struct ice_hw *hw, u16 rule_type, u16 dest_vsi,\n \t\t\treturn ICE_ERR_PARAM;\n \n \t\tbuf_size = count * sizeof(__le16);\n-\t\tmr_list = (__le16 *)ice_malloc(hw, buf_size);\n+\t\tmr_list = (_FORCE_ __le16 *)ice_malloc(hw, buf_size);\n \t\tif (!mr_list)\n \t\t\treturn ICE_ERR_NO_MEMORY;\n \t\tbreak;\n@@ -1459,7 +1459,6 @@ static int ice_ilog2(u64 n)\n \treturn -1;\n }\n \n-\n /**\n  * ice_fill_sw_rule - Helper function to fill switch rule structure\n  * @hw: pointer to the hardware structure\n@@ -1479,7 +1478,6 @@ ice_fill_sw_rule(struct ice_hw *hw, struct ice_fltr_info *f_info,\n \t__be16 *off;\n \tu8 q_rgn;\n \n-\n \tif (opc == ice_aqc_opc_remove_sw_rules) {\n \t\ts_rule->pdata.lkup_tx_rx.act = 0;\n \t\ts_rule->pdata.lkup_tx_rx.index =\n@@ -1555,7 +1553,7 @@ ice_fill_sw_rule(struct ice_hw *hw, struct ice_fltr_info *f_info,\n \t\tdaddr = f_info->l_data.ethertype_mac.mac_addr;\n \t\t/* fall-through */\n \tcase ICE_SW_LKUP_ETHERTYPE:\n-\t\toff = (__be16 *)(eth_hdr + ICE_ETH_ETHTYPE_OFFSET);\n+\t\toff = (_FORCE_ __be16 *)(eth_hdr + ICE_ETH_ETHTYPE_OFFSET);\n \t\t*off = CPU_TO_BE16(f_info->l_data.ethertype_mac.ethertype);\n \t\tbreak;\n \tcase ICE_SW_LKUP_MAC_VLAN:\n@@ -1586,7 +1584,7 @@ ice_fill_sw_rule(struct ice_hw *hw, struct ice_fltr_info *f_info,\n \t\t\t   ICE_NONDMA_TO_NONDMA);\n \n \tif (!(vlan_id > ICE_MAX_VLAN_ID)) {\n-\t\toff = (__be16 *)(eth_hdr + ICE_ETH_VLAN_TCI_OFFSET);\n+\t\toff = (_FORCE_ __be16 *)(eth_hdr + ICE_ETH_VLAN_TCI_OFFSET);\n \t\t*off = CPU_TO_BE16(vlan_id);\n \t}\n \ndiff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h\nindex 919ca7fa8..e0820b679 100644\n--- a/drivers/net/ice/base/ice_type.h\n+++ b/drivers/net/ice/base/ice_type.h\n@@ -14,6 +14,10 @@\n \n #define BITS_PER_BYTE\t8\n \n+#ifndef _FORCE_\n+#define _FORCE_\n+#endif\n+\n #define ICE_BYTES_PER_WORD\t2\n #define ICE_BYTES_PER_DWORD\t4\n #define ICE_MAX_TRAFFIC_CLASS\t8\n@@ -35,7 +39,7 @@\n #endif\n \n #ifndef IS_ASCII\n-#define IS_ASCII(_ch)  ((_ch) < 0x80)\n+#define IS_ASCII(_ch)\t((_ch) < 0x80)\n #endif\n \n #include \"ice_status.h\"\n@@ -745,6 +749,7 @@ struct ice_hw {\n \tu8 pf_id;\t\t/* device profile info */\n \n \tu16 max_burst_size;\t/* driver sets this value */\n+\n \t/* Tx Scheduler values */\n \tu16 num_tx_sched_layers;\n \tu16 num_tx_sched_phys_layers;\n",
    "prefixes": [
        "v2",
        "41/66"
    ]
}