Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54697/?format=api
http://patches.dpdk.org/api/patches/54697/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190611155221.2703-39-leyi.rong@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190611155221.2703-39-leyi.rong@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190611155221.2703-39-leyi.rong@intel.com", "date": "2019-06-11T15:51:53", "name": "[v2,38/66] net/ice/base: add lock around profile map list", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "71e4cfaf2712854aad7d261571841d9f839c7480", "submitter": { "id": 1204, "url": "http://patches.dpdk.org/api/people/1204/?format=api", "name": "Leyi Rong", "email": "leyi.rong@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190611155221.2703-39-leyi.rong@intel.com/mbox/", "series": [ { "id": 4981, "url": "http://patches.dpdk.org/api/series/4981/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4981", "date": "2019-06-11T15:51:15", "name": "shared code update", "version": 2, "mbox": "http://patches.dpdk.org/series/4981/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54697/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54697/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3D7E31C590;\n\tTue, 11 Jun 2019 17:55:09 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 128141C40D\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 17:54:24 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Jun 2019 08:54:24 -0700", "from lrong-srv-03.sh.intel.com ([10.67.119.177])\n\tby orsmga001.jf.intel.com with ESMTP; 11 Jun 2019 08:54:23 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Leyi Rong <leyi.rong@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Leyi Rong <leyi.rong@intel.com>,\n\tDan Nowlin <dan.nowlin@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Tue, 11 Jun 2019 23:51:53 +0800", "Message-Id": "<20190611155221.2703-39-leyi.rong@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190611155221.2703-1-leyi.rong@intel.com>", "References": "<20190604054248.68510-1-leyi.rong@intel.com>\n\t<20190611155221.2703-1-leyi.rong@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 38/66] net/ice/base: add lock around profile\n\tmap list", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add locking mechanism around profile map list.\n\nSigned-off-by: Dan Nowlin <dan.nowlin@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Leyi Rong <leyi.rong@intel.com>\n---\n drivers/net/ice/base/ice_flex_pipe.c | 31 +++++++++++++++++-----------\n 1 file changed, 19 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex c2d1be484..f7d6d9194 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -3973,6 +3973,8 @@ ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],\n \tu32 byte = 0;\n \tu8 prof_id;\n \n+\tice_acquire_lock(&hw->blk[blk].es.prof_map_lock);\n+\n \t/* search for existing profile */\n \tstatus = ice_find_prof_id(hw, blk, es, &prof_id);\n \tif (status) {\n@@ -4044,11 +4046,12 @@ ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],\n \t\tbytes--;\n \t\tbyte++;\n \t}\n-\tLIST_ADD(&prof->list, &hw->blk[blk].es.prof_map);\n \n-\treturn ICE_SUCCESS;\n+\tLIST_ADD(&prof->list, &hw->blk[blk].es.prof_map);\n+\tstatus = ICE_SUCCESS;\n \n err_ice_add_prof:\n+\tice_release_lock(&hw->blk[blk].es.prof_map_lock);\n \treturn status;\n }\n \n@@ -4350,29 +4353,33 @@ ice_rem_flow_all(struct ice_hw *hw, enum ice_block blk, u64 id)\n */\n enum ice_status ice_rem_prof(struct ice_hw *hw, enum ice_block blk, u64 id)\n {\n-\tenum ice_status status;\n \tstruct ice_prof_map *pmap;\n+\tenum ice_status status;\n \n-\tpmap = ice_search_prof_id(hw, blk, id);\n-\tif (!pmap)\n-\t\treturn ICE_ERR_DOES_NOT_EXIST;\n+\tice_acquire_lock(&hw->blk[blk].es.prof_map_lock);\n+\n+\tpmap = ice_search_prof_id_low(hw, blk, id);\n+\tif (!pmap) {\n+\t\tstatus = ICE_ERR_DOES_NOT_EXIST;\n+\t\tgoto err_ice_rem_prof;\n+\t}\n \n \t/* remove all flows with this profile */\n \tstatus = ice_rem_flow_all(hw, blk, pmap->profile_cookie);\n \tif (status)\n-\t\treturn status;\n+\t\tgoto err_ice_rem_prof;\n \n-\t/* remove profile */\n-\tstatus = ice_free_prof_id(hw, blk, pmap->prof_id);\n-\tif (status)\n-\t\treturn status;\n \t/* dereference profile, and possibly remove */\n \tice_prof_dec_ref(hw, blk, pmap->prof_id);\n \n \tLIST_DEL(&pmap->list);\n \tice_free(hw, pmap);\n \n-\treturn ICE_SUCCESS;\n+\tstatus = ICE_SUCCESS;\n+\n+err_ice_rem_prof:\n+\tice_release_lock(&hw->blk[blk].es.prof_map_lock);\n+\treturn status;\n }\n \n /**\n", "prefixes": [ "v2", "38/66" ] }{ "id": 54697, "url": "