Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54686/?format=api
{ "id": 54686, "url": "http://patches.dpdk.org/api/patches/54686/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190611155221.2703-28-leyi.rong@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190611155221.2703-28-leyi.rong@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190611155221.2703-28-leyi.rong@intel.com", "date": "2019-06-11T15:51:42", "name": "[v2,27/66] net/ice/base: add some minor features", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dde4e731ff683acfa5c9c73b6bdea2dc0a83dbcb", "submitter": { "id": 1204, "url": "http://patches.dpdk.org/api/people/1204/?format=api", "name": "Leyi Rong", "email": "leyi.rong@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190611155221.2703-28-leyi.rong@intel.com/mbox/", "series": [ { "id": 4981, "url": "http://patches.dpdk.org/api/series/4981/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4981", "date": "2019-06-11T15:51:15", "name": "shared code update", "version": 2, "mbox": "http://patches.dpdk.org/series/4981/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54686/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54686/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 646CE1C54A;\n\tTue, 11 Jun 2019 17:54:46 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id C06E01C4CC\n\tfor <dev@dpdk.org>; Tue, 11 Jun 2019 17:54:11 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Jun 2019 08:54:11 -0700", "from lrong-srv-03.sh.intel.com ([10.67.119.177])\n\tby orsmga001.jf.intel.com with ESMTP; 11 Jun 2019 08:54:10 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Leyi Rong <leyi.rong@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Leyi Rong <leyi.rong@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Tue, 11 Jun 2019 23:51:42 +0800", "Message-Id": "<20190611155221.2703-28-leyi.rong@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190611155221.2703-1-leyi.rong@intel.com>", "References": "<20190604054248.68510-1-leyi.rong@intel.com>\n\t<20190611155221.2703-1-leyi.rong@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 27/66] net/ice/base: add some minor features", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "1. Add loopback reporting to get link response.\n2. Add infrastructure for NVM Write/Write Activate calls.\n3. Add opcode for NVM save factory settings/NVM Update EMPR command.\n4. Add lan overflow event to ice_aq_desc.\n\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Leyi Rong <leyi.rong@intel.com>\n---\n drivers/net/ice/base/ice_adminq_cmd.h | 47 ++++++++++++++++++---------\n 1 file changed, 32 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/net/ice/base/ice_adminq_cmd.h\nindex 77f93b950..4e6bce18c 100644\n--- a/drivers/net/ice/base/ice_adminq_cmd.h\n+++ b/drivers/net/ice/base/ice_adminq_cmd.h\n@@ -110,6 +110,7 @@ struct ice_aqc_list_caps {\n struct ice_aqc_list_caps_elem {\n \t__le16 cap;\n #define ICE_AQC_CAPS_VALID_FUNCTIONS\t\t\t0x0005\n+#define ICE_AQC_MAX_VALID_FUNCTIONS\t\t\t0x8\n #define ICE_AQC_CAPS_VSI\t\t\t\t0x0017\n #define ICE_AQC_CAPS_DCB\t\t\t\t0x0018\n #define ICE_AQC_CAPS_RSS\t\t\t\t0x0040\n@@ -143,11 +144,9 @@ struct ice_aqc_manage_mac_read {\n #define ICE_AQC_MAN_MAC_WOL_ADDR_VALID\t\tBIT(7)\n #define ICE_AQC_MAN_MAC_READ_S\t\t\t4\n #define ICE_AQC_MAN_MAC_READ_M\t\t\t(0xF << ICE_AQC_MAN_MAC_READ_S)\n-\tu8 lport_num;\n-\tu8 lport_num_valid;\n-#define ICE_AQC_MAN_MAC_PORT_NUM_IS_VALID\tBIT(0)\n+\tu8 rsvd[2];\n \tu8 num_addr; /* Used in response */\n-\tu8 reserved[3];\n+\tu8 rsvd1[3];\n \t__le32 addr_high;\n \t__le32 addr_low;\n };\n@@ -165,7 +164,7 @@ struct ice_aqc_manage_mac_read_resp {\n \n /* Manage MAC address, write command - direct (0x0108) */\n struct ice_aqc_manage_mac_write {\n-\tu8 port_num;\n+\tu8 rsvd;\n \tu8 flags;\n #define ICE_AQC_MAN_MAC_WR_MC_MAG_EN\t\tBIT(0)\n #define ICE_AQC_MAN_MAC_WR_WOL_LAA_PFR_KEEP\tBIT(1)\n@@ -481,8 +480,8 @@ struct ice_aqc_vsi_props {\n #define ICE_AQ_VSI_VLAN_MODE_TAGGED\t0x2\n #define ICE_AQ_VSI_VLAN_MODE_ALL\t0x3\n #define ICE_AQ_VSI_PVLAN_INSERT_PVID\tBIT(2)\n-#define ICE_AQ_VSI_VLAN_EMOD_S\t3\n-#define ICE_AQ_VSI_VLAN_EMOD_M\t(0x3 << ICE_AQ_VSI_VLAN_EMOD_S)\n+#define ICE_AQ_VSI_VLAN_EMOD_S\t\t3\n+#define ICE_AQ_VSI_VLAN_EMOD_M\t\t(0x3 << ICE_AQ_VSI_VLAN_EMOD_S)\n #define ICE_AQ_VSI_VLAN_EMOD_STR_BOTH\t(0x0 << ICE_AQ_VSI_VLAN_EMOD_S)\n #define ICE_AQ_VSI_VLAN_EMOD_STR_UP\t(0x1 << ICE_AQ_VSI_VLAN_EMOD_S)\n #define ICE_AQ_VSI_VLAN_EMOD_STR\t(0x2 << ICE_AQ_VSI_VLAN_EMOD_S)\n@@ -1425,6 +1424,7 @@ struct ice_aqc_get_phy_caps_data {\n #define ICE_AQC_PHY_FEC_25G_RS_CLAUSE91_EN\t\tBIT(6)\n #define ICE_AQC_PHY_FEC_25G_KR_CLAUSE74_EN\t\tBIT(7)\n #define ICE_AQC_PHY_FEC_MASK\t\t\t\tMAKEMASK(0xdf, 0)\n+\tu8 rsvd1;\t/* Byte 35 reserved */\n \tu8 extended_compliance_code;\n #define ICE_MODULE_TYPE_TOTAL_BYTE\t\t\t3\n \tu8 module_type[ICE_MODULE_TYPE_TOTAL_BYTE];\n@@ -1439,13 +1439,14 @@ struct ice_aqc_get_phy_caps_data {\n #define ICE_AQC_MOD_TYPE_BYTE2_SFP_PLUS\t\t\t0xA0\n #define ICE_AQC_MOD_TYPE_BYTE2_QSFP_PLUS\t\t0x86\n \tu8 qualified_module_count;\n+\tu8 rsvd2[7];\t/* Bytes 47:41 reserved */\n #define ICE_AQC_QUAL_MOD_COUNT_MAX\t\t\t16\n \tstruct {\n \t\tu8 v_oui[3];\n \t\tu8 rsvd3;\n \t\tu8 v_part[16];\n \t\t__le32 v_rev;\n-\t\t__le64 rsvd8;\n+\t\t__le64 rsvd4;\n \t} qual_modules[ICE_AQC_QUAL_MOD_COUNT_MAX];\n };\n \n@@ -1571,7 +1572,12 @@ struct ice_aqc_get_link_status_data {\n #define ICE_AQ_LINK_TX_ACTIVE\t\t0\n #define ICE_AQ_LINK_TX_DRAINED\t\t1\n #define ICE_AQ_LINK_TX_FLUSHED\t\t3\n-\tu8 reserved2;\n+\tu8 lb_status;\n+#define ICE_AQ_LINK_LB_PHY_LCL\t\tBIT(0)\n+#define ICE_AQ_LINK_LB_PHY_RMT\t\tBIT(1)\n+#define ICE_AQ_LINK_LB_MAC_LCL\t\tBIT(2)\n+#define ICE_AQ_LINK_LB_PHY_IDX_S\t3\n+#define ICE_AQ_LINK_LB_PHY_IDX_M\t(0x7 << ICE_AQ_LB_PHY_IDX_S)\n \t__le16 max_frame_size;\n \tu8 cfg;\n #define ICE_AQ_LINK_25G_KR_FEC_EN\tBIT(0)\n@@ -1659,20 +1665,26 @@ struct ice_aqc_set_port_id_led {\n \n /* NVM Read command (indirect 0x0701)\n * NVM Erase commands (direct 0x0702)\n- * NVM Update commands (indirect 0x0703)\n+ * NVM Write commands (indirect 0x0703)\n+ * NVM Write Activate commands (direct 0x0707)\n+ * NVM Shadow RAM Dump commands (direct 0x0707)\n */\n struct ice_aqc_nvm {\n \t__le16 offset_low;\n \tu8 offset_high;\n \tu8 cmd_flags;\n #define ICE_AQC_NVM_LAST_CMD\t\tBIT(0)\n-#define ICE_AQC_NVM_PCIR_REQ\t\tBIT(0)\t/* Used by NVM Update reply */\n-#define ICE_AQC_NVM_PRESERVATION_S\t1\n+#define ICE_AQC_NVM_PCIR_REQ\t\tBIT(0)\t/* Used by NVM Write reply */\n+#define ICE_AQC_NVM_PRESERVATION_S\t1 /* Used by NVM Write Activate only */\n #define ICE_AQC_NVM_PRESERVATION_M\t(3 << ICE_AQC_NVM_PRESERVATION_S)\n #define ICE_AQC_NVM_NO_PRESERVATION\t(0 << ICE_AQC_NVM_PRESERVATION_S)\n #define ICE_AQC_NVM_PRESERVE_ALL\tBIT(1)\n #define ICE_AQC_NVM_FACTORY_DEFAULT\t(2 << ICE_AQC_NVM_PRESERVATION_S)\n #define ICE_AQC_NVM_PRESERVE_SELECTED\t(3 << ICE_AQC_NVM_PRESERVATION_S)\n+#define ICE_AQC_NVM_ACTIV_SEL_NVM\tBIT(3) /* Write Activate/SR Dump only */\n+#define ICE_AQC_NVM_ACTIV_SEL_OROM\tBIT(4)\n+#define ICE_AQC_NVM_ACTIV_SEL_EXT_TLV\tBIT(5)\n+#define ICE_AQC_NVM_ACTIV_SEL_MASK\tMAKEMASK(0x7, 3)\n #define ICE_AQC_NVM_FLASH_ONLY\t\tBIT(7)\n \t__le16 module_typeid;\n \t__le16 length;\n@@ -1832,7 +1844,7 @@ struct ice_aqc_get_cee_dcb_cfg_resp {\n };\n \n /* Set Local LLDP MIB (indirect 0x0A08)\n- * Used to replace the local MIB of a given LLDP agent. e.g. DCBx\n+ * Used to replace the local MIB of a given LLDP agent. e.g. DCBX\n */\n struct ice_aqc_lldp_set_local_mib {\n \tu8 type;\n@@ -1857,7 +1869,7 @@ struct ice_aqc_lldp_set_local_mib_resp {\n };\n \n /* Stop/Start LLDP Agent (direct 0x0A09)\n- * Used for stopping/starting specific LLDP agent. e.g. DCBx.\n+ * Used for stopping/starting specific LLDP agent. e.g. DCBX.\n * The same structure is used for the response, with the command field\n * being used as the status field.\n */\n@@ -2321,6 +2333,7 @@ struct ice_aq_desc {\n \t\tstruct ice_aqc_set_mac_cfg set_mac_cfg;\n \t\tstruct ice_aqc_set_event_mask set_event_mask;\n \t\tstruct ice_aqc_get_link_status get_link_status;\n+\t\tstruct ice_aqc_event_lan_overflow lan_overflow;\n \t} params;\n };\n \n@@ -2492,10 +2505,14 @@ enum ice_adminq_opc {\n \t/* NVM commands */\n \tice_aqc_opc_nvm_read\t\t\t\t= 0x0701,\n \tice_aqc_opc_nvm_erase\t\t\t\t= 0x0702,\n-\tice_aqc_opc_nvm_update\t\t\t\t= 0x0703,\n+\tice_aqc_opc_nvm_write\t\t\t\t= 0x0703,\n \tice_aqc_opc_nvm_cfg_read\t\t\t= 0x0704,\n \tice_aqc_opc_nvm_cfg_write\t\t\t= 0x0705,\n \tice_aqc_opc_nvm_checksum\t\t\t= 0x0706,\n+\tice_aqc_opc_nvm_write_activate\t\t\t= 0x0707,\n+\tice_aqc_opc_nvm_sr_dump\t\t\t\t= 0x0707,\n+\tice_aqc_opc_nvm_save_factory_settings\t\t= 0x0708,\n+\tice_aqc_opc_nvm_update_empr\t\t\t= 0x0709,\n \n \t/* LLDP commands */\n \tice_aqc_opc_lldp_get_mib\t\t\t= 0x0A00,\n", "prefixes": [ "v2", "27/66" ] }