Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54629/?format=api
{ "id": 54629, "url": "http://patches.dpdk.org/api/patches/54629/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190610175155.21374-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190610175155.21374-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190610175155.21374-7-stephen@networkplumber.org", "date": "2019-06-10T17:51:54", "name": "[v2,6/7] kni: return -EFAULT if copy_from_user fails", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c6cf09b1d314385dad9c045b30da4db2e7d65ce8", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190610175155.21374-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 4971, "url": "http://patches.dpdk.org/api/series/4971/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4971", "date": "2019-06-10T17:51:48", "name": "kni: cleanups and improvements", "version": 2, "mbox": "http://patches.dpdk.org/series/4971/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54629/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54629/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 985B71C1B6;\n\tMon, 10 Jun 2019 19:52:15 +0200 (CEST)", "from mail-pg1-f194.google.com (mail-pg1-f194.google.com\n\t[209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 23DC41C136\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 19:52:07 +0200 (CEST)", "by mail-pg1-f194.google.com with SMTP id v11so5423029pgl.5\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 10:52:07 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tl38sm131656pje.12.2019.06.10.10.52.05\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 10 Jun 2019 10:52:05 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=1NDmwzHrmZPX3u9NF7x3GeKUDjSznkLaHCXozcreu7g=;\n\tb=u1V9T0BQ1st5o44n5rvzwGumdNLUrxJAALPcWLKCX3fgjjeJTmJNqnCIy9X87ERnF/\n\t1FzSCE346YTcWnTsu/sFIpcuH+PpPydGjEQ/bXGvajrcbWgbk8W0dtM3Fxmc7mGgL47W\n\tqqeR1mexu4Ie1KIykWF2ri6mKTtjQqhzRsRtAdXLr5kAuhN/WBMZ9rJ7PdpnLxS7bDPz\n\tZsWsA0rxIxtEwJPYdtN9oiVZgUYsOKwSOjVA13+C5KUIVx+lHsNJIBVkqtMFLyG9l20U\n\tbklaC4ftDvUVOysk1QTzjD5PrkWgyYtwHGQ10u9ZhvFsTUrWf63gBns5HPbQPxbujfCC\n\tS8FA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=1NDmwzHrmZPX3u9NF7x3GeKUDjSznkLaHCXozcreu7g=;\n\tb=Mo83NKINMjNPHNC1Gnzwt8gXr/+WUOvWYUKg0zXud7sMgj2niXSS1usKHoJy7ZgzxW\n\t/WXkUtCjMvXrG7VF0X/MbXW/r39+zIJ+l6MPBECnnG/ttoFCX7REwmDFy0FSBVyGN0A6\n\tqFsF0jZ6KnzM4jXxw+TQe7b52u17ECYK+gW1l5WCmXtM/KpVtGCt6R9HgEiBEBL4oKQN\n\t06b38yygW6msMvFlUZLIr2ETyN6E2seUHygP8rpX60/RG0T/1QBl4sjOXZOc3gYSnqJX\n\tc0IaFv9p3qrWFRcr+5x6afYPv5kPRvXkgXiNeE1nfAA34VCUm36CdwPVb7kFWrOcwK5V\n\tlf6Q==", "X-Gm-Message-State": "APjAAAUgbkEUKbHdrpaGWY93Seie1YOpuvml+oATyONiw56nM5crSy1g\n\tBHoNEizFQcjt2ClBhYPT2orQ3nqNUNY=", "X-Google-Smtp-Source": "APXvYqyjIF2QMrhwNqJZZukyNJcXHII+yj5VGtDXEq4Vjw1WLWCdDMuIOcyg90/r2An3bHLFLupqFQ==", "X-Received": "by 2002:a63:545a:: with SMTP id\n\te26mr16453089pgm.162.1560189126265; \n\tMon, 10 Jun 2019 10:52:06 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 10 Jun 2019 10:51:54 -0700", "Message-Id": "<20190610175155.21374-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190610175155.21374-1-stephen@networkplumber.org>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 6/7] kni: return -EFAULT if copy_from_user\n\tfails", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The correct thing to return if user gives a bad data\nis to return -EFAULT. Logging is also discouraged because\nit could be used as a DoS attack.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_misc.c | 16 +++++-----------\n 1 file changed, 5 insertions(+), 11 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c\nindex 6a206d883c0d..a67991066cd9 100644\n--- a/kernel/linux/kni/kni_misc.c\n+++ b/kernel/linux/kni/kni_misc.c\n@@ -301,11 +301,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,\n \t\treturn -EINVAL;\n \n \t/* Copy kni info from user space */\n-\tret = copy_from_user(&dev_info, (void *)ioctl_param, sizeof(dev_info));\n-\tif (ret) {\n-\t\tpr_err(\"copy_from_user in kni_ioctl_create\");\n-\t\treturn -EIO;\n-\t}\n+\tif (copy_from_user(&dev_info, (void *)ioctl_param, sizeof(dev_info)))\n+\t\treturn -EFAULT;\n \n \t/* Check if name is zero-ended */\n \tif (strnlen(dev_info.name, sizeof(dev_info.name)) == sizeof(dev_info.name)) {\n@@ -433,15 +430,12 @@ kni_ioctl_release(struct net *net, uint32_t ioctl_num,\n \tif (_IOC_SIZE(ioctl_num) > sizeof(dev_info))\n \t\treturn -EINVAL;\n \n-\tret = copy_from_user(&dev_info, (void *)ioctl_param, sizeof(dev_info));\n-\tif (ret) {\n-\t\tpr_err(\"copy_from_user in kni_ioctl_release\");\n-\t\treturn -EIO;\n-\t}\n+\tif (copy_from_user(&dev_info, (void *)ioctl_param, sizeof(dev_info)))\n+\t\treturn -EFAULT;\n \n \t/* Release the network device according to its name */\n \tif (strlen(dev_info.name) == 0)\n-\t\treturn ret;\n+\t\treturn -EINVAL;\n \n \tdown_write(&knet->kni_list_lock);\n \tlist_for_each_entry_safe(dev, n, &knet->kni_list_head, list) {\n", "prefixes": [ "v2", "6/7" ] }