Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 54628,
    "url": "http://patches.dpdk.org/api/patches/54628/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190610175155.21374-6-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190610175155.21374-6-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190610175155.21374-6-stephen@networkplumber.org",
    "date": "2019-06-10T17:51:53",
    "name": "[v2,5/7] kni: use proper type for kni fifo's",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "ea3b0b24974d20d15fdf8bcacf32c23a1df694bb",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190610175155.21374-6-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 4971,
            "url": "http://patches.dpdk.org/api/series/4971/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4971",
            "date": "2019-06-10T17:51:48",
            "name": "kni: cleanups and improvements",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/4971/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/54628/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/54628/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 407881C1AF;\n\tMon, 10 Jun 2019 19:52:13 +0200 (CEST)",
            "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n\t[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 0AB3F1C18F\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 19:52:06 +0200 (CEST)",
            "by mail-pg1-f195.google.com with SMTP id l19so2824384pgh.9\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 10:52:05 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tl38sm131656pje.12.2019.06.10.10.52.04\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 10 Jun 2019 10:52:04 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=;\n\tb=hIvjCiWQYNPBc9jHxV6ypMMauQl+MwhXQziimacjCDO/UVfsavYjONek6p+xRa7cQJ\n\tN7zYKRBa7XYUp4sythvbZiiXZz6BJLxlFdrYMCucBIW0GSTniCl0BdNKjnnxPSEOkgXD\n\tck39/mTrbIJ5iwTTLRi9QGsUKJo5NK5QJlGj7qpV+FshVt/R5XxeY02DCbycvl3rPSrS\n\tT6hihyHqh1Io3Ww+K/FR8yqsdY53KReJ0jv2AK00FFLjoyOoLl1VOnsj1EzWLjZFcce3\n\tcIcO8hOaWpb9wxkyIeLGjm4CEO70ugGUo26wVerb66gIg/GOZjpO/TMtZGCdg3wzLGsl\n\tY1Lw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=;\n\tb=FZBR8ppc2dYmXZyIuBI9B+Ot5Cgydb2rIvMrSYDPViD3dJuDefp/4j+XQNz0E6dOKE\n\tYPl85d4wuK/J9SmZFCa5yD9Ym8R+jNIZ5WDi/GivjrMTzSgQK05c+buBtnIbQBf+Mwua\n\t2kSf9obgrLPNwei99Qt9jj4/OEuMFbIKTeldMU0bKWyXsYSbBqQm42GHlezsZYajo65v\n\tHzHzOWMDJPgLMFAvjEuPSsIjq3+1fERBtEZsADOvwSOvP8QwwzqDWQsm8xxmfLlSN2vT\n\t4HLxq1hCNfl3155CRVX3Qmz9suNVi0q3sRpMXV35KokVqaDuNAmT8zjY1bqRs2gLPhLu\n\tw/KQ==",
        "X-Gm-Message-State": "APjAAAUsVFuPFBt8XdntZz5Tf2HYTr3krHOD5ODLwDIL67+785vtf7pG\n\tXePYV06dwKwhGJL83iiJPPJyMMf4zCM=",
        "X-Google-Smtp-Source": "APXvYqxdnXYMpsvwGRCEgnbF5n69f+6YmKd67hT/yNp/+5AkWFplqBH/OWBiPEbMcJhqouubSXbnRQ==",
        "X-Received": "by 2002:a17:90a:270f:: with SMTP id\n\to15mr10315930pje.56.1560189125189; \n\tMon, 10 Jun 2019 10:52:05 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "ferruh.yigit@intel.com",
        "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>",
        "Date": "Mon, 10 Jun 2019 10:51:53 -0700",
        "Message-Id": "<20190610175155.21374-6-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190610175155.21374-1-stephen@networkplumber.org>",
        "References": "<20190610175155.21374-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v2 5/7] kni: use proper type for kni fifo's",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Using void * instead of proper type is unsafe practice.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_dev.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h\nindex f3e6c3ca4efa..ceba5f73c1d9 100644\n--- a/kernel/linux/kni/kni_dev.h\n+++ b/kernel/linux/kni/kni_dev.h\n@@ -51,22 +51,22 @@ struct kni_dev {\n \tstruct net_device *net_dev;\n \n \t/* queue for packets to be sent out */\n-\tvoid *tx_q;\n+\tstruct rte_kni_fifo *tx_q;\n \n \t/* queue for the packets received */\n-\tvoid *rx_q;\n+\tstruct rte_kni_fifo *rx_q;\n \n \t/* queue for the allocated mbufs those can be used to save sk buffs */\n-\tvoid *alloc_q;\n+\tstruct rte_kni_fifo *alloc_q;\n \n \t/* free queue for the mbufs to be freed */\n-\tvoid *free_q;\n+\tstruct rte_kni_fifo *free_q;\n \n \t/* request queue */\n-\tvoid *req_q;\n+\tstruct rte_kni_fifo *req_q;\n \n \t/* response queue */\n-\tvoid *resp_q;\n+\tstruct rte_kni_fifo *resp_q;\n \n \tvoid *sync_kva;\n \tvoid *sync_va;\n",
    "prefixes": [
        "v2",
        "5/7"
    ]
}