Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 54627,
    "url": "http://patches.dpdk.org/api/patches/54627/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190610175155.21374-5-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190610175155.21374-5-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190610175155.21374-5-stephen@networkplumber.org",
    "date": "2019-06-10T17:51:52",
    "name": "[v2,4/7] kni: drop unused fields",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "3d4c369de2de55dcbb90b5578517c55a62f021c6",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190610175155.21374-5-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 4971,
            "url": "http://patches.dpdk.org/api/series/4971/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4971",
            "date": "2019-06-10T17:51:48",
            "name": "kni: cleanups and improvements",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/4971/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/54627/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/54627/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8CC681C1A8;\n\tMon, 10 Jun 2019 19:52:11 +0200 (CEST)",
            "from mail-pg1-f194.google.com (mail-pg1-f194.google.com\n\t[209.85.215.194]) by dpdk.org (Postfix) with ESMTP id BA82E1C135\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 19:52:04 +0200 (CEST)",
            "by mail-pg1-f194.google.com with SMTP id 196so5429647pgc.6\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 10:52:04 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tl38sm131656pje.12.2019.06.10.10.52.02\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 10 Jun 2019 10:52:02 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=1pSTZV4+/Q1KZc07u24BEg4URuj4PrYE5hFyVDmyCkQ=;\n\tb=ui6XvEq2HAhl+Mn4ZNUIR0+PIjTJQTGH5YiDNHnIooYkf4S85M75CJy1m2VSGe/vcp\n\tm3ybpBb2edBulJ/lkqn4d+KTS/ZyCnEYkFpTRcrNcLvOJBH7B74xsx9YqKJs+YGIJAha\n\tIDfb3pVgpAxdtZmf+o2ZIFuP+OnQuc1XzrwdSG92mjgO/ENKesKztFGO887Ti9rsGi5r\n\t8rQnwOmFxmpWgOqHUGMaDmkJ2YclGTiBS/2lazHSV4j9bzGsvl7SUqUDSzzP9wn0tKwp\n\t+KivNS7lhNhIQ86wFz9NBidmOyUKkYEQq10ewGFJlzdOGLfvQf8ZFnAC4vmAqDoG9Gvd\n\t1VgA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=1pSTZV4+/Q1KZc07u24BEg4URuj4PrYE5hFyVDmyCkQ=;\n\tb=I3rJj1yQ2uqM1+nOPOn9XQ+JbMg3aX0GuThn8hB+Wrc7H5oz2tYDy6xjMO5uw9pPPv\n\t74OWDz0uXcp+txdjeiXmKmyB2py7V3nxwWeDDjLFFGTSHy5Py8xCvvn0f7LZYkRBOW4h\n\tIltqN/fRhVvPtUGnIEvEY4d0P3obMe1ARuX/UllTvZySnBD6SlBdX0GhpzaS+s1xYMr4\n\trbeFbxZM/GQFkSWHkIrMjIEPV6nvhFX5G4k28qbkkatikFcz5pQdmdXC/IvMLkMmMNYD\n\trRot2PnSh1zjNqvzK1l5N2bO1tz0NkWdoXM0sp18h3nAQp6d6pL9JwSI3K1bQUBGImUA\n\tkQfQ==",
        "X-Gm-Message-State": "APjAAAVIxeHRv5A+hKR6TEwsU9xTF5SwEvleLuwQ1UhM4JARzhx2gEqo\n\tA4LvuAMzE6lt+anVdgojA3hFGw==",
        "X-Google-Smtp-Source": "APXvYqwx7oR1kSuNE+NYh/iojy3je7EKvFpCWpNOthY4Hi5K8VvhX1EaWzchKDa83iKFAdWGTXZ59g==",
        "X-Received": "by 2002:a63:6105:: with SMTP id\n\tv5mr16592270pgb.312.1560189123877; \n\tMon, 10 Jun 2019 10:52:03 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "ferruh.yigit@intel.com",
        "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>",
        "Date": "Mon, 10 Jun 2019 10:51:52 -0700",
        "Message-Id": "<20190610175155.21374-5-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190610175155.21374-1-stephen@networkplumber.org>",
        "References": "<20190610175155.21374-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v2 4/7] kni: drop unused fields",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The kni net structure only exists in driver no API/ABI.\nSeveral fields were either totally unused or set and never used.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_dev.h  | 8 --------\n kernel/linux/kni/kni_misc.c | 1 -\n 2 files changed, 9 deletions(-)",
    "diff": "diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h\nindex f3a1f60d4bdc..f3e6c3ca4efa 100644\n--- a/kernel/linux/kni/kni_dev.h\n+++ b/kernel/linux/kni/kni_dev.h\n@@ -39,8 +39,6 @@ struct kni_dev {\n \t/* kni list */\n \tstruct list_head list;\n \n-\tint status;\n-\tuint16_t group_id;           /* Group ID of a group of KNI devices */\n \tuint32_t core_id;            /* Core ID to bind */\n \tchar name[RTE_KNI_NAMESIZE]; /* Network device name */\n \tstruct task_struct *pthread;\n@@ -49,9 +47,6 @@ struct kni_dev {\n \twait_queue_head_t wq;\n \tstruct mutex sync_lock;\n \n-\t/* PCI device id */\n-\tuint16_t device_id;\n-\n \t/* kni device */\n \tstruct net_device *net_dev;\n \n@@ -82,9 +77,6 @@ struct kni_dev {\n \t/* mbuf size */\n \tuint32_t mbuf_size;\n \n-\t/* synchro for request processing */\n-\tunsigned long synchro;\n-\n \t/* buffers */\n \tvoid *pa[MBUF_BURST_SZ];\n \tvoid *va[MBUF_BURST_SZ];\ndiff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c\nindex af18c67c422f..6a206d883c0d 100644\n--- a/kernel/linux/kni/kni_misc.c\n+++ b/kernel/linux/kni/kni_misc.c\n@@ -346,7 +346,6 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,\n \tkni = netdev_priv(net_dev);\n \n \tkni->net_dev = net_dev;\n-\tkni->group_id = dev_info.group_id;\n \tkni->core_id = dev_info.core_id;\n \tstrncpy(kni->name, dev_info.name, RTE_KNI_NAMESIZE);\n \n",
    "prefixes": [
        "v2",
        "4/7"
    ]
}