Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54624/?format=api
http://patches.dpdk.org/api/patches/54624/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190610175155.21374-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190610175155.21374-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190610175155.21374-2-stephen@networkplumber.org", "date": "2019-06-10T17:51:49", "name": "[v2,1/7] kni: don't need stubs for rx_mode or ioctl", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9c9aa64c52b5d81df7e947bcc60369bead3d8682", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190610175155.21374-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 4971, "url": "http://patches.dpdk.org/api/series/4971/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4971", "date": "2019-06-10T17:51:48", "name": "kni: cleanups and improvements", "version": 2, "mbox": "http://patches.dpdk.org/series/4971/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54624/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54624/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 632951C137;\n\tMon, 10 Jun 2019 19:52:03 +0200 (CEST)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 68C201C0C5\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 19:52:00 +0200 (CEST)", "by mail-pg1-f196.google.com with SMTP id a3so5431394pgb.3\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 10:52:00 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tl38sm131656pje.12.2019.06.10.10.51.58\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 10 Jun 2019 10:51:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=;\n\tb=X1yVQGqrZQ8ggLucTFmm4o9ozoX09oUCiOVVwP9qWrKSyJulDbaeenJ3WK1d7UhYHZ\n\tBdp1WLXhnj2eK3irGeZGtXeQ9n5eLyEMMhsREl96ennHaMOFP4XXSfUmyHKYdEClSpD+\n\t6e0/Dyb1enVYpt3ktnO7olbQ/DR2yHhwEwyQ8uh+H/b5c4te2L91MWynnZUeeJBZk26q\n\tSnSLvrbugQYPpmKA0nEFg0+vvqk0l1nEVi99a7NExIWq+dkVWzxhKNSv2VhHq7UjPFts\n\tKPDx4+1IXPpJzMfM27+tgXA/VRLQDC0caSMrp1RpC5mGvRVG5YFSquTlozZBn4zuvFan\n\tehSg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=;\n\tb=rldxsX3utU7ikoOh6uZLxwUCZW3Fz1/4X9uVuuCxXZ6mErmoQqYrqfI7NrPxrXt3zB\n\t5SNm6LNf+pdbqo86waYCytNWfhz0VGAucJNbaK2BRkZNmzr6+pEH984oEh092ECjhKWE\n\tgwKPVO/aZZY27DVqJLKeX4xLej5DwKUZdqApTdRaEhDNZV6Uv3RcIrEqQ+Du0KNP3Xd8\n\tDnOgRajj6DuVJ5MfBtCfi75XdG/0rcl9BXls2c9ErJKbszGFjqioRY/AnAiSa5t/ymof\n\tzhvrgZO0xM2ANjILbGsQVwT8f/ZND+kwkzg5/F5h+4qO1xxno+qBGUgx/OVW56w3xjxp\n\tYosQ==", "X-Gm-Message-State": "APjAAAUCK6yjTRzLiZYxnEmuylRXhYpdK2tTUIK+dr+8kj09KYmf5VEG\n\tvbEcOZef3yAqs8BBTQWHrpr0Lg==", "X-Google-Smtp-Source": "APXvYqyJP6i5LxGEo4q895TB0mjMugPG01ieUJGJ+RPApich82qCl8bBZRIiotUXRWRSq/UKEWHlzQ==", "X-Received": "by 2002:a65:6210:: with SMTP id\n\td16mr15158335pgv.180.1560189119528; \n\tMon, 10 Jun 2019 10:51:59 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 10 Jun 2019 10:51:49 -0700", "Message-Id": "<20190610175155.21374-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190610175155.21374-1-stephen@networkplumber.org>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/7] kni: don't need stubs for rx_mode or ioctl", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The netdev subsystem already handles case where\nnetwork sevice does not support ioctl.\n\nIf device has no rx_mode hook it is not called.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_net.c | 19 -------------------\n 1 file changed, 19 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c\nindex ad8365877cda..c86337d099ab 100644\n--- a/kernel/linux/kni/kni_net.c\n+++ b/kernel/linux/kni/kni_net.c\n@@ -593,23 +593,6 @@ kni_net_tx_timeout(struct net_device *dev)\n \tnetif_wake_queue(dev);\n }\n \n-/*\n- * Ioctl commands\n- */\n-static int\n-kni_net_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)\n-{\n-\tpr_debug(\"kni_net_ioctl group:%d cmd:%d\\n\",\n-\t\t((struct kni_dev *)netdev_priv(dev))->group_id, cmd);\n-\n-\treturn -EOPNOTSUPP;\n-}\n-\n-static void\n-kni_net_set_rx_mode(struct net_device *dev)\n-{\n-}\n-\n static int\n kni_net_change_mtu(struct net_device *dev, int new_mtu)\n {\n@@ -758,8 +741,6 @@ static const struct net_device_ops kni_net_netdev_ops = {\n \t.ndo_change_rx_flags = kni_net_set_promiscusity,\n \t.ndo_start_xmit = kni_net_tx,\n \t.ndo_change_mtu = kni_net_change_mtu,\n-\t.ndo_do_ioctl = kni_net_ioctl,\n-\t.ndo_set_rx_mode = kni_net_set_rx_mode,\n \t.ndo_get_stats = kni_net_stats,\n \t.ndo_tx_timeout = kni_net_tx_timeout,\n \t.ndo_set_mac_address = kni_net_set_mac,\n", "prefixes": [ "v2", "1/7" ] }{ "id": 54624, "url": "