Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54611/?format=api
{ "id": 54611, "url": "http://patches.dpdk.org/api/patches/54611/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560152324-20538-29-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560152324-20538-29-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560152324-20538-29-git-send-email-arybchenko@solarflare.com", "date": "2019-06-10T07:38:43", "name": "[28/29] net/sfc/base: provide API to fetch vPort statistics", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5a3c000fff27f1609637008f7894f53e72b9f072", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560152324-20538-29-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 4965, "url": "http://patches.dpdk.org/api/series/4965/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4965", "date": "2019-06-10T07:38:19", "name": "net/sfc/base: update base driver", "version": 1, "mbox": "http://patches.dpdk.org/series/4965/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54611/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54611/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 02E4E1BF54;\n\tMon, 10 Jun 2019 09:39:45 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id EBA671BE99\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 09:38:59 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t0EDD0140058\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 07:38:59 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 10 Jun 2019 00:38:51 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 10 Jun 2019 00:38:51 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx5A7cois008875; Mon, 10 Jun 2019 08:38:50 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t662B21616E0; Mon, 10 Jun 2019 08:38:50 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Gautam Dawar <gdawar@solarflare.com>", "Date": "Mon, 10 Jun 2019 08:38:43 +0100", "Message-ID": "<1560152324-20538-29-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1560152324-20538-1-git-send-email-arybchenko@solarflare.com>", "References": "<1560152324-20538-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24664.003", "X-TM-AS-Result": "No-1.107700-4.000000-10", "X-TMASE-MatchedRID": "V+rqXAM9eR84qGaEI/i7xrsHVDDM5xAPhVDnkfzD7uYGmHr1eMxt2UAc\n\t6DyoS2rI5SReHH9+PHi8eyLTMf4qypBmKwxzr+uErSAIWhdbeu9HsHbvUttWos1d9QDiCRhgEvf\n\tXVFdC2JLCLkwqMvmCLQpTufbcmv1V++XBDev6r0wHwuCWPSIIAMMA9JsxaUa3kQ0JIWWubu/5Cy\n\ttuDAVC9WaKoqZyhP1T8UR38pnPatUnLUuBcJS+lX84FZpy/6JVmdrHMkUHHq+RoQLwUmtov6EGK\n\thm9baaNqHpTplhNloZ2bqnSDzZSMvMYwRMm1tm8CNJVimS53fP/3VD/GrQPv5soi2XrUn/Jn6Kd\n\tMrRsL14qtq5d3cxkNUEzhJpRnaVK1KXY1PNLRmTXPk0WYFl1ZOcmW/Zu6hH2U1JwDnelq3c2ttR\n\tQLnSuVgwsbBhvtMtmLM/EnChBVokXJoJX+hpNUcCGzXCiH+kqOKBkFAm8GOUPoO5ncI6OuehbQ2\n\tQpmASdWPKWiAlNtI7vdCUIFuasqw==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-1.107700-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24664.003", "X-MDID": "1560152339-ROsVD1enHsrp", "Subject": "[dpdk-dev] [PATCH 28/29] net/sfc/base: provide API to fetch vPort\n\tstatistics", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Gautam Dawar <gdawar@solarflare.com>\n\nHypervisor should be able to track VF statistics.\n\nSigned-off-by: Gautam Dawar <gdawar@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/ef10_evb.c | 13 +++++++++++++\n drivers/net/sfc/base/ef10_impl.h | 7 +++++++\n drivers/net/sfc/base/efx.h | 8 ++++++++\n drivers/net/sfc/base/efx_evb.c | 40 ++++++++++++++++++++++++++++++++++++++++\n drivers/net/sfc/base/efx_impl.h | 18 ++++++++++++++++++\n drivers/net/sfc/base/efx_mcdi.c | 30 +++++++++++++-----------------\n 6 files changed, 99 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/ef10_evb.c b/drivers/net/sfc/base/ef10_evb.c\nindex 6b6d7cc..1788a2c 100644\n--- a/drivers/net/sfc/base/ef10_evb.c\n+++ b/drivers/net/sfc/base/ef10_evb.c\n@@ -536,5 +536,18 @@\n \t\t\taddrp, fn_resetp));\n }\n \n+\t__checkReturn\tefx_rc_t\n+ef10_evb_vport_stats(\n+\t__in\t\tefx_nic_t *enp,\n+\t__in\t\tefx_vswitch_id_t vswitch_id,\n+\t__in\t\tefx_vport_id_t vport_id,\n+\t__in\t\tefsys_mem_t *esmp)\n+{\n+\t_NOTE(ARGUNUSED(vswitch_id))\n+\n+\treturn (efx_mcdi_mac_stats(enp, vport_id, esmp,\n+\t\t\tEFX_STATS_UPLOAD, 0));\n+}\n+\n #endif /* EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2 */\n #endif /* EFSYS_OPT_EVB */\ndiff --git a/drivers/net/sfc/base/ef10_impl.h b/drivers/net/sfc/base/ef10_impl.h\nindex 20f2a5c..09f97f8 100644\n--- a/drivers/net/sfc/base/ef10_impl.h\n+++ b/drivers/net/sfc/base/ef10_impl.h\n@@ -1351,6 +1351,13 @@ extern\t__checkReturn\t__success(return != B_FALSE)\tboolean_t\n \t__in_bcount_opt(EFX_MAC_ADDR_LEN)\tuint8_t *addrp,\n \t__out_opt\t\t\t\tboolean_t *fn_resetp);\n \n+extern\t__checkReturn\tefx_rc_t\n+ef10_evb_vport_stats(\n+\t__in\t\tefx_nic_t *enp,\n+\t__in\t\tefx_vswitch_id_t vswitch_id,\n+\t__in\t\tefx_vport_id_t vport_id,\n+\t__out\t\tefsys_mem_t *esmp);\n+\n #endif /* EFSYS_OPT_EVB */\n \n #if EFSYS_OPT_MCDI_PROXY_AUTH_SERVER\ndiff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h\nindex 0e6e842..a43ddd9 100644\n--- a/drivers/net/sfc/base/efx.h\n+++ b/drivers/net/sfc/base/efx.h\n@@ -3444,6 +3444,14 @@ extern\t__checkReturn\t__success(return != B_FALSE)\tboolean_t\n \t__in_bcount(EFX_MAC_ADDR_LEN)\tuint8_t *addrp,\n \t__in\t\t\t\tuint16_t vid,\n \t__out\t\t\t\tboolean_t *is_fn_resetp);\n+\n+extern\t__checkReturn\tefx_rc_t\n+efx_evb_vport_stats(\n+\t__in\t\tefx_nic_t *enp,\n+\t__in\t\tefx_vswitch_t *evp,\n+\t__in\t\tefx_vport_id_t vport_id,\n+\t__out\t\tefsys_mem_t *stats_bufferp);\n+\n #endif /* EFSYS_OPT_EVB */\n \n #if EFSYS_OPT_MCDI_PROXY_AUTH_SERVER\ndiff --git a/drivers/net/sfc/base/efx_evb.c b/drivers/net/sfc/base/efx_evb.c\nindex d48e1d7..dd64bc7 100644\n--- a/drivers/net/sfc/base/efx_evb.c\n+++ b/drivers/net/sfc/base/efx_evb.c\n@@ -24,6 +24,7 @@\n \tNULL,\t\t/* eeo_vadaptor_free */\n \tNULL,\t\t/* eeo_vport_assign */\n \tNULL,\t\t/* eeo_vport_reconfigure */\n+\tNULL,\t\t/* eeo_vport_stats */\n };\n #endif /* EFSYS_OPT_SIENA */\n \n@@ -41,6 +42,7 @@\n \tef10_evb_vadaptor_free,\t\t/* eeo_vadaptor_free */\n \tef10_evb_vport_assign,\t\t/* eeo_vport_assign */\n \tef10_evb_vport_reconfigure,\t/* eeo_vport_reconfigure */\n+\tef10_evb_vport_stats,\t\t/* eeo_vport_stats */\n };\n #endif /* EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2 */\n \n@@ -501,4 +503,42 @@\n \treturn (rc);\n }\n \n+\t__checkReturn\tefx_rc_t\n+efx_evb_vport_stats(\n+\t__in\t\tefx_nic_t *enp,\n+\t__in\t\tefx_vswitch_t *evp,\n+\t__in\t\tefx_vport_id_t vport_id,\n+\t__out\t\tefsys_mem_t *stats_bufferp)\n+{\n+\tefx_rc_t rc;\n+\tconst efx_evb_ops_t *eeop = enp->en_eeop;\n+\n+\tEFSYS_ASSERT(enp->en_mod_flags & EFX_MOD_EVB);\n+\n+\tif (eeop->eeo_vport_stats == NULL) {\n+\t\trc = ENOTSUP;\n+\t\tgoto fail1;\n+\t}\n+\n+\tif (stats_bufferp == NULL) {\n+\t\trc = EINVAL;\n+\t\tgoto fail2;\n+\t}\n+\n+\trc = eeop->eeo_vport_stats(enp, evp->ev_vswitch_id,\n+\t\tvport_id, stats_bufferp);\n+\tif (rc != 0)\n+\t\tgoto fail3;\n+\n+\treturn (0);\n+\n+fail3:\n+\tEFSYS_PROBE(fail3);\n+fail2:\n+\tEFSYS_PROBE(fail2);\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\treturn (rc);\n+}\n+\n #endif\ndiff --git a/drivers/net/sfc/base/efx_impl.h b/drivers/net/sfc/base/efx_impl.h\nindex fd31a6d..3e8b26a 100644\n--- a/drivers/net/sfc/base/efx_impl.h\n+++ b/drivers/net/sfc/base/efx_impl.h\n@@ -688,6 +688,8 @@ struct efx_vswitch_s {\n \t\t\t\t\t\t\tefx_vport_id_t,\n \t\t\t\t\t\t\tuint16_t *, uint8_t *,\n \t\t\t\t\t\t\tboolean_t *);\n+\tefx_rc_t\t(*eeo_vport_stats)(efx_nic_t *, efx_vswitch_id_t,\n+\t\t\t\t\t\tefx_vport_id_t, efsys_mem_t *);\n } efx_evb_ops_t;\n \n extern __checkReturn\tboolean_t\n@@ -1358,6 +1360,14 @@ struct efx_mac_stats_range {\n \tefx_mac_stat_t\t\tlast;\n };\n \n+typedef enum efx_stats_action_e {\n+\tEFX_STATS_CLEAR,\n+\tEFX_STATS_UPLOAD,\n+\tEFX_STATS_ENABLE_NOEVENTS,\n+\tEFX_STATS_ENABLE_EVENTS,\n+\tEFX_STATS_DISABLE,\n+} efx_stats_action_t;\n+\n extern\t\t\t\t\tefx_rc_t\n efx_mac_stats_mask_add_ranges(\n \t__inout_bcount(mask_size)\tuint32_t *maskp,\n@@ -1365,6 +1375,14 @@ struct efx_mac_stats_range {\n \t__in_ecount(rng_count)\t\tconst struct efx_mac_stats_range *rngp,\n \t__in\t\t\t\tunsigned int rng_count);\n \n+extern\t__checkReturn\tefx_rc_t\n+efx_mcdi_mac_stats(\n+\t__in\t\tefx_nic_t *enp,\n+\t__in\t\tuint32_t vport_id,\n+\t__in_opt\tefsys_mem_t *esmp,\n+\t__in\t\tefx_stats_action_t action,\n+\t__in\t\tuint16_t period_ms);\n+\n #endif\t/* EFSYS_OPT_MAC_STATS */\n \n #ifdef\t__cplusplus\ndiff --git a/drivers/net/sfc/base/efx_mcdi.c b/drivers/net/sfc/base/efx_mcdi.c\nindex e840401..477b128 100644\n--- a/drivers/net/sfc/base/efx_mcdi.c\n+++ b/drivers/net/sfc/base/efx_mcdi.c\n@@ -1834,17 +1834,10 @@\n \n #if EFSYS_OPT_MAC_STATS\n \n-typedef enum efx_stats_action_e {\n-\tEFX_STATS_CLEAR,\n-\tEFX_STATS_UPLOAD,\n-\tEFX_STATS_ENABLE_NOEVENTS,\n-\tEFX_STATS_ENABLE_EVENTS,\n-\tEFX_STATS_DISABLE,\n-} efx_stats_action_t;\n-\n-static\t__checkReturn\tefx_rc_t\n+\t__checkReturn\tefx_rc_t\n efx_mcdi_mac_stats(\n \t__in\t\tefx_nic_t *enp,\n+\t__in\t\tuint32_t vport_id,\n \t__in_opt\tefsys_mem_t *esmp,\n \t__in\t\tefx_stats_action_t action,\n \t__in\t\tuint16_t period_ms)\n@@ -1910,7 +1903,7 @@\n \t *\t vadapter has already been deleted.\n \t */\n \tMCDI_IN_SET_DWORD(req, MAC_STATS_IN_PORT_ID,\n-\t (disable ? EVB_PORT_ID_NULL : enp->en_vport_id));\n+\t\t(disable ? EVB_PORT_ID_NULL : vport_id));\n \n \tefx_mcdi_execute(enp, &req);\n \n@@ -1943,7 +1936,8 @@\n {\n \tefx_rc_t rc;\n \n-\tif ((rc = efx_mcdi_mac_stats(enp, NULL, EFX_STATS_CLEAR, 0)) != 0)\n+\tif ((rc = efx_mcdi_mac_stats(enp, enp->en_vport_id, NULL,\n+\t\t\tEFX_STATS_CLEAR, 0)) != 0)\n \t\tgoto fail1;\n \n \treturn (0);\n@@ -1966,7 +1960,8 @@\n \t * avoid having to pull the statistics buffer into the cache to\n \t * maintain cumulative statistics.\n \t */\n-\tif ((rc = efx_mcdi_mac_stats(enp, esmp, EFX_STATS_UPLOAD, 0)) != 0)\n+\tif ((rc = efx_mcdi_mac_stats(enp, enp->en_vport_id, esmp,\n+\t\t\tEFX_STATS_UPLOAD, 0)) != 0)\n \t\tgoto fail1;\n \n \treturn (0);\n@@ -1994,13 +1989,14 @@\n \t * Medford uses a fixed 1sec period before v6.2.1.1033 firmware.\n \t */\n \tif (period_ms == 0)\n-\t\trc = efx_mcdi_mac_stats(enp, NULL, EFX_STATS_DISABLE, 0);\n+\t\trc = efx_mcdi_mac_stats(enp, enp->en_vport_id, NULL,\n+\t\t\tEFX_STATS_DISABLE, 0);\n \telse if (events)\n-\t\trc = efx_mcdi_mac_stats(enp, esmp, EFX_STATS_ENABLE_EVENTS,\n-\t\t period_ms);\n+\t\trc = efx_mcdi_mac_stats(enp, enp->en_vport_id, esmp,\n+\t\t\tEFX_STATS_ENABLE_EVENTS, period_ms);\n \telse\n-\t\trc = efx_mcdi_mac_stats(enp, esmp, EFX_STATS_ENABLE_NOEVENTS,\n-\t\t period_ms);\n+\t\trc = efx_mcdi_mac_stats(enp, enp->en_vport_id, esmp,\n+\t\t\tEFX_STATS_ENABLE_NOEVENTS, period_ms);\n \n \tif (rc != 0)\n \t\tgoto fail1;\n", "prefixes": [ "28/29" ] }