Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54601/?format=api
{ "id": 54601, "url": "http://patches.dpdk.org/api/patches/54601/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560152324-20538-19-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560152324-20538-19-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560152324-20538-19-git-send-email-arybchenko@solarflare.com", "date": "2019-06-10T07:38:33", "name": "[18/29] net/sfc/base: introduce of EVB module for SR-IOV support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b8119c527d7cd013e649df911da6cb24e50ae0aa", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560152324-20538-19-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 4965, "url": "http://patches.dpdk.org/api/series/4965/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4965", "date": "2019-06-10T07:38:19", "name": "net/sfc/base: update base driver", "version": 1, "mbox": "http://patches.dpdk.org/series/4965/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54601/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54601/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1380A1BF1E;\n\tMon, 10 Jun 2019 09:39:31 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 6A77E1BE95\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 09:38:57 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t6A1CF4C0058\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 07:38:56 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 10 Jun 2019 00:38:51 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 10 Jun 2019 00:38:51 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx5A7cnTk008827; Mon, 10 Jun 2019 08:38:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tD98691616E0; Mon, 10 Jun 2019 08:38:49 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Gautam Dawar <gdawar@solarflare.com>", "Date": "Mon, 10 Jun 2019 08:38:33 +0100", "Message-ID": "<1560152324-20538-19-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1560152324-20538-1-git-send-email-arybchenko@solarflare.com>", "References": "<1560152324-20538-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24664.003", "X-TM-AS-Result": "No-3.901900-4.000000-10", "X-TMASE-MatchedRID": "NeIHNncfwiQkPTn0hc/8PachFrOB9kanELbqrOgWzyfbspKx4YOD3Rkh\n\tPVvMB7dGULqNWfM8FP/kQn4vWhwGYaKgpS1QMZdluwdUMMznEA80aXTlOdj8k99zZd3pUn7KTBJ\n\t5VCdJL8X9Ktxj1mXhOo9CL1e45ag4Ev/Xa9jWN3cHwuCWPSIIAEKJ5iyNYGPpfkiy7TTogYYVLG\n\tIPVP4OQb/YkCk00rZtveK5U82BdTZjoEmvICQo2Ct4VwAzFx+tjs/yyyVHGh4UBqkSoRN84L5BE\n\tqXwSs2UWajyFMxEGbgqLyHEiMnNTTZCT0GsTWyEQ24lJ40XAphQ2v2cnMDdZBpX1zEL4nq3Jzlo\n\tWWMvKh0P/MiosmZn5GbdLeyZyidEDr5e1hYSJgvHmyDJSEsI27u8KtEfOJPfmyiLZetSf8mfop0\n\tytGwvXiq2rl3dzGQ1R9Zhy3GxKcXKNXxDkAnnMXG+CSzGE1W/tGdcWmcQJo6WDIxzRFH+HaJK1+\n\twtELSaKdy5KiHckHroaJuZ/obnZ9GTSIcT2nFRVfZdajPCHA44oGQUCbwY5Q+g7mdwjo656FtDZ\n\tCmYBJ3KTLw/lNgw8g==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--3.901900-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24664.003", "X-MDID": "1560152337-TLwUfXRkO7Yv", "Subject": "[dpdk-dev] [PATCH 18/29] net/sfc/base: introduce of EVB module for\n\tSR-IOV support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Gautam Dawar <gdawar@solarflare.com>\n\nImplement the framework for Enterprise Virtual Briding (EVB) module.\nSR-IOV augments the software virtual switch with NIC capbilities\nsupported from EVB module.\nFurther patches will add APIs to create and destroy EVB switching\nhierarchy required for SR-IOV and APIs to set vPort properties like MAC,\nVLAN etc.\n\nSigned-off-by: Gautam Dawar <gdawar@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/Makefile | 2 +\n drivers/net/sfc/base/ef10_evb.c | 35 +++++++++++++\n drivers/net/sfc/base/ef10_impl.h | 10 ++++\n drivers/net/sfc/base/efx.h | 12 +++++\n drivers/net/sfc/base/efx_check.h | 7 +++\n drivers/net/sfc/base/efx_evb.c | 110 +++++++++++++++++++++++++++++++++++++++\n drivers/net/sfc/base/efx_impl.h | 13 +++++\n drivers/net/sfc/base/meson.build | 2 +\n drivers/net/sfc/efsys.h | 2 +\n 9 files changed, 193 insertions(+)\n create mode 100644 drivers/net/sfc/base/ef10_evb.c\n create mode 100644 drivers/net/sfc/base/efx_evb.c", "diff": "diff --git a/drivers/net/sfc/Makefile b/drivers/net/sfc/Makefile\nindex 3bb41a0..7149afd 100644\n--- a/drivers/net/sfc/Makefile\n+++ b/drivers/net/sfc/Makefile\n@@ -89,6 +89,7 @@ VPATH += $(SRCDIR)/base\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += efx_bootcfg.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += efx_crc32.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += efx_ev.c\n+SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += efx_evb.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += efx_filter.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += efx_hash.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += efx_intr.c\n@@ -114,6 +115,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += siena_phy.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += siena_sram.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += siena_vpd.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += ef10_ev.c\n+SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += ef10_evb.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += ef10_filter.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += ef10_intr.c\n SRCS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) += ef10_image.c\ndiff --git a/drivers/net/sfc/base/ef10_evb.c b/drivers/net/sfc/base/ef10_evb.c\nnew file mode 100644\nindex 0000000..03ac19a\n--- /dev/null\n+++ b/drivers/net/sfc/base/ef10_evb.c\n@@ -0,0 +1,35 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ *\n+ * Copyright (c) 2018-2019 Solarflare Communications Inc.\n+ * All rights reserved.\n+ */\n+\n+#include \"efx.h\"\n+#include \"efx_impl.h\"\n+\n+#if EFSYS_OPT_EVB\n+\n+#if EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2\n+\n+\t__checkReturn\tefx_rc_t\n+ef10_evb_init(\n+\t__in\t\tefx_nic_t *enp)\n+{\n+\tEFSYS_ASSERT(enp->en_family == EFX_FAMILY_HUNTINGTON ||\n+\t\tenp->en_family == EFX_FAMILY_MEDFORD ||\n+\t\tenp->en_family == EFX_FAMILY_MEDFORD2);\n+\n+\treturn (0);\n+}\n+\n+\tvoid\n+ef10_evb_fini(\n+\t__in\t\tefx_nic_t *enp)\n+{\n+\tEFSYS_ASSERT(enp->en_family == EFX_FAMILY_HUNTINGTON ||\n+\t\tenp->en_family == EFX_FAMILY_MEDFORD ||\n+\t\tenp->en_family == EFX_FAMILY_MEDFORD2);\n+}\n+\n+#endif /* EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2 */\n+#endif /* EFSYS_OPT_EVB */\ndiff --git a/drivers/net/sfc/base/ef10_impl.h b/drivers/net/sfc/base/ef10_impl.h\nindex 0cfbf59..26242a1 100644\n--- a/drivers/net/sfc/base/ef10_impl.h\n+++ b/drivers/net/sfc/base/ef10_impl.h\n@@ -1262,6 +1262,16 @@ extern\t__checkReturn\t__success(return != B_FALSE)\tboolean_t\n \n #endif\t/* EFSYS_OPT_FW_SUBVARIANT_AWARE */\n \n+#if EFSYS_OPT_EVB\n+extern\t__checkReturn\tefx_rc_t\n+ef10_evb_init(\n+\t__in\t\tefx_nic_t *enp);\n+\n+extern void\n+ef10_evb_fini(\n+\t__in\t\tefx_nic_t *enp);\n+\n+#endif /* EFSYS_OPT_EVB */\n \n #if EFSYS_OPT_RX_PACKED_STREAM\n \ndiff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h\nindex 40308ff..ca8a399 100644\n--- a/drivers/net/sfc/base/efx.h\n+++ b/drivers/net/sfc/base/efx.h\n@@ -3347,6 +3347,18 @@ extern\t__checkReturn\t__success(return != B_FALSE)\tboolean_t\n \t__out\t\tefx_phy_link_state_t *eplsp);\n \n \n+#if EFSYS_OPT_EVB\n+\n+extern __checkReturn efx_rc_t\n+efx_evb_init(\n+\t__in\t\tefx_nic_t *enp);\n+\n+extern\tvoid\n+efx_evb_fini(\n+\t__in\t\tefx_nic_t *enp);\n+\n+#endif /* EFSYS_OPT_EVB */\n+\n #ifdef\t__cplusplus\n }\n #endif\ndiff --git a/drivers/net/sfc/base/efx_check.h b/drivers/net/sfc/base/efx_check.h\nindex 4800f77..85edaef 100644\n--- a/drivers/net/sfc/base/efx_check.h\n+++ b/drivers/net/sfc/base/efx_check.h\n@@ -351,4 +351,11 @@\n # endif\n #endif\n \n+#if EFSYS_OPT_EVB\n+/* Support enterprise virtual bridging */\n+# if !(EFX_OPTS_EF10())\n+# error \"EVB requires EF10 arch\"\n+# endif\n+#endif /* EFSYS_OPT_EVB */\n+\n #endif /* _SYS_EFX_CHECK_H */\ndiff --git a/drivers/net/sfc/base/efx_evb.c b/drivers/net/sfc/base/efx_evb.c\nnew file mode 100644\nindex 0000000..f235252\n--- /dev/null\n+++ b/drivers/net/sfc/base/efx_evb.c\n@@ -0,0 +1,110 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ *\n+ * Copyright (c) 2018-2019 Solarflare Communications Inc.\n+ * All rights reserved.\n+ */\n+\n+#include \"efx.h\"\n+#include \"efx_impl.h\"\n+\n+\n+#if EFSYS_OPT_EVB\n+\n+#if EFSYS_OPT_SIENA\n+static const efx_evb_ops_t\t__efx_evb_dummy_ops = {\n+\tNULL,\t\t/* eeo_init */\n+\tNULL,\t\t/* eeo_fini */\n+};\n+#endif /* EFSYS_OPT_SIENA */\n+\n+#if EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2\n+static const efx_evb_ops_t\t__efx_evb_ef10_ops = {\n+\tef10_evb_init,\t\t/* eeo_init */\n+\tef10_evb_fini,\t\t/* eeo_fini */\n+};\n+#endif /* EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2 */\n+\n+\t__checkReturn\tefx_rc_t\n+efx_evb_init(\n+\t__in\t\tefx_nic_t *enp)\n+{\n+\tconst efx_evb_ops_t *eeop;\n+\tefx_rc_t rc;\n+\tefx_nic_cfg_t *encp = &(enp->en_nic_cfg);\n+\n+\tEFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);\n+\tEFSYS_ASSERT3U(enp->en_mod_flags, &, EFX_MOD_PROBE);\n+\tEFSYS_ASSERT(!(enp->en_mod_flags & EFX_MOD_EVB));\n+\n+\tswitch (enp->en_family) {\n+#if EFSYS_OPT_SIENA\n+\tcase EFX_FAMILY_SIENA:\n+\t\teeop = &__efx_evb_dummy_ops;\n+\t\tbreak;\n+#endif /* EFSYS_OPT_SIENA */\n+\n+#if EFSYS_OPT_HUNTINGTON\n+\tcase EFX_FAMILY_HUNTINGTON:\n+\t\teeop = &__efx_evb_ef10_ops;\n+\t\tbreak;\n+#endif /* EFSYS_OPT_HUNTINGTON */\n+\n+#if EFSYS_OPT_MEDFORD\n+\tcase EFX_FAMILY_MEDFORD:\n+\t\teeop = &__efx_evb_ef10_ops;\n+\t\tbreak;\n+#endif /* EFSYS_OPT_MEDFORD */\n+\n+#if EFSYS_OPT_MEDFORD2\n+\tcase EFX_FAMILY_MEDFORD2:\n+\t\teeop = &__efx_evb_ef10_ops;\n+\t\tbreak;\n+#endif /* EFSYS_OPT_MEDFORD2 */\n+\n+\tdefault:\n+\t\tEFSYS_ASSERT(0);\n+\t\trc = ENOTSUP;\n+\t\tgoto fail1;\n+\t}\n+\n+\tif (!encp->enc_datapath_cap_evb || !eeop->eeo_init) {\n+\t\trc = ENOTSUP;\n+\t\tgoto fail2;\n+\t}\n+\n+\tif ((rc = eeop->eeo_init(enp)) != 0)\n+\t\tgoto fail3;\n+\n+\tenp->en_eeop = eeop;\n+\tenp->en_mod_flags |= EFX_MOD_EVB;\n+\treturn (0);\n+\n+fail3:\n+\tEFSYS_PROBE(fail3);\n+fail2:\n+\tEFSYS_PROBE(fail2);\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\n+\treturn (rc);\n+}\n+\n+\t\t\tvoid\n+efx_evb_fini(\n+\t__in\t\tefx_nic_t *enp)\n+{\n+\tconst efx_evb_ops_t *eeop = enp->en_eeop;\n+\n+\tEFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);\n+\tEFSYS_ASSERT(enp->en_mod_flags & EFX_MOD_PROBE);\n+\tEFSYS_ASSERT(!(enp->en_mod_flags & EFX_MOD_RX));\n+\tEFSYS_ASSERT(!(enp->en_mod_flags & EFX_MOD_TX));\n+\n+\tif (eeop && eeop->eeo_fini)\n+\t\teeop->eeo_fini(enp);\n+\n+\tenp->en_eeop = NULL;\n+\tenp->en_mod_flags &= ~EFX_MOD_EVB;\n+}\n+\n+#endif\ndiff --git a/drivers/net/sfc/base/efx_impl.h b/drivers/net/sfc/base/efx_impl.h\nindex 067cec3..00f88c8 100644\n--- a/drivers/net/sfc/base/efx_impl.h\n+++ b/drivers/net/sfc/base/efx_impl.h\n@@ -58,6 +58,7 @@\n #define\tEFX_MOD_FILTER\t\t0x00001000\n #define\tEFX_MOD_LIC\t\t0x00002000\n #define\tEFX_MOD_TUNNEL\t\t0x00004000\n+#define\tEFX_MOD_EVB\t\t0x00008000\n \n #define\tEFX_RESET_PHY\t\t0x00000001\n #define\tEFX_RESET_RXQ_ERR\t0x00000002\n@@ -649,6 +650,15 @@\n \n #endif\n \n+#if EFSYS_OPT_EVB\n+\n+typedef struct efx_evb_ops_s {\n+\tefx_rc_t\t(*eeo_init)(efx_nic_t *);\n+\tvoid\t\t(*eeo_fini)(efx_nic_t *);\n+} efx_evb_ops_t;\n+\n+#endif /* EFSYS_OPT_EVB */\n+\n #define\tEFX_DRV_VER_MAX\t\t20\n \n typedef struct efx_drv_cfg_s {\n@@ -747,6 +757,9 @@ struct efx_nic_s {\n \t\t} ef10;\n \t} en_arch;\n #endif\t/* EFX_OPTS_EF10() */\n+#if EFSYS_OPT_EVB\n+\tconst efx_evb_ops_t\t*en_eeop;\n+#endif\t/* EFSYS_OPT_EVB */\n };\n \n #define\tEFX_FAMILY_IS_EF10(_enp) \\\ndiff --git a/drivers/net/sfc/base/meson.build b/drivers/net/sfc/base/meson.build\nindex ab66f32..6fa7948 100644\n--- a/drivers/net/sfc/base/meson.build\n+++ b/drivers/net/sfc/base/meson.build\n@@ -8,6 +8,7 @@ sources = [\n \t'efx_bootcfg.c',\n \t'efx_crc32.c',\n \t'efx_ev.c',\n+\t'efx_evb.c',\n \t'efx_filter.c',\n \t'efx_hash.c',\n \t'efx_intr.c',\n@@ -33,6 +34,7 @@ sources = [\n \t'siena_sram.c',\n \t'siena_vpd.c',\n \t'ef10_ev.c',\n+\t'ef10_evb.c',\n \t'ef10_filter.c',\n \t'ef10_image.c',\n \t'ef10_intr.c',\ndiff --git a/drivers/net/sfc/efsys.h b/drivers/net/sfc/efsys.h\nindex f7bcc74..24f3769 100644\n--- a/drivers/net/sfc/efsys.h\n+++ b/drivers/net/sfc/efsys.h\n@@ -166,6 +166,8 @@\n \n #define EFSYS_OPT_FW_SUBVARIANT_AWARE 1\n \n+#define EFSYS_OPT_EVB 0\n+\n /* ID */\n \n typedef struct __efsys_identifier_s efsys_identifier_t;\n", "prefixes": [ "18/29" ] }