Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54599/?format=api
{ "id": 54599, "url": "http://patches.dpdk.org/api/patches/54599/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560152324-20538-7-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560152324-20538-7-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560152324-20538-7-git-send-email-arybchenko@solarflare.com", "date": "2019-06-10T07:38:21", "name": "[06/29] net/sfc/base: add driver version string registration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ffb5a3fb1cbf6686d773f03fcb8989f0248515c5", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560152324-20538-7-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 4965, "url": "http://patches.dpdk.org/api/series/4965/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4965", "date": "2019-06-10T07:38:19", "name": "net/sfc/base: update base driver", "version": 1, "mbox": "http://patches.dpdk.org/series/4965/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54599/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54599/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3235C1BF10;\n\tMon, 10 Jun 2019 09:39:28 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 1C6061BE8C\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 09:38:57 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t105A34C0058\n\tfor <dev@dpdk.org>; Mon, 10 Jun 2019 07:38:56 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 10 Jun 2019 00:38:51 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 10 Jun 2019 00:38:50 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx5A7cnsi008765; Mon, 10 Jun 2019 08:38:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t3A33A1616E0; Mon, 10 Jun 2019 08:38:49 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Richard Houldsworth <rhouldsworth@solarflare.com>", "Date": "Mon, 10 Jun 2019 08:38:21 +0100", "Message-ID": "<1560152324-20538-7-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1560152324-20538-1-git-send-email-arybchenko@solarflare.com>", "References": "<1560152324-20538-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24664.003", "X-TM-AS-Result": "No-2.610600-4.000000-10", "X-TMASE-MatchedRID": "TyJyy/oMpQY95I+PNw73oIicBKfMHlV8H7bpDOhZpjYhNSb1tn2Gvfea\n\t4uH4Y9hv+p8140VCnvHE3UW02mrQtaH2g9syPs88bBMSu4v05tM/pOSL72dTfwdkFovAReUoilv\n\tAb18i4hM8V70TYPgfxiqfhU+Vgjd809VVSm4W+C8HK0IhbYfex/ngX/aL8PCNaygfAod0Ojdwyo\n\tPEq/oAMEHT3qzCnBv3NmSkHdNY7lldwbDa/5b0bUf49ONH0RaS2u3GDhv7Cuw2G16CVR8fu4mbJ\n\tYGMyzGQEp5yzuj0j3/MDeiFaS4qhRlEafM3i1svsJribvbshQ99LQinZ4QefPcjNeVeWlqY+gtH\n\tj7OwNO0JC+VZi2gQESVTukd/Nz6tlZQMS5ee1dIyGoo2iquvYxYD9W5apUeJTvdgl6Aj793WY2d\n\tK21ee/yPNcyfqvQ0jPggM+wzr8kYscaAa8IvUSNpAu0sLxpSoQ8G+yYJYYdZRZDsGiXQioBjm28\n\tf1HLY3", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--2.610600-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24664.003", "X-MDID": "1560152336-er2aRPjK9d4E", "Subject": "[dpdk-dev] [PATCH 06/29] net/sfc/base: add driver version string\n\tregistration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Richard Houldsworth <rhouldsworth@solarflare.com>\n\nSupport the registration of a version string by the libefx\nclient. The string is passed on to the MC in efx_nic_probe\nonly to allow the MC to advertise the OS driver version in\nNC-SI, and the content is considered opaque for libefx.\n\nSigned-off-by: Richard Houldsworth <rhouldsworth@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/efx.h | 13 +++++++++++++\n drivers/net/sfc/base/efx_impl.h | 3 +++\n drivers/net/sfc/base/efx_mcdi.c | 16 ++++++++++++++--\n drivers/net/sfc/base/efx_nic.c | 35 +++++++++++++++++++++++++++++++++++\n 4 files changed, 65 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h\nindex 8a2bb39..700c998 100644\n--- a/drivers/net/sfc/base/efx.h\n+++ b/drivers/net/sfc/base/efx.h\n@@ -1463,6 +1463,19 @@ enum {\n \t__inout\t\tefx_nic_t *enp,\n \t__in\t\tefx_drv_limits_t *edlp);\n \n+/*\n+ * Register the OS driver version string for management agents\n+ * (e.g. via NC-SI). The content length is provided (i.e. no\n+ * NUL terminator). Use length 0 to indicate no version string\n+ * should be advertised. It is valid to set the version string\n+ * only before efx_nic_probe() is called.\n+ */\n+extern\t__checkReturn\tefx_rc_t\n+efx_nic_set_drv_version(\n+\t__inout\t\t\tefx_nic_t *enp,\n+\t__in_ecount(length)\tchar const *verp,\n+\t__in\t\t\tsize_t length);\n+\n typedef enum efx_nic_region_e {\n \tEFX_REGION_VI,\t\t\t/* Memory BAR UC mapping */\n \tEFX_REGION_PIO_WRITE_VI,\t/* Memory BAR WC mapping */\ndiff --git a/drivers/net/sfc/base/efx_impl.h b/drivers/net/sfc/base/efx_impl.h\nindex f148c87..b5ac84d 100644\n--- a/drivers/net/sfc/base/efx_impl.h\n+++ b/drivers/net/sfc/base/efx_impl.h\n@@ -647,6 +647,8 @@\n \n #endif\n \n+#define\tEFX_DRV_VER_MAX\t\t20\n+\n typedef struct efx_drv_cfg_s {\n \tuint32_t\t\tedc_min_vi_count;\n \tuint32_t\t\tedc_max_vi_count;\n@@ -677,6 +679,7 @@ struct efx_nic_s {\n \tconst efx_tx_ops_t\t*en_etxop;\n \tconst efx_rx_ops_t\t*en_erxop;\n \tefx_fw_variant_t\tefv;\n+\tchar\t\t\ten_drv_version[EFX_DRV_VER_MAX];\n #if EFSYS_OPT_FILTER\n \tefx_filter_t\t\ten_filter;\n \tconst efx_filter_ops_t\t*en_efop;\ndiff --git a/drivers/net/sfc/base/efx_mcdi.c b/drivers/net/sfc/base/efx_mcdi.c\nindex adc2eb8..584fd4d 100644\n--- a/drivers/net/sfc/base/efx_mcdi.c\n+++ b/drivers/net/sfc/base/efx_mcdi.c\n@@ -1256,13 +1256,17 @@\n \t__in\t\tboolean_t attach)\n {\n \tefx_mcdi_req_t req;\n-\tEFX_MCDI_DECLARE_BUF(payload, MC_CMD_DRV_ATTACH_IN_LEN,\n+\tEFX_MCDI_DECLARE_BUF(payload, MC_CMD_DRV_ATTACH_IN_V2_LEN,\n \t\tMC_CMD_DRV_ATTACH_EXT_OUT_LEN);\n \tefx_rc_t rc;\n \n \treq.emr_cmd = MC_CMD_DRV_ATTACH;\n \treq.emr_in_buf = payload;\n-\treq.emr_in_length = MC_CMD_DRV_ATTACH_IN_LEN;\n+\tif (enp->en_drv_version[0] == '\\0') {\n+\t\treq.emr_in_length = MC_CMD_DRV_ATTACH_IN_LEN;\n+\t} else {\n+\t\treq.emr_in_length = MC_CMD_DRV_ATTACH_IN_V2_LEN;\n+\t}\n \treq.emr_out_buf = payload;\n \treq.emr_out_length = MC_CMD_DRV_ATTACH_EXT_OUT_LEN;\n \n@@ -1283,6 +1287,14 @@\n \tMCDI_IN_SET_DWORD(req, DRV_ATTACH_IN_UPDATE, 1);\n \tMCDI_IN_SET_DWORD(req, DRV_ATTACH_IN_FIRMWARE_ID, enp->efv);\n \n+\tif (req.emr_in_length >= MC_CMD_DRV_ATTACH_IN_V2_LEN) {\n+\t\tEFX_STATIC_ASSERT(sizeof (enp->en_drv_version) ==\n+\t\t MC_CMD_DRV_ATTACH_IN_V2_DRIVER_VERSION_LEN);\n+\t\tmemcpy(MCDI_IN2(req, char, DRV_ATTACH_IN_V2_DRIVER_VERSION),\n+\t\t enp->en_drv_version,\n+\t\t MC_CMD_DRV_ATTACH_IN_V2_DRIVER_VERSION_LEN);\n+\t}\n+\n \tefx_mcdi_execute(enp, &req);\n \n \tif (req.emr_rc != 0) {\ndiff --git a/drivers/net/sfc/base/efx_nic.c b/drivers/net/sfc/base/efx_nic.c\nindex 3ec5cbc..c1285bf 100644\n--- a/drivers/net/sfc/base/efx_nic.c\n+++ b/drivers/net/sfc/base/efx_nic.c\n@@ -380,6 +380,41 @@\n }\n \n \t__checkReturn\tefx_rc_t\n+efx_nic_set_drv_version(\n+\t__inout\t\t\tefx_nic_t *enp,\n+\t__in_ecount(length)\tchar const *verp,\n+\t__in\t\t\tsize_t length)\n+{\n+\tefx_rc_t rc;\n+\n+\tEFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);\n+\tEFSYS_ASSERT(!(enp->en_mod_flags & EFX_MOD_PROBE));\n+\n+\t/*\n+\t * length is the string content length in bytes.\n+\t * Accept any content which fits into the version\n+\t * buffer, excluding the last byte. This is reserved\n+\t * for an appended NUL terminator.\n+\t */\n+\tif (length >= sizeof (enp->en_drv_version)) {\n+\t\trc = E2BIG;\n+\t\tgoto fail1;\n+\t}\n+\n+\t(void) memset(enp->en_drv_version, 0,\n+\t sizeof (enp->en_drv_version));\n+\tmemcpy(enp->en_drv_version, verp, length);\n+\n+\treturn (0);\n+\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\n+\treturn (rc);\n+}\n+\n+\n+\t__checkReturn\tefx_rc_t\n efx_nic_get_bar_region(\n \t__in\t\tefx_nic_t *enp,\n \t__in\t\tefx_nic_region_t region,\n", "prefixes": [ "06/29" ] }