Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54597/?format=api
{ "id": 54597, "url": "http://patches.dpdk.org/api/patches/54597/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560152324-20538-4-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560152324-20538-4-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560152324-20538-4-git-send-email-arybchenko@solarflare.com", "date": "2019-06-10T07:38:18", "name": "[03/29] net/sfc/base: fix shift by more bits than field width", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "502db934746a0236a5afa3ab964e7d500963b7e2", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560152324-20538-4-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 4965, "url": "http://patches.dpdk.org/api/series/4965/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4965", "date": "2019-06-10T07:38:19", "name": "net/sfc/base: update base driver", "version": 1, "mbox": "http://patches.dpdk.org/series/4965/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54597/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54597/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 276C61BEF8;\n\tMon, 10 Jun 2019 09:39:25 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id A97621BE95;\n\tMon, 10 Jun 2019 09:38:56 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\tAA6314C0058; Mon, 10 Jun 2019 07:38:55 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 10 Jun 2019 00:38:51 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 10 Jun 2019 00:38:50 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx5A7cnac008755; Mon, 10 Jun 2019 08:38:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t129951627D7; Mon, 10 Jun 2019 08:38:49 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Mark Spender <mspender@solarflare.com>, <stable@dpdk.org>", "Date": "Mon, 10 Jun 2019 08:38:18 +0100", "Message-ID": "<1560152324-20538-4-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1560152324-20538-1-git-send-email-arybchenko@solarflare.com>", "References": "<1560152324-20538-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24664.003", "X-TM-AS-Result": "No-8.458400-4.000000-10", "X-TMASE-MatchedRID": "0wm7BrAfHYcWUcwJqSCXnbHcAAwD045wBnIRIVcCWN/FVLYz0PH8dfPD\n\t3CqjqQZmp/dg3Z2NMCXusCHjf/LEbTiz+dBnC9kIGi6hW8XaLRnpVMb1xnESMo5JUK9UdYknE3Y\n\tJuuPqeQPWE964R7d6ncXz2YqqvrnJ6/Dbt0BmXRM/ApMPW/xhXkyQ5fRSh265gstfdkcDXJrcyO\n\trXENN0xN1TeFi3Fi9wgDLqnrRlXrZ8nn9tnqel2DsAVzN+Ov/sJKTZYb82Bc6PcQVJWYh5GH0MJ\n\tAS1KW5I+khGID9rYSJbDy0IUDs74Q==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--8.458400-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24664.003", "X-MDID": "1560152336-w9PBs6lI01Sg", "Subject": "[dpdk-dev] [PATCH 03/29] net/sfc/base: fix shift by more bits than\n\tfield width", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Mark Spender <mspender@solarflare.com>\n\nThis was probably an oversight when support for multiple sensor pages\nwas added.\n\nDespite being undefined behaviour in C, it probably worked on Intel\nx32/x64 as on them bit shift operations wrap round.\n\nFixes: dfb3b1ce15f6 (\"net/sfc/base: import monitors access via MCDI\")\nCc: stable@dpdk.org\n\nSigned-off-by: Mark Spender <mspender@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/mcdi_mon.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/sfc/base/mcdi_mon.c b/drivers/net/sfc/base/mcdi_mon.c\nindex b53de0d..d0247dc 100644\n--- a/drivers/net/sfc/base/mcdi_mon.c\n+++ b/drivers/net/sfc/base/mcdi_mon.c\n@@ -73,7 +73,8 @@\n \t\t\t/* This sensor is one of the page boundary bits. */\n \t\t}\n \n-\t\tif (~(sensor_mask[page]) & (1U << sensor))\n+\t\tif (~(sensor_mask[page]) &\n+\t\t (1U << (sensor % (sizeof (sensor_mask[page]) * 8))))\n \t\t\tcontinue;\n \t\t/* This sensor not in DMA buffer */\n \n", "prefixes": [ "03/29" ] }