Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54586/?format=api
{ "id": 54586, "url": "http://patches.dpdk.org/api/patches/54586/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560152324-20538-2-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560152324-20538-2-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560152324-20538-2-git-send-email-arybchenko@solarflare.com", "date": "2019-06-10T07:38:16", "name": "[01/29] net/sfc/base: enable chained multicast on all EF10 cards", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "724431734e4567e89ce34409eacaa9057c5b9af1", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560152324-20538-2-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 4965, "url": "http://patches.dpdk.org/api/series/4965/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4965", "date": "2019-06-10T07:38:19", "name": "net/sfc/base: update base driver", "version": 1, "mbox": "http://patches.dpdk.org/series/4965/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54586/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54586/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0712D1BE9D;\n\tMon, 10 Jun 2019 09:39:01 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B4DD31BE8D;\n\tMon, 10 Jun 2019 09:38:54 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t6675A4C0058; Mon, 10 Jun 2019 07:38:53 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 10 Jun 2019 00:38:50 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 10 Jun 2019 00:38:50 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx5A7cn7J008748; Mon, 10 Jun 2019 08:38:49 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tEB4371627D7; Mon, 10 Jun 2019 08:38:48 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Gautam Dawar <gdawar@solarflare.com>, <stable@dpdk.org>", "Date": "Mon, 10 Jun 2019 08:38:16 +0100", "Message-ID": "<1560152324-20538-2-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1560152324-20538-1-git-send-email-arybchenko@solarflare.com>", "References": "<1560152324-20538-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24664.003", "X-TM-AS-Result": "No-6.664900-4.000000-10", "X-TMASE-MatchedRID": "UXw5aWkoEBBMFmmQO5uUdyt4VwAzFx+tab+ZPXqZNQIda1Vk3RqxOCYO\n\tncYSCKTmWAWfk7KIjj6mcFuKGELrlsHVNeDWrWSGIf0TE1VduNs1X1Ls767cpjhYqvU+Y921035\n\tU7xRHgyF8bO6hWfRWzo9CL1e45ag4cj8zE1EjtSTylEfNwb6iLTCNjbQPaq5iSStniYWNNsO4nr\n\tgIM5K3vUIr/OXnA2DuIGb1oXBeUfnnyYsUXqFB8EhwlOfYeSqx3WFaxVW7M2h9eguxhXL5Mhfo+\n\toVE2PIvz5kk6Pe3URCP9aElA3hZZ/P/vTMFLhaLyPPRU9ScEDVHcT14gBzqVg6QlBHhBZuwqjeW\n\tvT1XuRI9KA5aNAcAD7j93RHB7VomKBrAiA/1x+VKzOvae5Q0rCGFfv5D4lhCLntkh15frcSjxYy\n\tRBa/qJcFwgTvxipFajoczmuoPCq2dcWivkVkBE1pNBVBSJ2AObUTTr39Yqn+ilFTQ1+qO++JXfD\n\tNzeiDYQwymtxuJ6y0=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--6.664900-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24664.003", "X-MDID": "1560152334-UBM2gUdo9_zN", "Subject": "[dpdk-dev] [PATCH 01/29] net/sfc/base: enable chained multicast on\n\tall EF10 cards", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Gautam Dawar <gdawar@solarflare.com>\n\nSet WORKAROUND_BUG26807 which does the job.\n\nFix the misunderstanding in the Medford code: i.e. the workaround is\nalways supported by firmware, but the driver still needs to enable it.\nAlso, as it now applies to all EF10 controllers, the implementation is\nmoved to EF10 common place.\n\nFixes: 94190e3543bf (\"net/sfc/base: import SFN8xxx family support\")\nFixes: 2b38e7b7b7e1 (\"net/sfc/base: add Medford2 support to NIC module\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gautam Dawar <gdawar@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/ef10_nic.c | 57 ++++++++++++++++++++++++++++++++++++-\n drivers/net/sfc/base/hunt_nic.c | 41 ++------------------------\n drivers/net/sfc/base/medford2_nic.c | 3 --\n drivers/net/sfc/base/medford_nic.c | 3 --\n 4 files changed, 58 insertions(+), 46 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/ef10_nic.c b/drivers/net/sfc/base/ef10_nic.c\nindex e5e8469..1d7e6d8 100644\n--- a/drivers/net/sfc/base/ef10_nic.c\n+++ b/drivers/net/sfc/base/ef10_nic.c\n@@ -1753,6 +1753,56 @@\n }\n \n static\t__checkReturn\tefx_rc_t\n+ef10_set_workaround_bug26807(\n+\t__in\t\tefx_nic_t *enp)\n+{\n+\tefx_nic_cfg_t *encp = &(enp->en_nic_cfg);\n+\tuint32_t flags;\n+\tefx_rc_t rc;\n+\n+\t/*\n+\t * If the bug26807 workaround is enabled, then firmware has enabled\n+\t * support for chained multicast filters. Firmware will reset (FLR)\n+\t * functions which have filters in the hardware filter table when the\n+\t * workaround is enabled/disabled.\n+\t *\n+\t * We must recheck if the workaround is enabled after inserting the\n+\t * first hardware filter, in case it has been changed since this check.\n+\t */\n+\trc = efx_mcdi_set_workaround(enp, MC_CMD_WORKAROUND_BUG26807,\n+\t B_TRUE, &flags);\n+\tif (rc == 0) {\n+\t\tencp->enc_bug26807_workaround = B_TRUE;\n+\t\tif (flags & (1 << MC_CMD_WORKAROUND_EXT_OUT_FLR_DONE_LBN)) {\n+\t\t\t/*\n+\t\t\t * Other functions had installed filters before the\n+\t\t\t * workaround was enabled, and they have been reset\n+\t\t\t * by firmware.\n+\t\t\t */\n+\t\t\tEFSYS_PROBE(bug26807_workaround_flr_done);\n+\t\t\t/* FIXME: bump MC warm boot count ? */\n+\t\t}\n+\t} else if (rc == EACCES) {\n+\t\t/*\n+\t\t * Unprivileged functions cannot enable the workaround in older\n+\t\t * firmware.\n+\t\t */\n+\t\tencp->enc_bug26807_workaround = B_FALSE;\n+\t} else if ((rc == ENOTSUP) || (rc == ENOENT)) {\n+\t\tencp->enc_bug26807_workaround = B_FALSE;\n+\t} else {\n+\t\tgoto fail1;\n+\t}\n+\n+\treturn (0);\n+\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\n+\treturn (rc);\n+}\n+\n+static\t__checkReturn\tefx_rc_t\n ef10_nic_board_cfg(\n \t__in\t\tefx_nic_t *enp)\n {\n@@ -1910,13 +1960,18 @@\n \t\tgoto fail10;\n \tencp->enc_privilege_mask = mask;\n \n+\tif ((rc = ef10_set_workaround_bug26807(enp)) != 0)\n+\t\tgoto fail11;\n+\n \t/* Get remaining controller-specific board config */\n \tif ((rc = enop->eno_board_cfg(enp)) != 0)\n \t\tif (rc != EACCES)\n-\t\t\tgoto fail11;\n+\t\t\tgoto fail12;\n \n \treturn (0);\n \n+fail12:\n+\tEFSYS_PROBE(fail12);\n fail11:\n \tEFSYS_PROBE(fail11);\n fail10:\ndiff --git a/drivers/net/sfc/base/hunt_nic.c b/drivers/net/sfc/base/hunt_nic.c\nindex 054d4f4..1e2b075 100644\n--- a/drivers/net/sfc/base/hunt_nic.c\n+++ b/drivers/net/sfc/base/hunt_nic.c\n@@ -72,7 +72,6 @@\n {\n \tefx_nic_cfg_t *encp = &(enp->en_nic_cfg);\n \tefx_port_t *epp = &(enp->en_port);\n-\tuint32_t flags;\n \tuint32_t sysclk, dpcpu_clk;\n \tuint32_t bandwidth;\n \tefx_rc_t rc;\n@@ -130,43 +129,9 @@\n \t\tencp->enc_bug41750_workaround = B_TRUE;\n \t}\n \n-\t/*\n-\t * If the bug26807 workaround is enabled, then firmware has enabled\n-\t * support for chained multicast filters. Firmware will reset (FLR)\n-\t * functions which have filters in the hardware filter table when the\n-\t * workaround is enabled/disabled.\n-\t *\n-\t * We must recheck if the workaround is enabled after inserting the\n-\t * first hardware filter, in case it has been changed since this check.\n-\t */\n-\trc = efx_mcdi_set_workaround(enp, MC_CMD_WORKAROUND_BUG26807,\n-\t B_TRUE, &flags);\n-\tif (rc == 0) {\n-\t\tencp->enc_bug26807_workaround = B_TRUE;\n-\t\tif (flags & (1 << MC_CMD_WORKAROUND_EXT_OUT_FLR_DONE_LBN)) {\n-\t\t\t/*\n-\t\t\t * Other functions had installed filters before the\n-\t\t\t * workaround was enabled, and they have been reset\n-\t\t\t * by firmware.\n-\t\t\t */\n-\t\t\tEFSYS_PROBE(bug26807_workaround_flr_done);\n-\t\t\t/* FIXME: bump MC warm boot count ? */\n-\t\t}\n-\t} else if (rc == EACCES) {\n-\t\t/*\n-\t\t * Unprivileged functions cannot enable the workaround in older\n-\t\t * firmware.\n-\t\t */\n-\t\tencp->enc_bug26807_workaround = B_FALSE;\n-\t} else if ((rc == ENOTSUP) || (rc == ENOENT)) {\n-\t\tencp->enc_bug26807_workaround = B_FALSE;\n-\t} else {\n-\t\tgoto fail3;\n-\t}\n-\n \t/* Get clock frequencies (in MHz). */\n \tif ((rc = efx_mcdi_get_clock(enp, &sysclk, &dpcpu_clk)) != 0)\n-\t\tgoto fail4;\n+\t\tgoto fail3;\n \n \t/*\n \t * The Huntington timer quantum is 1536 sysclk cycles, documented for\n@@ -215,7 +180,7 @@\n \tencp->enc_piobuf_min_alloc_size = HUNT_MIN_PIO_ALLOC_SIZE;\n \n \tif ((rc = hunt_nic_get_required_pcie_bandwidth(enp, &bandwidth)) != 0)\n-\t\tgoto fail5;\n+\t\tgoto fail4;\n \tencp->enc_required_pcie_bandwidth_mbps = bandwidth;\n \n \t/* All Huntington devices have a PCIe Gen3, 8 lane connector */\n@@ -223,8 +188,6 @@\n \n \treturn (0);\n \n-fail5:\n-\tEFSYS_PROBE(fail5);\n fail4:\n \tEFSYS_PROBE(fail4);\n fail3:\ndiff --git a/drivers/net/sfc/base/medford2_nic.c b/drivers/net/sfc/base/medford2_nic.c\nindex 16621d1..c0d4c13 100644\n--- a/drivers/net/sfc/base/medford2_nic.c\n+++ b/drivers/net/sfc/base/medford2_nic.c\n@@ -69,9 +69,6 @@\n \t\tencp->enc_bug41750_workaround = B_TRUE;\n \t}\n \n-\t/* Chained multicast is always enabled on Medford2 */\n-\tencp->enc_bug26807_workaround = B_TRUE;\n-\n \t/*\n \t * If the bug61265 workaround is enabled, then interrupt holdoff timers\n \t * cannot be controlled by timer table writes, so MCDI must be used\ndiff --git a/drivers/net/sfc/base/medford_nic.c b/drivers/net/sfc/base/medford_nic.c\nindex 01a3462..c2a0054 100644\n--- a/drivers/net/sfc/base/medford_nic.c\n+++ b/drivers/net/sfc/base/medford_nic.c\n@@ -67,9 +67,6 @@\n \t\tencp->enc_bug41750_workaround = B_TRUE;\n \t}\n \n-\t/* Chained multicast is always enabled on Medford */\n-\tencp->enc_bug26807_workaround = B_TRUE;\n-\n \t/*\n \t * If the bug61265 workaround is enabled, then interrupt holdoff timers\n \t * cannot be controlled by timer table writes, so MCDI must be used\n", "prefixes": [ "01/29" ] }