Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54559/?format=api
{ "id": 54559, "url": "http://patches.dpdk.org/api/patches/54559/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190608002003.19942-8-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190608002003.19942-8-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190608002003.19942-8-stephen@networkplumber.org", "date": "2019-06-08T00:20:01", "name": "[7/9] kni: use proper type for kni fifo's", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ea3b0b24974d20d15fdf8bcacf32c23a1df694bb", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190608002003.19942-8-stephen@networkplumber.org/mbox/", "series": [ { "id": 4956, "url": "http://patches.dpdk.org/api/series/4956/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4956", "date": "2019-06-08T00:19:54", "name": "kni: cleanups and improvements", "version": 1, "mbox": "http://patches.dpdk.org/series/4956/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54559/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54559/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 253851BCC8;\n\tSat, 8 Jun 2019 02:20:29 +0200 (CEST)", "from mail-pl1-f196.google.com (mail-pl1-f196.google.com\n\t[209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 602A81BC9C\n\tfor <dev@dpdk.org>; Sat, 8 Jun 2019 02:20:19 +0200 (CEST)", "by mail-pl1-f196.google.com with SMTP id cl9so1398176plb.10\n\tfor <dev@dpdk.org>; Fri, 07 Jun 2019 17:20:19 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tn184sm4012463pfn.21.2019.06.07.17.20.17\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tFri, 07 Jun 2019 17:20:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=;\n\tb=xV1aLb9eawlaYSRvSpjMH6mG1a3h7Qn+XApJUUObSW4xznEeUq5QjlZlHJEtWn9tWO\n\tJz8SppAR2CVMGNIwGi9F0/dlx8Bm5eTAJK9Q1T9XGO7V8EdBCggXTjYFNp7+NzyREPKi\n\tmF92ebKYLad5hGwFbbMxlDgBxuSnMmObtPknAXoQdVX8Z7vXiMOabLQBd8y+OcGPN0GQ\n\txXj4W2ZBpGeITwGP65ztssJSpcTePpv27AtLJlBjkmE/Cp+F0VZuiDw1G0xMBBK2DScT\n\tWlDg35PDwEPGr2hfCswGfYEJ03M3ogttLzbEcauo2ESmURx8q4/qAu22AyLVtgj1adWI\n\tXZWQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=;\n\tb=ImaPXy7Yc4nxxZvLyQGkUzDuxqdtGcmKEOU2BuekWniGKg0zh3gaqXBiRu96m1zk5w\n\t01wFqIockGhL8ALlaD9mSdnJ/8GSwzoo+lv+dvl3ktFySNvFxJAehOkXiS/2PjlYZS0P\n\tyu/lRBSlU0ZfrsBv8n9IuFcr+dNYN6xCOQkOTMk0U9EujI4/6NE5fpntaAaN/OuXsdtA\n\tk8rDi6r9vTLyqwqmBAOgwUDSXHdtz5nzhpPQukRNqpEtaXXsX8ZTWlWsh+i+rlSoDiau\n\t6p7s7m5ZJHJJNQ5qj1xcm0dDP5Dqwcs2vLruTlKyFthtsj0I2Lsn9MSJnN5+xmMHK3ZB\n\tUFbQ==", "X-Gm-Message-State": "APjAAAUSP3Oewhc1wcIWGWarqtBBqYq8oYzD3L45LWdEYUvlqFfT4QS2\n\tmFaB1aC47OOhZEHPhjGmoh4I2g==", "X-Google-Smtp-Source": "APXvYqz1PguDsfBzC6MVfbqGdZUZ/+/r2ZIjG75dEe05oVz0iM5gFBD4t5JBiVIEQoCaJ1WuMz3Xeg==", "X-Received": "by 2002:a17:902:e30e:: with SMTP id\n\tcg14mr4750681plb.161.1559953218649; \n\tFri, 07 Jun 2019 17:20:18 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 7 Jun 2019 17:20:01 -0700", "Message-Id": "<20190608002003.19942-8-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190608002003.19942-1-stephen@networkplumber.org>", "References": "<20190608002003.19942-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 7/9] kni: use proper type for kni fifo's", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Using void * instead of proper type is unsafe practice.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_dev.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h\nindex f3e6c3ca4efa..ceba5f73c1d9 100644\n--- a/kernel/linux/kni/kni_dev.h\n+++ b/kernel/linux/kni/kni_dev.h\n@@ -51,22 +51,22 @@ struct kni_dev {\n \tstruct net_device *net_dev;\n \n \t/* queue for packets to be sent out */\n-\tvoid *tx_q;\n+\tstruct rte_kni_fifo *tx_q;\n \n \t/* queue for the packets received */\n-\tvoid *rx_q;\n+\tstruct rte_kni_fifo *rx_q;\n \n \t/* queue for the allocated mbufs those can be used to save sk buffs */\n-\tvoid *alloc_q;\n+\tstruct rte_kni_fifo *alloc_q;\n \n \t/* free queue for the mbufs to be freed */\n-\tvoid *free_q;\n+\tstruct rte_kni_fifo *free_q;\n \n \t/* request queue */\n-\tvoid *req_q;\n+\tstruct rte_kni_fifo *req_q;\n \n \t/* response queue */\n-\tvoid *resp_q;\n+\tstruct rte_kni_fifo *resp_q;\n \n \tvoid *sync_kva;\n \tvoid *sync_va;\n", "prefixes": [ "7/9" ] }