Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 54557,
    "url": "http://patches.dpdk.org/api/patches/54557/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190608002003.19942-6-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190608002003.19942-6-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190608002003.19942-6-stephen@networkplumber.org",
    "date": "2019-06-08T00:19:59",
    "name": "[5/9] kni: drop unused group_id and device_id",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "c1e806b0f252e1180584e1038e5fa2a79f02ca2b",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190608002003.19942-6-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 4956,
            "url": "http://patches.dpdk.org/api/series/4956/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4956",
            "date": "2019-06-08T00:19:54",
            "name": "kni: cleanups and improvements",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/4956/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/54557/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/54557/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 807691BCAE;\n\tSat,  8 Jun 2019 02:20:25 +0200 (CEST)",
            "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 3AE141BC90\n\tfor <dev@dpdk.org>; Sat,  8 Jun 2019 02:20:17 +0200 (CEST)",
            "by mail-pf1-f194.google.com with SMTP id x15so2065642pfq.0\n\tfor <dev@dpdk.org>; Fri, 07 Jun 2019 17:20:17 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tn184sm4012463pfn.21.2019.06.07.17.20.15\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tFri, 07 Jun 2019 17:20:15 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=MyR0bTf4Mt+he7JIm/J3aX664JMTwBCJZQUUdrjjaXE=;\n\tb=qD44xcJWdg0VBS+LLyUehorG052dRyCX2NHEeM4cxj6DZHSqKYZ25Qt8hvGwMJAsPO\n\to9p93+vIIlbwCSSTnK/r4oSO9D3RiT9CUvCQwLhRutiVgNiLUDJqy2q3HPF4Lsl1FZDE\n\tv6kX178ENqkN5vkgS1ZSPnpTydpEXCMQ/pKT6bJPncEZXDGLejJrLCN0sNS+qjPwH9SA\n\te9YPeoL3B6yVgRSIQ4Y6cBfTWUrjsLcYI2p4Cq6N7cbFSz0RjjmPQ7j+3JBDrxxqhBVQ\n\tlCJ4g9BXF5ZcBEfE32iFuNIb2z/eYl8gbCxDj+sqcX7s3Nz+E7BMX3Ncmt/ikb6o4kgo\n\tLetQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=MyR0bTf4Mt+he7JIm/J3aX664JMTwBCJZQUUdrjjaXE=;\n\tb=uYp3LUdW+RfCV0fvg7Vabv0VSljsXtA4CZzOLuxWtoJHKMb9kKcFVoqid6FePebwx0\n\tJTjU/2nguBDFcD3XC3iI58jZs6wdCLFeOq2MyUxaqj7b+2T8gLFHqqix6gFYci9AEhix\n\tTbVf2zfIhXyDRVYWM9/u2GRWUrc03+xaRso24ZFoKCElAzDog5VjlIO8Mb03zIlWq8c6\n\tOZSEojwi/0q//Nv1rzIQ2zeo/jcfn385Cdcvs5zLEsfMv+U+Pc3irL0SgWctqBaGIte0\n\t/Kmov8FqstOxOaXSNO9rG3pl0sqpYRRIX4Nn5Yyo88/sa4TRt2dD2arU9k22iQl54cQd\n\thCXw==",
        "X-Gm-Message-State": "APjAAAWt4j+4jQKXlXRnH9TUs5+xaw/i1oalnCI0amHDsg0Or+n7PEpa\n\tNmnzOB7eqg7Ds3ULj7H5NF9o50kdZZU=",
        "X-Google-Smtp-Source": "APXvYqzaZ9+owUCJI5fW3JTtD4oX9DCJRSkCA73C5gUGeSV3IWbq9ELBrfYnGIg8I5ebeHCTumU+Dw==",
        "X-Received": "by 2002:a17:90a:62cb:: with SMTP id\n\tk11mr8257620pjs.26.1559953216422; \n\tFri, 07 Jun 2019 17:20:16 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "ferruh.yigit@intel.com",
        "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>",
        "Date": "Fri,  7 Jun 2019 17:19:59 -0700",
        "Message-Id": "<20190608002003.19942-6-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190608002003.19942-1-stephen@networkplumber.org>",
        "References": "<20190608002003.19942-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 5/9] kni: drop unused group_id and device_id",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Kni devices no longer are restricted to PCI and device_id\nin kni_dev is no longer used.\n\nThe group_id is set but never used.\n\nThe fields do need to stay in the ABI (dev_info) but\nkernel can ignore them.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_dev.h  | 4 ----\n kernel/linux/kni/kni_misc.c | 1 -\n 2 files changed, 5 deletions(-)",
    "diff": "diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h\nindex ca3b07678b96..e39af97feaa7 100644\n--- a/kernel/linux/kni/kni_dev.h\n+++ b/kernel/linux/kni/kni_dev.h\n@@ -40,7 +40,6 @@ struct kni_dev {\n \tstruct list_head list;\n \n \tint status;\n-\tuint16_t group_id;           /* Group ID of a group of KNI devices */\n \tuint32_t core_id;            /* Core ID to bind */\n \tchar name[RTE_KNI_NAMESIZE]; /* Network device name */\n \tstruct task_struct *pthread;\n@@ -49,9 +48,6 @@ struct kni_dev {\n \twait_queue_head_t wq;\n \tstruct mutex sync_lock;\n \n-\t/* PCI device id */\n-\tuint16_t device_id;\n-\n \t/* kni device */\n \tstruct net_device *net_dev;\n \ndiff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c\nindex af18c67c422f..6a206d883c0d 100644\n--- a/kernel/linux/kni/kni_misc.c\n+++ b/kernel/linux/kni/kni_misc.c\n@@ -346,7 +346,6 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,\n \tkni = netdev_priv(net_dev);\n \n \tkni->net_dev = net_dev;\n-\tkni->group_id = dev_info.group_id;\n \tkni->core_id = dev_info.core_id;\n \tstrncpy(kni->name, dev_info.name, RTE_KNI_NAMESIZE);\n \n",
    "prefixes": [
        "5/9"
    ]
}