Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54554/?format=api
{ "id": 54554, "url": "http://patches.dpdk.org/api/patches/54554/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190608002003.19942-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190608002003.19942-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190608002003.19942-3-stephen@networkplumber.org", "date": "2019-06-08T00:19:56", "name": "[2/9] kni: use netdev_alloc_skb", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "404f573fdd77b01ce2345f5996200398f0cab816", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190608002003.19942-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 4956, "url": "http://patches.dpdk.org/api/series/4956/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4956", "date": "2019-06-08T00:19:54", "name": "kni: cleanups and improvements", "version": 1, "mbox": "http://patches.dpdk.org/series/4956/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54554/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54554/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C4EE31BC99;\n\tSat, 8 Jun 2019 02:20:18 +0200 (CEST)", "from mail-pl1-f193.google.com (mail-pl1-f193.google.com\n\t[209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 235591BC84\n\tfor <dev@dpdk.org>; Sat, 8 Jun 2019 02:20:14 +0200 (CEST)", "by mail-pl1-f193.google.com with SMTP id bi6so1008303plb.12\n\tfor <dev@dpdk.org>; Fri, 07 Jun 2019 17:20:14 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tn184sm4012463pfn.21.2019.06.07.17.20.12\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tFri, 07 Jun 2019 17:20:12 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=VLK4KVn81E10EBS5qXls3g7KXlhM31ZSO449iJbEFmE=;\n\tb=uIljI+cttZOf9SwS0j4EiRElfqlCIcJj0n3G7q6VdlzTVxUAddxhH0/rmcHmmmwawT\n\tDNV9suRNFxM2muYnaTx5+NvowMhpjr6znp9KL0gAnZkYkDDtfocwgSDOlyYITBSJpRg6\n\t3GAnH6brV8+oIgu8GgHqWc8NuzfCvS1ghCrSqo8Suy890cDE0yOu3Fw1MTUd9jPwhPp/\n\toEWch2HbsMrgSvB6xouljPGXgXbSU1vjYz8g2u5NY7wXwESVKPfg2k4eTWf1l/3N7c8f\n\tfJ0wmpZ76uTKOoYSEjaQBcrf4L3inEOnbjET3zWh+/V528aUWl2TBgpDJ8rsB9Djt7wy\n\tFNCQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=VLK4KVn81E10EBS5qXls3g7KXlhM31ZSO449iJbEFmE=;\n\tb=bj3w0P3JSMXGvbdnQZq3CsQxHCm1vzPXX1KzY8MqHByrxIvBDZ2xZAYJJHV/BabHAq\n\tjKMSAM6gBjaVrBo21ATr1/zbFVqy1mcBhvh3n8U/mJPcUC1b3hXC2I8x3W6TIdMPTTeR\n\tfkwdYGfn6zS+pTlMsrlptyBm/6UhRkps6AOa7yWUTQxrwmaCWGNc1N/XGq76x1jEhxSo\n\ta+MDzCuSCQH7Ao0zyiCD06xPlPzvFoaLwtkjPP6qs+4J8NPgIecmR/di7BLvyfxhGfqC\n\tY5rcgAc5ZmwOVzswrHvgChcBAZ7zZNVmNW0+tUPIjYGZKkb+BIEwjG2GqSsQs4wyzoja\n\tR9hg==", "X-Gm-Message-State": "APjAAAWP03wxHTIkN7KZpMHWuAz9FOYeXOSZYkBj6nMx5WSvL8cBkHi1\n\t5cOmm2P+oaZk4/SrQv1ZcuFhpQ==", "X-Google-Smtp-Source": "APXvYqynM/zVRQwkIiBMi4rma0idAMSJT4BY7/QcZUamqnCs9ud4o/Izo8NNv/5iE2HI3EWIYwZxbg==", "X-Received": "by 2002:a17:902:934b:: with SMTP id\n\tg11mr46123420plp.245.1559953213361; \n\tFri, 07 Jun 2019 17:20:13 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 7 Jun 2019 17:19:56 -0700", "Message-Id": "<20190608002003.19942-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190608002003.19942-1-stephen@networkplumber.org>", "References": "<20190608002003.19942-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/9] kni: use netdev_alloc_skb", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "netdev_alloc_skb is optimized to any alignment or setup\nof skb->dev that is required. The kernel has chosen to not pad\npackets on x86 (for many years), because it is faster.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_net.c | 17 +++--------------\n 1 file changed, 3 insertions(+), 14 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c\nindex c86337d099ab..2f2c30cc13ff 100644\n--- a/kernel/linux/kni/kni_net.c\n+++ b/kernel/linux/kni/kni_net.c\n@@ -340,16 +340,13 @@ kni_net_rx_normal(struct kni_dev *kni)\n \t\tdata_kva = kva2data_kva(kva);\n \t\tkni->va[i] = pa2va(kni->pa[i], kva);\n \n-\t\tskb = dev_alloc_skb(len + 2);\n+\t\tskb = netdev_alloc_skb(dev, len + 2);\n \t\tif (!skb) {\n \t\t\t/* Update statistics */\n \t\t\tkni->stats.rx_dropped++;\n \t\t\tcontinue;\n \t\t}\n \n-\t\t/* Align IP on 16B boundary */\n-\t\tskb_reserve(skb, 2);\n-\n \t\tif (kva->nb_segs == 1) {\n \t\t\tmemcpy(skb_put(skb, len), data_kva, len);\n \t\t} else {\n@@ -368,7 +365,6 @@ kni_net_rx_normal(struct kni_dev *kni)\n \t\t\t}\n \t\t}\n \n-\t\tskb->dev = dev;\n \t\tskb->protocol = eth_type_trans(skb, dev);\n \t\tskb->ip_summed = CHECKSUM_UNNECESSARY;\n \n@@ -512,26 +508,20 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni)\n \t\tdata_kva = kva2data_kva(kva);\n \t\tkni->va[i] = pa2va(kni->pa[i], kva);\n \n-\t\tskb = dev_alloc_skb(len + 2);\n+\t\tskb = netdev_alloc_skb(dev, len + 2);\n \t\tif (skb) {\n-\t\t\t/* Align IP on 16B boundary */\n-\t\t\tskb_reserve(skb, 2);\n \t\t\tmemcpy(skb_put(skb, len), data_kva, len);\n-\t\t\tskb->dev = dev;\n \t\t\tskb->ip_summed = CHECKSUM_UNNECESSARY;\n \t\t\tdev_kfree_skb(skb);\n \t\t}\n \n \t\t/* Simulate real usage, allocate/copy skb twice */\n-\t\tskb = dev_alloc_skb(len + 2);\n+\t\tskb = netdev_alloc_skb(dev, len + 2);\n \t\tif (skb == NULL) {\n \t\t\tkni->stats.rx_dropped++;\n \t\t\tcontinue;\n \t\t}\n \n-\t\t/* Align IP on 16B boundary */\n-\t\tskb_reserve(skb, 2);\n-\n \t\tif (kva->nb_segs == 1) {\n \t\t\tmemcpy(skb_put(skb, len), data_kva, len);\n \t\t} else {\n@@ -550,7 +540,6 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni)\n \t\t\t}\n \t\t}\n \n-\t\tskb->dev = dev;\n \t\tskb->ip_summed = CHECKSUM_UNNECESSARY;\n \n \t\tkni->stats.rx_bytes += len;\n", "prefixes": [ "2/9" ] }