Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 54541,
    "url": "http://patches.dpdk.org/api/patches/54541/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1559903595-18506-2-git-send-email-bernard.iremonger@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1559903595-18506-2-git-send-email-bernard.iremonger@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1559903595-18506-2-git-send-email-bernard.iremonger@intel.com",
    "date": "2019-06-07T10:33:13",
    "name": "[v2,1/3] test/ipsec: fix log messages in tests",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "8a369e258af58a0f0c4454409677e18a71aa9573",
    "submitter": {
        "id": 91,
        "url": "http://patches.dpdk.org/api/people/91/?format=api",
        "name": "Iremonger, Bernard",
        "email": "bernard.iremonger@intel.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1559903595-18506-2-git-send-email-bernard.iremonger@intel.com/mbox/",
    "series": [
        {
            "id": 4950,
            "url": "http://patches.dpdk.org/api/series/4950/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4950",
            "date": "2019-06-07T10:33:12",
            "name": "test/ipsec: fixes and improvements",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/4950/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/54541/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/54541/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 475C71BA56;\n\tFri,  7 Jun 2019 12:33:29 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 416121BA46;\n\tFri,  7 Jun 2019 12:33:27 +0200 (CEST)",
            "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Jun 2019 03:33:26 -0700",
            "from sivswdev08.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.47])\n\tby fmsmga005.fm.intel.com with ESMTP; 07 Jun 2019 03:33:25 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "From": "Bernard Iremonger <bernard.iremonger@intel.com>",
        "To": "dev@dpdk.org,\n\tkonstantin.ananyev@intel.com,\n\takhil.goyal@nxp.com",
        "Cc": "Bernard Iremonger <bernard.iremonger@intel.com>,\n\tstable@dpdk.org",
        "Date": "Fri,  7 Jun 2019 11:33:13 +0100",
        "Message-Id": "<1559903595-18506-2-git-send-email-bernard.iremonger@intel.com>",
        "X-Mailer": "git-send-email 1.7.0.7",
        "In-Reply-To": "<1558532302-15932-0-git-send-email-bernard.iremonger@intel.com>",
        "References": "<1558532302-15932-0-git-send-email-bernard.iremonger@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 1/3] test/ipsec: fix log messages in tests",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Error log messages after the create_sa() function calls\nwere using the wrong function name.\nThe function name is replaced with create_sa.\n\nFixes: 05fe65eb66b2 (\"test/ipsec: introduce functional test\")\nCc: stable@dpdk.org\nSigned-off-by: Bernard Iremonger <bernard.iremonger@intel.com>\n---\n app/test/test_ipsec.c | 44 +++++++++++++++-----------------------------\n 1 file changed, 15 insertions(+), 29 deletions(-)",
    "diff": "diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c\nindex 3993ff4..cce15a7 100644\n--- a/app/test/test_ipsec.c\n+++ b/app/test/test_ipsec.c\n@@ -1200,8 +1200,7 @@ test_ipsec_crypto_inb_burst_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_NONE,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -1303,8 +1302,7 @@ test_ipsec_crypto_outb_burst_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_NONE,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -1413,8 +1411,7 @@ test_ipsec_inline_crypto_inb_burst_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -1492,8 +1489,7 @@ test_ipsec_inline_proto_inb_burst_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -1601,8 +1597,7 @@ test_ipsec_inline_crypto_outb_burst_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -1680,8 +1675,7 @@ test_ipsec_inline_proto_outb_burst_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -1757,8 +1751,7 @@ test_ipsec_lksd_proto_inb_burst_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -1871,8 +1864,7 @@ test_ipsec_replay_inb_inside_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_NONE,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -1965,8 +1957,7 @@ test_ipsec_replay_inb_outside_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_NONE,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -2066,7 +2057,7 @@ test_ipsec_replay_inb_repeat_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_NONE,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\", i);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -2167,8 +2158,7 @@ test_ipsec_replay_inb_inside_burst_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_NONE,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -2301,8 +2291,7 @@ test_ipsec_crypto_inb_burst_2sa_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_NONE,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa 0 failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -2311,8 +2300,7 @@ test_ipsec_crypto_inb_burst_2sa_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_NONE,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 1);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa 1 failed, cfg %d\\n\", i);\n \t\tdestroy_sa(0);\n \t\treturn TEST_FAILED;\n \t}\n@@ -2389,8 +2377,7 @@ test_ipsec_crypto_inb_burst_2sa_4grp_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_NONE,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa 0 failed, cfg %d\\n\", i);\n \t\treturn TEST_FAILED;\n \t}\n \n@@ -2399,8 +2386,7 @@ test_ipsec_crypto_inb_burst_2sa_4grp_null_null(int i)\n \trc = create_sa(RTE_SECURITY_ACTION_TYPE_NONE,\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 1);\n \tif (rc != 0) {\n-\t\tRTE_LOG(ERR, USER1, \"rte_ipsec_sa_init failed, cfg %d\\n\",\n-\t\t\ti);\n+\t\tRTE_LOG(ERR, USER1, \"create_sa 1 failed, cfg %d\\n\", i);\n \t\tdestroy_sa(0);\n \t\treturn TEST_FAILED;\n \t}\n",
    "prefixes": [
        "v2",
        "1/3"
    ]
}