Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54532/?format=api
{ "id": 54532, "url": "http://patches.dpdk.org/api/patches/54532/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190607100608.16212-4-damianx.nowak@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190607100608.16212-4-damianx.nowak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190607100608.16212-4-damianx.nowak@intel.com", "date": "2019-06-07T10:06:00", "name": "[v2,03/10] crypto/qat: handle buffer size for digest-encrypted auth-cipher", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "93e770c761799b5fa6713e582dd7cb54763b778a", "submitter": { "id": 1184, "url": "http://patches.dpdk.org/api/people/1184/?format=api", "name": "Damian Nowak", "email": "damianx.nowak@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190607100608.16212-4-damianx.nowak@intel.com/mbox/", "series": [ { "id": 4949, "url": "http://patches.dpdk.org/api/series/4949/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4949", "date": "2019-06-07T10:05:57", "name": "cryptodev: support encrypted-digest use-cases", "version": 2, "mbox": "http://patches.dpdk.org/series/4949/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54532/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54532/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D66421B9C7;\n\tFri, 7 Jun 2019 12:09:38 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 4A5281B9B4\n\tfor <dev@dpdk.org>; Fri, 7 Jun 2019 12:09:32 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Jun 2019 03:09:31 -0700", "from damiannx-mobl1.ger.corp.intel.com ([10.103.104.100])\n\tby fmsmga001.fm.intel.com with ESMTP; 07 Jun 2019 03:09:30 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Damian Nowak <damianx.nowak@intel.com>", "To": "dev@dpdk.org", "Cc": "fiona.trahe@intel.com, arkadiuszx.kusztal@intel.com,\n\tDamian Nowak <damianx.nowak@intel.com>", "Date": "Fri, 7 Jun 2019 12:06:00 +0200", "Message-Id": "<20190607100608.16212-4-damianx.nowak@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20190607100608.16212-1-damianx.nowak@intel.com>", "References": "<20190603145048.2596-1-damianx.nowak@intel.com>\n\t<20190607100608.16212-1-damianx.nowak@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 03/10] crypto/qat: handle buffer size for\n\tdigest-encrypted auth-cipher", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch adds condition to be met when using\nwireless algorithms (SNOW3G, KASUMI, ZUC) in\nout-of-place auth-cipher operations. It checks\nif the digest location overlaps with the data to\nbe encrypted or decrypted and if so, treats as a\ndigest-encrypted case.\nIt also checks if the digest is being encrypted\nor decrypted partially and extends PMD buffers\naccordingly.\n\nSigned-off-by: Damian Nowak <damianx.nowak@intel.com>\n---\n drivers/crypto/qat/qat_sym.c | 31 +++++++++++++++++++------------\n 1 file changed, 19 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c\nindex 8801ca5..90b0ba4 100644\n--- a/drivers/crypto/qat/qat_sym.c\n+++ b/drivers/crypto/qat/qat_sym.c\n@@ -493,6 +493,25 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,\n \t\t(cipher_param->cipher_offset + cipher_param->cipher_length)\n \t\t: (auth_param->auth_off + auth_param->auth_len);\n \n+\t/* Handle case of auth-gen-then-cipher with digest encrypted */\n+\tif (wireless_auth &&\n+\t\t\t(auth_ofs + auth_len < cipher_ofs + cipher_len) &&\n+\t\t\t(op->sym->auth.digest.phys_addr ==\n+\t\t\t\t(in_place ? src_buf_start : dst_buf_start) +\n+\t\t\t\tauth_ofs + auth_len)) {\n+\t\t/* Handle partial digest encryption */\n+\t\tif (cipher_ofs + cipher_len <\n+\t\t\t\tauth_ofs + auth_len + ctx->digest_length)\n+\t\t\tqat_req->comn_mid.dst_length =\n+\t\t\t\tqat_req->comn_mid.src_length +=\n+\t\t\t\tauth_ofs + auth_len + ctx->digest_length -\n+\t\t\t\tcipher_ofs - cipher_len;\n+\t\tstruct icp_qat_fw_comn_req_hdr *header = &qat_req->comn_hdr;\n+\t\tICP_QAT_FW_LA_DIGEST_IN_BUFFER_SET(\n+\t\t\theader->serv_specif_flags,\n+\t\t\tICP_QAT_FW_LA_DIGEST_IN_BUFFER);\n+\t}\n+\n \tif (do_sgl) {\n \n \t\tICP_QAT_FW_COMN_PTR_TYPE_SET(qat_req->comn_hdr.comn_req_flags,\n@@ -533,18 +552,6 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,\n \t} else {\n \t\tqat_req->comn_mid.src_data_addr = src_buf_start;\n \t\tqat_req->comn_mid.dest_data_addr = dst_buf_start;\n-\t\t/* handle case of auth-gen-then-cipher with digest encrypted */\n-\t\tif (wireless_auth && in_place &&\n-\t\t (op->sym->auth.digest.phys_addr ==\n-\t\t\t\tsrc_buf_start + auth_ofs + auth_len) &&\n-\t\t (auth_ofs + auth_len + ctx->digest_length <=\n-\t\t\t\tcipher_ofs + cipher_len)) {\n-\t\t\tstruct icp_qat_fw_comn_req_hdr *header =\n-\t\t\t\t\t\t&qat_req->comn_hdr;\n-\t\t\tICP_QAT_FW_LA_DIGEST_IN_BUFFER_SET(\n-\t\t\t\theader->serv_specif_flags,\n-\t\t\t\tICP_QAT_FW_LA_DIGEST_IN_BUFFER);\n-\t\t}\n \t}\n \n #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n", "prefixes": [ "v2", "03/10" ] }