Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54524/?format=api
{ "id": 54524, "url": "http://patches.dpdk.org/api/patches/54524/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190607022830.2044-1-tyos@jp.ibm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190607022830.2044-1-tyos@jp.ibm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190607022830.2044-1-tyos@jp.ibm.com", "date": "2019-06-07T02:28:29", "name": "vfio: retry creating sPAPR DMA window", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "33e1bfef25a5bcbfa9a4c952ec61e05dfc42a15c", "submitter": { "id": 1099, "url": "http://patches.dpdk.org/api/people/1099/?format=api", "name": "Takeshi Yoshimura", "email": "tyos@jp.ibm.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190607022830.2044-1-tyos@jp.ibm.com/mbox/", "series": [ { "id": 4945, "url": "http://patches.dpdk.org/api/series/4945/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4945", "date": "2019-06-07T02:28:29", "name": "vfio: retry creating sPAPR DMA window", "version": 1, "mbox": "http://patches.dpdk.org/series/4945/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54524/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/54524/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BFEECF64;\n\tFri, 7 Jun 2019 04:28:37 +0200 (CEST)", "from nh605-vm4.bullet.mail.ssk.yahoo.co.jp\n\t(nh605-vm4.bullet.mail.ssk.yahoo.co.jp [182.22.90.77])\n\tby dpdk.org (Postfix) with SMTP id C074923D\n\tfor <dev@dpdk.org>; Fri, 7 Jun 2019 04:28:35 +0200 (CEST)", "from [182.22.66.103] by nh605.bullet.mail.ssk.yahoo.co.jp with\n\tNNFMP; 07 Jun 2019 02:28:32 -0000", "from [182.22.91.206] by t601.bullet.mail.ssk.yahoo.co.jp with\n\tNNFMP; 07 Jun 2019 02:28:32 -0000", "from [127.0.0.1] by omp609.mail.ssk.yahoo.co.jp with NNFMP;\n\t07 Jun 2019 02:28:32 -0000", "(qmail 79854 invoked by alias); 7 Jun 2019 02:28:32 -0000", "from unknown (HELO takeshibookpuro.dhcp.hakozaki.ibm.com)\n\t(203.141.91.13 with login)\n\tby ymobsmtp6001.mail.ssk.ynwp.yahoo.co.jp with SMTP;\n\t7 Jun 2019 02:28:32 -0000" ], "X-Yahoo-Newman-Property": "ymail-3", "X-Yahoo-Newman-Id": "960636.40440.bm@omp609.mail.ssk.yahoo.co.jp", "X-YMail-JAS": "Y9N23ZoVM1nrWw.twlsHhFiAg5VZAG0.9706_BhEhJuZhqEk0SvtDEMPdAbb2sYTHj6daUCshaiasTAW3QfKB6mBXYKroWNfRfS58vBl5V1gy_0nZ8wulMBUcpz7jd7AvzG.JUFJrhFfn9E-", "X-Apparently-From": "<endliner2000@yahoo.co.jp>", "X-YMail-OSG": "FgfOTWMVM1m80v2LXDdtHUUOyLLdK20Jsd87SLhDpqPHKVA\n\t4Wy2emLFR5GP.2bu7G3WC.Y9rS3riRMR3SPozRHl5M5KmUSxBJ.yYBCripmu\n\tLXwxgUzaW07MWGrOQTXNFBwgx_AWrE_V8efNhgSMrwnEw4DvDE4voa3HFyKX\n\tUjDu9HXcsSGXu46IoAqtqDrkP8_6T6kHKyff_oVjKYV509ErcpNhy.jOKbWy\n\tCXQ3e1cy3ReJrDkBKcNbHNofN9iBlJZZW_G3w.mQqRLVU05wweKQQToR2qWU\n\t8RB0N68r_8Ah6qd6T68pP7bDBFTP7oPBDjrJhiC7f1cAx_B.fasuv7Cn6bt2\n\tqjrU9P_I6ijogWeASjVx94z6XSgEVEPhCSKEoBciWKbTQ1H8ocRJLpDDggLM\n\t0mqdPN8vOZjnJo3Dh5y.w4_q3hfEynX.Szx0FkoGrz5mNWCJ10KKSMgX7XDo\n\tQ4nJxCIpaicKQFH2TPp8hnINU7wZpWSEpU3RiQMF.2CoAKQ1yFEL0gJWPraG\n\tXJ_LgEu9eEp.HwWDjpI7KKMenDMwYc0cK6EXfxH_6jwxs71mgFWv3OaOAdjb\n\tFLA3fGbC1BrWWzVb_5bpL6u6Bb6o-", "From": "Takeshi Yoshimura <tyos@jp.ibm.com>", "To": "dev@dpdk.org", "Cc": "Takeshi Yoshimura <tyos@jp.ibm.com>", "Date": "Fri, 7 Jun 2019 11:28:29 +0900", "Message-Id": "<20190607022830.2044-1-tyos@jp.ibm.com>", "X-Mailer": "git-send-email 2.17.2 (Apple Git-113)", "Subject": "[dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl.\nHowever, Linux 4.17 or before returns incorrect page_shift for Power9.\nI added the code for retrying creation of sPAPR DMA window.\n\nSigned-off-by: Takeshi Yoshimura <tyos@jp.ibm.com>\n---\n lib/librte_eal/linux/eal/eal_vfio.c | 26 +++++++++++++++++++++++---\n 1 file changed, 23 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c\nindex 6892a2c14..f16c5c3c0 100644\n--- a/lib/librte_eal/linux/eal/eal_vfio.c\n+++ b/lib/librte_eal/linux/eal/eal_vfio.c\n@@ -1448,9 +1448,29 @@ vfio_spapr_create_new_dma_window(int vfio_container_fd,\n \t/* create new DMA window */\n \tret = ioctl(vfio_container_fd, VFIO_IOMMU_SPAPR_TCE_CREATE, create);\n \tif (ret) {\n-\t\tRTE_LOG(ERR, EAL, \" cannot create new DMA window, \"\n-\t\t\t\t\"error %i (%s)\\n\", errno, strerror(errno));\n-\t\treturn -1;\n+\t\t/* try possible page_shift and levels for workaround */\n+\t\tuint32_t levels;\n+\n+\t\tfor (levels = 1; levels <= info.ddw.levels; levels++) {\n+\t\t\tuint32_t pgsizes = info.ddw.pgsizes;\n+\n+\t\t\twhile (pgsizes != 0) {\n+\t\t\t\tcreate->page_shift = 31 - __builtin_clz(pgsizes);\n+\t\t\t\tcreate->levels = levels;\n+\t\t\t\tret = ioctl(vfio_container_fd,\n+\t\t\t\t\tVFIO_IOMMU_SPAPR_TCE_CREATE, create);\n+\t\t\t\tif (!ret)\n+\t\t\t\t\tbreak;\n+\t\t\t\tpgsizes &= ~(1 << create->page_shift);\n+\t\t\t}\n+\t\t\tif (!ret)\n+\t\t\t\tbreak;\n+\t\t}\n+\t\tif (ret) {\n+\t\t\tRTE_LOG(ERR, EAL, \" cannot create new DMA window, \"\n+\t\t\t\t\t\"error %i (%s)\\n\", errno, strerror(errno));\n+\t\t\treturn -1;\n+\t\t}\n \t}\n \n \tif (create->start_addr != 0) {\n", "prefixes": [] }