Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54506/?format=api
{ "id": 54506, "url": "http://patches.dpdk.org/api/patches/54506/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190606152658.17311-5-hyonkim@cisco.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190606152658.17311-5-hyonkim@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190606152658.17311-5-hyonkim@cisco.com", "date": "2019-06-06T15:26:58", "name": "[4/4] net/enic: remove locks from rte flow code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "97562a2ae6a919a808c5ee69cd7861901317a05d", "submitter": { "id": 948, "url": "http://patches.dpdk.org/api/people/948/?format=api", "name": "Hyong Youb Kim (hyonkim)", "email": "hyonkim@cisco.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190606152658.17311-5-hyonkim@cisco.com/mbox/", "series": [ { "id": 4934, "url": "http://patches.dpdk.org/api/series/4934/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4934", "date": "2019-06-06T15:26:54", "name": "net/enic: minor updates", "version": 1, "mbox": "http://patches.dpdk.org/series/4934/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54506/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54506/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 703F41B9CB;\n\tThu, 6 Jun 2019 17:27:58 +0200 (CEST)", "from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79])\n\tby dpdk.org (Postfix) with ESMTP id BB3C71B9AF;\n\tThu, 6 Jun 2019 17:27:55 +0200 (CEST)", "from rcdn-core-4.cisco.com ([173.37.93.155])\n\tby rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n\t06 Jun 2019 15:27:54 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby rcdn-core-4.cisco.com (8.15.2/8.15.2) with ESMTP id x56FRs9e026314;\n\tThu, 6 Jun 2019 15:27:54 GMT", "by cisco.com (Postfix, from userid 508933)\n\tid 962FD20F2001; Thu, 6 Jun 2019 08:27:54 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=2602; q=dns/txt; s=iport;\n\tt=1559834876; x=1561044476;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=UstlSHdFZ7XMInm0YjKQ+Y0sFbv+gB3t5W/9BTnBZUQ=;\n\tb=Nu71ZaCYYuL09xdq0uQOEjnIfI4zRcOjDm8Qn+uW66liHgRIsPfhlcpi\n\ttCFxsvBbLr6ipcQUN/6y/0+/jDErbnti/cyefeZRXlgu9HvFt1yUnN6os\n\tdhw63Gjynxnbfjisah0zb6kJMJUf2mfahIunMZKxOo1WM8OcP9RzchQ4u 0=;", "X-IronPort-AV": "E=Sophos;i=\"5.63,559,1557187200\"; d=\"scan'208\";a=\"568781441\"", "From": "Hyong Youb Kim <hyonkim@cisco.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org, John Daley <johndale@cisco.com>, stable@dpdk.org", "Date": "Thu, 6 Jun 2019 08:26:58 -0700", "Message-Id": "<20190606152658.17311-5-hyonkim@cisco.com>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20190606152658.17311-1-hyonkim@cisco.com>", "References": "<20190606152658.17311-1-hyonkim@cisco.com>", "X-Outbound-SMTP-Client": "10.193.184.48, savbu-usnic-a.cisco.com", "X-Outbound-Node": "rcdn-core-4.cisco.com", "Subject": "[dpdk-dev] [PATCH 4/4] net/enic: remove locks from rte flow code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: John Daley <johndale@cisco.com>\n\nThere is no requirement for thread safety in the flow PMD code and no need\nfor the locks.\n\nFixes: 6ced137607d0 (\"net/enic: flow API for NICs with advanced filters enabled\")\nCc: stable@dpdk.org\n\nSigned-off-by: John Daley <johndale@cisco.com>\nReviewed-by: Hyong Youb Kim <hyonkim@cisco.com>\n---\n drivers/net/enic/enic.h | 1 -\n drivers/net/enic/enic_flow.c | 6 ------\n drivers/net/enic/enic_main.c | 1 -\n 3 files changed, 8 deletions(-)", "diff": "diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h\nindex fb48a0452..a919aad7d 100644\n--- a/drivers/net/enic/enic.h\n+++ b/drivers/net/enic/enic.h\n@@ -169,7 +169,6 @@ struct enic {\n \trte_spinlock_t mtu_lock;\n \n \tLIST_HEAD(enic_flows, rte_flow) flows;\n-\trte_spinlock_t flows_lock;\n \n \t/* RSS */\n \tuint16_t reta_size;\ndiff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c\nindex f389677c0..06796201d 100644\n--- a/drivers/net/enic/enic_flow.c\n+++ b/drivers/net/enic/enic_flow.c\n@@ -1737,12 +1737,10 @@ enic_flow_create(struct rte_eth_dev *dev,\n \tif (ret < 0)\n \t\treturn NULL;\n \n-\trte_spinlock_lock(&enic->flows_lock);\n \tflow = enic_flow_add_filter(enic, &enic_filter, &enic_action,\n \t\t\t\t error);\n \tif (flow)\n \t\tLIST_INSERT_HEAD(&enic->flows, flow, next);\n-\trte_spinlock_unlock(&enic->flows_lock);\n \n \treturn flow;\n }\n@@ -1761,10 +1759,8 @@ enic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow,\n \n \tFLOW_TRACE();\n \n-\trte_spinlock_lock(&enic->flows_lock);\n \tenic_flow_del_filter(enic, flow, error);\n \tLIST_REMOVE(flow, next);\n-\trte_spinlock_unlock(&enic->flows_lock);\n \trte_free(flow);\n \treturn 0;\n }\n@@ -1783,7 +1779,6 @@ enic_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)\n \n \tFLOW_TRACE();\n \n-\trte_spinlock_lock(&enic->flows_lock);\n \n \twhile (!LIST_EMPTY(&enic->flows)) {\n \t\tflow = LIST_FIRST(&enic->flows);\n@@ -1791,7 +1786,6 @@ enic_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)\n \t\tLIST_REMOVE(flow, next);\n \t\trte_free(flow);\n \t}\n-\trte_spinlock_unlock(&enic->flows_lock);\n \treturn 0;\n }\n \ndiff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c\nindex 2d6761bdd..c68d388dc 100644\n--- a/drivers/net/enic/enic_main.c\n+++ b/drivers/net/enic/enic_main.c\n@@ -1679,7 +1679,6 @@ static int enic_dev_init(struct enic *enic)\n \tvnic_dev_set_reset_flag(enic->vdev, 0);\n \n \tLIST_INIT(&enic->flows);\n-\trte_spinlock_init(&enic->flows_lock);\n \n \t/* set up link status checking */\n \tvnic_dev_notify_set(enic->vdev, -1); /* No Intr for notify */\n", "prefixes": [ "4/4" ] }