Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54449/?format=api
{ "id": 54449, "url": "http://patches.dpdk.org/api/patches/54449/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190605202248.394-10-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190605202248.394-10-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190605202248.394-10-bruce.richardson@intel.com", "date": "2019-06-05T20:22:47", "name": "[09/10] drivers/net: add reasons for components being disabled", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "325b729268a142e94842e3384352c1402bce0189", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190605202248.394-10-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4915, "url": "http://patches.dpdk.org/api/series/4915/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4915", "date": "2019-06-05T20:22:38", "name": "enhance meson summary - list disabled components", "version": 1, "mbox": "http://patches.dpdk.org/series/4915/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54449/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/54449/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1EBAD1B9F1;\n\tWed, 5 Jun 2019 22:23:28 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 2F0741B9E3\n\tfor <dev@dpdk.org>; Wed, 5 Jun 2019 22:23:26 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jun 2019 13:23:25 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby orsmga008.jf.intel.com with ESMTP; 05 Jun 2019 13:23:24 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "bluca@debian.org,\n\tthomas@monjalon.net", "Cc": "dev@dpdk.org, john.mcnamara@intel.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Wed, 5 Jun 2019 21:22:47 +0100", "Message-Id": "<20190605202248.394-10-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190605202248.394-1-bruce.richardson@intel.com>", "References": "<20190605202248.394-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 09/10] drivers/net: add reasons for components\n\tbeing disabled", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For each driver where we optionally disable it, add in the reason why it's\nbeing disabled, so the user knows how to fix it.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/af_packet/meson.build | 1 +\n drivers/net/af_xdp/meson.build | 1 +\n drivers/net/avp/meson.build | 3 ++-\n drivers/net/axgbe/meson.build | 1 +\n drivers/net/bnx2x/meson.build | 1 +\n drivers/net/dpaa/meson.build | 1 +\n drivers/net/dpaa2/meson.build | 3 ++-\n drivers/net/enetc/meson.build | 1 +\n drivers/net/ifc/meson.build | 1 +\n drivers/net/kni/meson.build | 1 +\n drivers/net/mlx4/meson.build | 1 +\n drivers/net/mlx5/meson.build | 1 +\n drivers/net/mvneta/meson.build | 1 +\n drivers/net/mvpp2/meson.build | 1 +\n drivers/net/netvsc/meson.build | 1 +\n drivers/net/nfb/meson.build | 1 +\n drivers/net/nfp/meson.build | 3 ++-\n drivers/net/pcap/meson.build | 1 +\n drivers/net/sfc/meson.build | 1 +\n drivers/net/softnic/meson.build | 3 ++-\n drivers/net/szedata2/meson.build | 1 +\n drivers/net/tap/meson.build | 3 ++-\n drivers/net/vdev_netvsc/meson.build | 3 ++-\n drivers/net/vhost/meson.build | 1 +\n 24 files changed, 30 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/af_packet/meson.build b/drivers/net/af_packet/meson.build\nindex 92c306c73..a7f392ea1 100644\n--- a/drivers/net/af_packet/meson.build\n+++ b/drivers/net/af_packet/meson.build\n@@ -3,5 +3,6 @@\n \n if not is_linux\n \tbuild = false\n+\treason = 'only supported on linux'\n endif\n sources = files('rte_eth_af_packet.c')\ndiff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build\nindex 7904840f0..ac679b92b 100644\n--- a/drivers/net/af_xdp/meson.build\n+++ b/drivers/net/af_xdp/meson.build\n@@ -13,4 +13,5 @@ if bpf_dep.found() and cc.has_header('bpf/xsk.h') and cc.has_header('linux/if_xd\n \tpkgconfig_extra_libs += '-lbpf'\n else\n \tbuild = false\n+\treason = 'missing dependency, \"libbpf\"'\n endif\ndiff --git a/drivers/net/avp/meson.build b/drivers/net/avp/meson.build\nindex 8138cb22d..a5f63cdef 100644\n--- a/drivers/net/avp/meson.build\n+++ b/drivers/net/avp/meson.build\n@@ -2,7 +2,8 @@\n # Copyright(c) 2018 Intel Corporation\n \n if not is_linux\n- build = false\n+\tbuild = false\n+\treason = 'only supported on linux'\n endif\n sources = files('avp_ethdev.c')\n install_headers('rte_avp_common.h', 'rte_avp_fifo.h')\ndiff --git a/drivers/net/axgbe/meson.build b/drivers/net/axgbe/meson.build\nindex 6decb25d4..86873b7ef 100644\n--- a/drivers/net/axgbe/meson.build\n+++ b/drivers/net/axgbe/meson.build\n@@ -3,6 +3,7 @@\n \n if not is_linux\n \tbuild = false\n+\treason = 'only supported on linux'\n endif\n \n sources = files('axgbe_ethdev.c',\ndiff --git a/drivers/net/bnx2x/meson.build b/drivers/net/bnx2x/meson.build\nindex dd189ffc4..4892bb234 100644\n--- a/drivers/net/bnx2x/meson.build\n+++ b/drivers/net/bnx2x/meson.build\n@@ -3,6 +3,7 @@\n \n dep = dependency('zlib', required: false)\n build = dep.found()\n+reason = 'missing dependency, \"zlib\"'\n ext_deps += dep\n cflags += '-DZLIB_CONST'\n sources = files('bnx2x.c',\ndiff --git a/drivers/net/dpaa/meson.build b/drivers/net/dpaa/meson.build\nindex 8e5418bd6..94c0e22c5 100644\n--- a/drivers/net/dpaa/meson.build\n+++ b/drivers/net/dpaa/meson.build\n@@ -3,6 +3,7 @@\n \n if not is_linux\n \tbuild = false\n+\treason = 'only supported on linux'\n endif\n deps += ['mempool_dpaa']\n \ndiff --git a/drivers/net/dpaa2/meson.build b/drivers/net/dpaa2/meson.build\nindex a0ea99238..7e74c656a 100644\n--- a/drivers/net/dpaa2/meson.build\n+++ b/drivers/net/dpaa2/meson.build\n@@ -4,7 +4,8 @@\n version = 2\n \n if not is_linux\n- build = false\n+\tbuild = false\n+\treason = 'only supported on linux'\n endif\n \n deps += ['mempool_dpaa2']\ndiff --git a/drivers/net/enetc/meson.build b/drivers/net/enetc/meson.build\nindex 7d0c2ffe7..3bc069844 100644\n--- a/drivers/net/enetc/meson.build\n+++ b/drivers/net/enetc/meson.build\n@@ -3,6 +3,7 @@\n \n if not is_linux\n \tbuild = false\n+\treason = 'only supported on linux'\n endif\n \n sources = files('enetc_ethdev.c',\ndiff --git a/drivers/net/ifc/meson.build b/drivers/net/ifc/meson.build\nindex 72df070ac..adc9ed9ff 100644\n--- a/drivers/net/ifc/meson.build\n+++ b/drivers/net/ifc/meson.build\n@@ -2,6 +2,7 @@\n # Copyright(c) 2018 Intel Corporation\n \n build = dpdk_conf.has('RTE_LIBRTE_VHOST')\n+reason = 'missing dependency, DPDK vhost library'\n allow_experimental_apis = true\n sources = files('ifcvf_vdpa.c', 'base/ifcvf.c')\n includes += include_directories('base')\ndiff --git a/drivers/net/kni/meson.build b/drivers/net/kni/meson.build\nindex e3b2d83b5..0539b4768 100644\n--- a/drivers/net/kni/meson.build\n+++ b/drivers/net/kni/meson.build\n@@ -3,5 +3,6 @@\n \n # this driver can be built if-and-only-if KNI library is buildable\n build = dpdk_conf.has('RTE_LIBRTE_KNI')\n+reason = 'missing dependency, DPDK KNI library'\n sources = files('rte_eth_kni.c')\n deps += 'kni'\ndiff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build\nindex 2540489bb..5de04b70b 100644\n--- a/drivers/net/mlx4/meson.build\n+++ b/drivers/net/mlx4/meson.build\n@@ -25,6 +25,7 @@ foreach libname:libnames\n \t\tlibs += [ lib ]\n \telse\n \t\tbuild = false\n+\t\treason = 'missing dependency, \"' + libname + '\"'\n \tendif\n endforeach\n # Compile PMD\ndiff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build\nindex ac3b529d1..22ddd54c2 100644\n--- a/drivers/net/mlx5/meson.build\n+++ b/drivers/net/mlx5/meson.build\n@@ -25,6 +25,7 @@ foreach libname:libnames\n \t\tlibs += [ lib ]\n \telse\n \t\tbuild = false\n+\t\treason = 'missing dependency, \"' + libname + '\"'\n \tendif\n endforeach\n if build\ndiff --git a/drivers/net/mvneta/meson.build b/drivers/net/mvneta/meson.build\nindex c0b1bce01..8d7202788 100644\n--- a/drivers/net/mvneta/meson.build\n+++ b/drivers/net/mvneta/meson.build\n@@ -10,6 +10,7 @@ inc_dir = path + '/include'\n lib = cc.find_library('libmusdk', dirs : [lib_dir], required: false)\n if not lib.found()\n \tbuild = false\n+\treason = 'missing dependency, \"libmusdk\"'\n else\n \text_deps += lib\n \tincludes += include_directories(inc_dir)\ndiff --git a/drivers/net/mvpp2/meson.build b/drivers/net/mvpp2/meson.build\nindex 70ef2d642..e06eddaac 100644\n--- a/drivers/net/mvpp2/meson.build\n+++ b/drivers/net/mvpp2/meson.build\n@@ -10,6 +10,7 @@ inc_dir = path + '/include'\n lib = cc.find_library('libmusdk', dirs : [lib_dir], required: false)\n if not lib.found()\n \tbuild = false\n+\treason = 'missing dependency, \"libmusdk\"'\n else\n \text_deps += lib\n \tincludes += include_directories(inc_dir)\ndiff --git a/drivers/net/netvsc/meson.build b/drivers/net/netvsc/meson.build\nindex c84269716..e9fe35344 100644\n--- a/drivers/net/netvsc/meson.build\n+++ b/drivers/net/netvsc/meson.build\n@@ -2,6 +2,7 @@\n # Copyright(c) 2018 Microsoft Corporation\n \n build = dpdk_conf.has('RTE_LIBRTE_VMBUS_BUS')\n+reason = 'missing dependency, DPDK VMBus driver'\n version = 2\n sources = files('hn_ethdev.c', 'hn_rxtx.c', 'hn_rndis.c', 'hn_nvs.c', 'hn_vf.c')\n \ndiff --git a/drivers/net/nfb/meson.build b/drivers/net/nfb/meson.build\nindex 457955d72..4502c3f76 100644\n--- a/drivers/net/nfb/meson.build\n+++ b/drivers/net/nfb/meson.build\n@@ -4,6 +4,7 @@\n # All rights reserved.\n \n dep = cc.find_library('nfb', required: false)\n+reason = 'missing dependency, \"libnfb\"'\n \n build = dep.found() and cc.has_header('nfb/nfb.h', dependencies: dep)\n \ndiff --git a/drivers/net/nfp/meson.build b/drivers/net/nfp/meson.build\nindex 8c87c5b0b..b487cdffd 100644\n--- a/drivers/net/nfp/meson.build\n+++ b/drivers/net/nfp/meson.build\n@@ -2,7 +2,8 @@\n # Copyright(c) 2018 Intel Corporation\n \n if not is_linux or not dpdk_conf.get('RTE_ARCH_64')\n- build = false\n+\tbuild = false\n+\treason = 'only supported on 64-bit linux'\n endif\n sources = files('nfpcore/nfp_cpp_pcie_ops.c',\n \t'nfpcore/nfp_nsp.c',\ndiff --git a/drivers/net/pcap/meson.build b/drivers/net/pcap/meson.build\nindex 2c2fd11e4..910dfab9b 100644\n--- a/drivers/net/pcap/meson.build\n+++ b/drivers/net/pcap/meson.build\n@@ -14,6 +14,7 @@ else\n \t\tpkgconfig_extra_libs += '-lpcap'\n \telse\n \t\tbuild = false\n+\t\treason = 'missing dependency, \"libpcap\"'\n \tendif\n endif\n sources = files('rte_eth_pcap.c')\ndiff --git a/drivers/net/sfc/meson.build b/drivers/net/sfc/meson.build\nindex e67560991..4fb0d0ac1 100644\n--- a/drivers/net/sfc/meson.build\n+++ b/drivers/net/sfc/meson.build\n@@ -8,6 +8,7 @@\n \n if arch_subdir != 'x86' or not dpdk_conf.get('RTE_ARCH_64')\n \tbuild = false\n+\treason = 'only supported on x86_64'\n endif\n \n allow_experimental_apis = true\ndiff --git a/drivers/net/softnic/meson.build b/drivers/net/softnic/meson.build\nindex dd1d610ea..9c10c2ec8 100644\n--- a/drivers/net/softnic/meson.build\n+++ b/drivers/net/softnic/meson.build\n@@ -2,7 +2,8 @@\n # Copyright(c) 2018 Intel Corporation\n \n if not is_linux\n- build = false\n+\tbuild = false\n+\treason = 'only supported on linux'\n endif\n allow_experimental_apis = true\n install_headers('rte_eth_softnic.h')\ndiff --git a/drivers/net/szedata2/meson.build b/drivers/net/szedata2/meson.build\nindex da3733743..032b42518 100644\n--- a/drivers/net/szedata2/meson.build\n+++ b/drivers/net/szedata2/meson.build\n@@ -3,5 +3,6 @@\n \n dep = cc.find_library('sze2', required: false)\n build = dep.found()\n+reason = 'missing dependency, \"libsze2\"'\n ext_deps += dep\n sources = files('rte_eth_szedata2.c')\ndiff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build\nindex c407a1f35..baa70f756 100644\n--- a/drivers/net/tap/meson.build\n+++ b/drivers/net/tap/meson.build\n@@ -2,7 +2,8 @@\n # Copyright 2018 Luca Boccassi <bluca@debian.org>\n \n if not is_linux\n- build = false\n+\tbuild = false\n+\treason = 'only supported on linux'\n endif\n sources = files(\n \t'rte_eth_tap.c',\ndiff --git a/drivers/net/vdev_netvsc/meson.build b/drivers/net/vdev_netvsc/meson.build\nindex 6655859f8..c82c5476c 100644\n--- a/drivers/net/vdev_netvsc/meson.build\n+++ b/drivers/net/vdev_netvsc/meson.build\n@@ -2,7 +2,8 @@\n # Copyright(c) 2018 Luca Boccassi <bluca@debian.org>\n \n if not is_linux\n- build = false\n+\tbuild = false\n+\treason = 'only supported on linux'\n endif\n sources = files('vdev_netvsc.c')\n \ndiff --git a/drivers/net/vhost/meson.build b/drivers/net/vhost/meson.build\nindex 9b067c35e..9532a7605 100644\n--- a/drivers/net/vhost/meson.build\n+++ b/drivers/net/vhost/meson.build\n@@ -2,6 +2,7 @@\n # Copyright(c) 2018 Intel Corporation\n \n build = dpdk_conf.has('RTE_LIBRTE_VHOST')\n+reason = 'missing dependency, DPDK vhost library'\n version = 2\n sources = files('rte_eth_vhost.c')\n install_headers('rte_eth_vhost.h')\n", "prefixes": [ "09/10" ] }