Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54432/?format=api
{ "id": 54432, "url": "http://patches.dpdk.org/api/patches/54432/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190605180948.22414-9-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190605180948.22414-9-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190605180948.22414-9-stephen@networkplumber.org", "date": "2019-06-05T18:09:48", "name": "[v4,8/8] app/testpmd: use rte_ether_unformat_addr", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e098ba00637372291cf8f513fd649d320b590025", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190605180948.22414-9-stephen@networkplumber.org/mbox/", "series": [ { "id": 4912, "url": "http://patches.dpdk.org/api/series/4912/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4912", "date": "2019-06-05T18:09:40", "name": "net/ether: enhancements and optimizations", "version": 4, "mbox": "http://patches.dpdk.org/series/4912/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54432/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54432/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4334D1B9EB;\n\tWed, 5 Jun 2019 20:10:09 +0200 (CEST)", "from mail-pl1-f196.google.com (mail-pl1-f196.google.com\n\t[209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 54E9D1B9BC\n\tfor <dev@dpdk.org>; Wed, 5 Jun 2019 20:10:03 +0200 (CEST)", "by mail-pl1-f196.google.com with SMTP id x7so8990388plr.12\n\tfor <dev@dpdk.org>; Wed, 05 Jun 2019 11:10:03 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ta7sm19081888pgj.42.2019.06.05.11.10.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 05 Jun 2019 11:10:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=xdUsjvA+XM/A8lvdK1H1mldU1CJ2JFzy3kElJGpilZc=;\n\tb=SbmtxByho++T/git7LJLpHg6h9B8iK+L82H87gk7dQfWcaXB5wQ+qskhl29I7tR/oI\n\tCyvjOMn3vJdjmu2+3M7+rBWZ1tJlZk2pf52idh44VNJwCQAIQh0nAS89crnPYgVFAs0j\n\t+4DGSeYDb0H416stwzeE6IF3+EyyYxJrdeA6ZuVvmXXaFjXLDif3dfQ9oeYDaaPqxEsz\n\tBaOAo+UCdNu+TjdQEP8CLv4s+zir3FbomXqQhGYvcTex83Yr7rGBs4kKlTjiX/3COgAQ\n\tbBL7BI+fPkls6S+239kTuD1Crgmlu5fIkpOcSLcSycqqb57NPa6WbUl8oyuZh04V36cu\n\tjeTQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=xdUsjvA+XM/A8lvdK1H1mldU1CJ2JFzy3kElJGpilZc=;\n\tb=XS+5cMWjNKJ4dTML8tIzOUYoXaSXCWI9m8rsHcbFzhzb5h6MWNDvvH/5fK66WDexd5\n\tI8wsbeDDeLxhKVWrq17J4u9yXLRtYxo0Yb60KBSi6gA20Ph/GKR5iTA05wqb7z9nlXwU\n\tN9vyWIEtSvL1a7R4cAXybjtVwjlQ/WRio5uFBwc7UFN9lESVPJv3X0Jas9pD5TVLjbVn\n\trXrMVkLfMMUN/sWApWjW98KdtPe21ZmGLSiNm0xPErWWUdqTgi5b4jGxeL5HD7yKfR8Z\n\tHsbUnBMZ5IbQDEy+9HuYAsKiWrLxV5ya1pRbWjyyspTiC7BSrwgb6ZzDvXuH04Lv86bY\n\tE08g==", "X-Gm-Message-State": "APjAAAXeOQRZRqESFNqE2TpiiFk8qBRhXAUwJGA/vBO+KJShETEprcTN\n\t9mQ+elb3844WFWZdQDmsaWwMcXMTF/4=", "X-Google-Smtp-Source": "APXvYqwjwmQN9Bf44C2eWcZEhMFpvzQAMnwe0nnFC592qnrr9C1X3lwYnIuHnxS339yPX1JpvvI4GQ==", "X-Received": "by 2002:a17:902:20ec:: with SMTP id\n\tv41mr43147565plg.142.1559758202204; \n\tWed, 05 Jun 2019 11:10:02 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 5 Jun 2019 11:09:48 -0700", "Message-Id": "<20190605180948.22414-9-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190605180948.22414-1-stephen@networkplumber.org>", "References": "<20190516180427.17270-1-stephen@networkplumber.org>\n\t<20190605180948.22414-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 8/8] app/testpmd: use rte_ether_unformat_addr", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The cmdline_parse_ether_addr does not need to be used everywhere\nin testpmd. Can use rte_ether_unformat_addr instead.\nAs an added bonus it eliminates some code for copying.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test-pmd/cmdline_flow.c | 5 ++---\n app/test-pmd/config.c | 10 +++-------\n app/test-pmd/parameters.c | 15 +++------------\n 3 files changed, 8 insertions(+), 22 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 201bd9de56e0..2b02ca29b7ac 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -18,7 +18,6 @@\n #include <rte_ethdev.h>\n #include <rte_byteorder.h>\n #include <cmdline_parse.h>\n-#include <cmdline_parse_etheraddr.h>\n #include <rte_flow.h>\n \n #include \"testpmd.h\"\n@@ -4627,8 +4626,8 @@ parse_mac_addr(struct context *ctx, const struct token *token,\n \t/* Only network endian is supported. */\n \tif (!arg->hton)\n \t\tgoto error;\n-\tret = cmdline_parse_etheraddr(NULL, str, &tmp, size);\n-\tif (ret < 0 || (unsigned int)ret != len)\n+\tret = rte_ether_unformat_addr(str, &tmp);\n+\tif (ret < 0)\n \t\tgoto error;\n \tif (!ctx->object)\n \t\treturn len;\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex ab458c8d2837..1d804705d96c 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -49,7 +49,6 @@\n #include <rte_pmd_bnxt.h>\n #endif\n #include <rte_gro.h>\n-#include <cmdline_parse_etheraddr.h>\n #include <rte_config.h>\n \n #include \"testpmd.h\"\n@@ -2278,19 +2277,16 @@ pkt_fwd_config_display(struct fwd_config *cfg)\n void\n set_fwd_eth_peer(portid_t port_id, char *peer_addr)\n {\n-\tuint8_t c, new_peer_addr[6];\n+\tstruct rte_ether_addr new_peer_addr;\n \tif (!rte_eth_dev_is_valid_port(port_id)) {\n \t\tprintf(\"Error: Invalid port number %i\\n\", port_id);\n \t\treturn;\n \t}\n-\tif (cmdline_parse_etheraddr(NULL, peer_addr, &new_peer_addr,\n-\t\t\t\t\tsizeof(new_peer_addr)) < 0) {\n+\tif (rte_ether_unformat_addr(peer_addr, &new_peer_addr) < 0) {\n \t\tprintf(\"Error: Invalid ethernet address: %s\\n\", peer_addr);\n \t\treturn;\n \t}\n-\tfor (c = 0; c < 6; c++)\n-\t\tpeer_eth_addrs[port_id].addr_bytes[c] =\n-\t\t\tnew_peer_addr[c];\n+\tpeer_eth_addrs[port_id] = new_peer_addr;\n }\n \n int\ndiff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c\nindex 245b610641ee..975a97807009 100644\n--- a/app/test-pmd/parameters.c\n+++ b/app/test-pmd/parameters.c\n@@ -39,10 +39,6 @@\n #include <rte_ether.h>\n #include <rte_ethdev.h>\n #include <rte_string_fns.h>\n-#ifdef RTE_LIBRTE_CMDLINE\n-#include <cmdline_parse.h>\n-#include <cmdline_parse_etheraddr.h>\n-#endif\n #ifdef RTE_LIBRTE_PMD_BOND\n #include <rte_eth_bond.h>\n #endif\n@@ -227,8 +223,7 @@ init_peer_eth_addrs(char *config_filename)\n \t\tif (fgets(buf, sizeof(buf), config_file) == NULL)\n \t\t\tbreak;\n \n-\t\tif (cmdline_parse_etheraddr(NULL, buf, &peer_eth_addrs[i],\n-\t\t\t\tsizeof(peer_eth_addrs[i])) < 0) {\n+\t\tif (rte_ether_unformat_addr(buf, &peer_eth_addrs[i]) < 0) {\n \t\t\tprintf(\"Bad MAC address format on line %d\\n\", i+1);\n \t\t\tfclose(config_file);\n \t\t\treturn -1;\n@@ -727,7 +722,6 @@ launch_args_parse(int argc, char** argv)\n \t\t\t}\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"eth-peer\")) {\n \t\t\t\tchar *port_end;\n-\t\t\t\tuint8_t c, peer_addr[6];\n \n \t\t\t\terrno = 0;\n \t\t\t\tn = strtoul(optarg, &port_end, 10);\n@@ -739,14 +733,11 @@ launch_args_parse(int argc, char** argv)\n \t\t\t\t\t\t \"eth-peer: port %d >= RTE_MAX_ETHPORTS(%d)\\n\",\n \t\t\t\t\t\t n, RTE_MAX_ETHPORTS);\n \n-\t\t\t\tif (cmdline_parse_etheraddr(NULL, port_end,\n-\t\t\t\t\t\t&peer_addr, sizeof(peer_addr)) < 0)\n+\t\t\t\tif (rte_ether_unformat_addr(port_end,\n+\t\t\t\t\t\t\t &peer_eth_addrs[n]) < 0)\n \t\t\t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t\t\t \"Invalid ethernet address: %s\\n\",\n \t\t\t\t\t\t port_end);\n-\t\t\t\tfor (c = 0; c < 6; c++)\n-\t\t\t\t\tpeer_eth_addrs[n].addr_bytes[c] =\n-\t\t\t\t\t\tpeer_addr[c];\n \t\t\t\tnb_peer_eth_addrs++;\n \t\t\t}\n #endif\n", "prefixes": [ "v4", "8/8" ] }