Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54431/?format=api
{ "id": 54431, "url": "http://patches.dpdk.org/api/patches/54431/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190605180948.22414-8-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190605180948.22414-8-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190605180948.22414-8-stephen@networkplumber.org", "date": "2019-06-05T18:09:47", "name": "[v4,7/8] net/bonding: use rte_ether_unformat_addr rather than cmdline_parse", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "850b54f9aa7f6ab3a74ca227887395c9b630f18a", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190605180948.22414-8-stephen@networkplumber.org/mbox/", "series": [ { "id": 4912, "url": "http://patches.dpdk.org/api/series/4912/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4912", "date": "2019-06-05T18:09:40", "name": "net/ether: enhancements and optimizations", "version": 4, "mbox": "http://patches.dpdk.org/series/4912/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54431/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54431/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B553F1B9E5;\n\tWed, 5 Jun 2019 20:10:07 +0200 (CEST)", "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n\t[209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 0E5181B9C8\n\tfor <dev@dpdk.org>; Wed, 5 Jun 2019 20:10:02 +0200 (CEST)", "by mail-pl1-f194.google.com with SMTP id g9so9978245plm.6\n\tfor <dev@dpdk.org>; Wed, 05 Jun 2019 11:10:01 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ta7sm19081888pgj.42.2019.06.05.11.09.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 05 Jun 2019 11:09:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=;\n\tb=ogndnz/zRfgrUUIHW0MA9aQ9C17XBMreWgHh/U/vmnkvk7BrvAwK6/dULtuYA21zzN\n\tmng8gZsPkzxzYX2X8X+cJpTCzANGPp4TdBEmQUmdnoynyK1jVQH6Rve3GwGMTS9TauF6\n\t+Tw4e7+Xazxq7Ebz6TUjIJeuT/G0brKkZ6eneh1aVSOMi8noi3pfQBJEA0c/RYY6+vFc\n\t6LZCm2Muf6otC3oPVPxzWvmAIOx9RCOd6Tbwg6ofKjqGUbl5VkrLP1pwEpAmfi64fauP\n\tFYqpfJpiRquz+klNGttcMkJmUg9UeP5BIXI+Se0nwCxy6496BOY32uTSvoFoyK60iE4O\n\td8uw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=;\n\tb=og2oy4H6b/TzebMIUwLXQznizmOMeCs/Astzjfd/4/hqE1wItB35Py7o8RYCa5EvEo\n\tNPD7JGiOJeNrBZITlz1aedhgV3REx34VTW74/a3WRtqrS+8eSHUf4m+zpVJtyo2soMTB\n\tmmhFYDBZTZ5hp2jJ+bTrdMBCEYoCREAzwbD2AonOdYm+A6X6X3x9ZjDUqtjJER//fmNi\n\tMFZ/UxNmhoOwAmzAmbinHPNWTSxyenhJnwtU6cmmApP3YUmRqQhTyWz+Kd8O90/kpF/+\n\tKz7RHKaszOp2ySG6uhRCzO+7MsYNuyPLAJJQJxR2Qv1JdlMIMZ7vH4YsyAiS9DEe+CU/\n\taGWQ==", "X-Gm-Message-State": "APjAAAWL+DRd3KMgPrMMHg+0oNex+Rh+dkrll67FR7lP6ZgKux7uUe+o\n\t262Hfdae3oO03XX1KPkV8cWRdV9OKBw=", "X-Google-Smtp-Source": "APXvYqy2PqdtlYLod5xjnb7ToBAI5fUc8cCdp81UVksD/RDMx3fhcwySIPQJhb50wXlZc+Ctf/iT7Q==", "X-Received": "by 2002:a17:902:aa0a:: with SMTP id\n\tbe10mr38353191plb.27.1559758200962; \n\tWed, 05 Jun 2019 11:10:00 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 5 Jun 2019 11:09:47 -0700", "Message-Id": "<20190605180948.22414-8-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190605180948.22414-1-stephen@networkplumber.org>", "References": "<20190516180427.17270-1-stephen@networkplumber.org>\n\t<20190605180948.22414-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 7/8] net/bonding: use rte_ether_unformat_addr\n\trather than cmdline_parse", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The cmdline library used to be the only way to parse a\nmac address. Now there is rte_ether_unformat_addr.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/bonding/Makefile | 2 +-\n drivers/net/bonding/meson.build | 2 +-\n drivers/net/bonding/rte_eth_bond_args.c | 6 +-----\n 3 files changed, 3 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile\nindex 1893e3cad313..26c1782554cd 100644\n--- a/drivers/net/bonding/Makefile\n+++ b/drivers/net/bonding/Makefile\n@@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring\n-LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_cmdline\n+LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs\n LDLIBS += -lrte_pci -lrte_bus_pci\n LDLIBS += -lrte_bus_vdev\n \ndiff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build\nindex 00374edb2a9d..6267210adf5f 100644\n--- a/drivers/net/bonding/meson.build\n+++ b/drivers/net/bonding/meson.build\n@@ -8,6 +8,6 @@ sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c', 'rte_eth_bond_flow.c\n \t'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c')\n \n deps += 'sched' # needed for rte_bitmap.h\n-deps += ['ip_frag', 'cmdline']\n+deps += ['ip_frag']\n \n install_headers('rte_eth_bond.h', 'rte_eth_bond_8023ad.h')\ndiff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c\nindex 01bbb06c1a84..936440fb8491 100644\n--- a/drivers/net/bonding/rte_eth_bond_args.c\n+++ b/drivers/net/bonding/rte_eth_bond_args.c\n@@ -7,9 +7,6 @@\n #include <rte_bus_pci.h>\n #include <rte_kvargs.h>\n \n-#include <cmdline_parse.h>\n-#include <cmdline_parse_etheraddr.h>\n-\n #include \"rte_eth_bond.h\"\n #include \"rte_eth_bond_private.h\"\n \n@@ -281,8 +278,7 @@ bond_ethdev_parse_bond_mac_addr_kvarg(const char *key __rte_unused,\n \t\treturn -1;\n \n \t/* Parse MAC */\n-\treturn cmdline_parse_etheraddr(NULL, value, extra_args,\n-\t\tsizeof(struct rte_ether_addr));\n+\treturn rte_ether_unformat_addr(value, extra_args);\n }\n \n int\n", "prefixes": [ "v4", "7/8" ] }