Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54428/?format=api
{ "id": 54428, "url": "http://patches.dpdk.org/api/patches/54428/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190605180948.22414-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190605180948.22414-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190605180948.22414-5-stephen@networkplumber.org", "date": "2019-06-05T18:09:44", "name": "[v4,4/8] net/ether: use bitops to speedup comparison", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3a623087517713e32761872c2027bce939269b88", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190605180948.22414-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 4912, "url": "http://patches.dpdk.org/api/series/4912/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4912", "date": "2019-06-05T18:09:40", "name": "net/ether: enhancements and optimizations", "version": 4, "mbox": "http://patches.dpdk.org/series/4912/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54428/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54428/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 341BD1B9CC;\n\tWed, 5 Jun 2019 20:10:02 +0200 (CEST)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 89A861B9B1\n\tfor <dev@dpdk.org>; Wed, 5 Jun 2019 20:09:57 +0200 (CEST)", "by mail-pg1-f196.google.com with SMTP id 196so12838215pgc.6\n\tfor <dev@dpdk.org>; Wed, 05 Jun 2019 11:09:57 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ta7sm19081888pgj.42.2019.06.05.11.09.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 05 Jun 2019 11:09:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=8fFcBaPZKjQQPsKQQeFeSAG72mshjjR9mGZfTCJM/8s=;\n\tb=LgWCBk+CmM8yaiNrkPlToltHnZRe7RVYPwzwwksgZ0QrygDFw1VhmUS9jf/qx8Hnqh\n\tVWSPw5PYTxk+UyL8TwKlYQiAHbe2yT8VqSntM0ECuM1IeZUxNnXXC71StU6g4O9CwTVv\n\tanLBGHF5+2F1A+/69ccROmV149kiNd+KUWkIhifwF8BMUmsqvcTHYilGwkqNXaBwgKm6\n\tLGRgI7fUCujNS91LMJejNb4uB7+KQidakVCnftzXFinpxe94ygPacAYirLxwPs6zP8fc\n\tKYj9S2EJB4q/g1gxsviOUt/onozLWvpQS3PZBGUyTa6LUiU6LFXoe3G4nMppVUABPquD\n\ta1Sw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=8fFcBaPZKjQQPsKQQeFeSAG72mshjjR9mGZfTCJM/8s=;\n\tb=Gi1KFwXOp+o+BAOFSWNbdlc6ebE+V6n0qbO7yPeH2IyeUmBb/Qd2gkC5zKqImfVpmw\n\ttDzdhQTmZ/Uj4pqxOBumNBN1BLlbBPdLeML3K0Te+bKkVEkFmiN5S4YNNoBmnSDcKPBx\n\txb5u3aFK3Z8Y71kYtGlKQyKmPMp9Lt98GTnau+7Brr4WqeGcFhZrG/S9hfyAH2RXkOVp\n\tfeJFp8apu+pE/j0Gvlhr3/o5LiB9ZwJ6g/idJvRn4nJ01NMW8FvtPKlpN3lCZPjJ5K8l\n\txH6fZTi9Y69ynWTPYKdk4zY6j+Zmk80TdEzZ2UHFBQKUz1KRdDxFORIIsXDbVryPrUN6\n\tnL1A==", "X-Gm-Message-State": "APjAAAUkuAP8Wr0MsMWprYPd5bpYLUADqNOd/wepHdxSpcqYOeLYFdW8\n\tbJOHOdxrURKtWk8PjemMW70sxat0/O0=", "X-Google-Smtp-Source": "APXvYqybI2/9FPZMXyLAwScy6moHPB9T6Ha4YI/P+5mGCNaQpQ+B9Qn5twjWn3c5u3j7oIJ4YuL6hw==", "X-Received": "by 2002:a62:6454:: with SMTP id\n\ty81mr10566137pfb.13.1559758196517; \n\tWed, 05 Jun 2019 11:09:56 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tAndrew Rybchenko <arybchenko@solarflare.com>", "Date": "Wed, 5 Jun 2019 11:09:44 -0700", "Message-Id": "<20190605180948.22414-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190605180948.22414-1-stephen@networkplumber.org>", "References": "<20190516180427.17270-1-stephen@networkplumber.org>\n\t<20190605180948.22414-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 4/8] net/ether: use bitops to speedup\n\tcomparison", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Using bit operations like or and xor is faster than a loop\non all architectures. Really just explicit unrolling.\n\nSimilar cast to uint16 unaligned is already done in\nother functions here.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nReviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n lib/librte_net/rte_ether.h | 17 +++++++----------\n 1 file changed, 7 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h\nindex 8edc7e217b25..feb35a33c94b 100644\n--- a/lib/librte_net/rte_ether.h\n+++ b/lib/librte_net/rte_ether.h\n@@ -81,11 +81,10 @@ struct rte_ether_addr {\n static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1,\n \t\t\t\t const struct rte_ether_addr *ea2)\n {\n-\tint i;\n-\tfor (i = 0; i < RTE_ETHER_ADDR_LEN; i++)\n-\t\tif (ea1->addr_bytes[i] != ea2->addr_bytes[i])\n-\t\t\treturn 0;\n-\treturn 1;\n+\tconst unaligned_uint16_t *w1 = (const uint16_t *)ea1;\n+\tconst unaligned_uint16_t *w2 = (const uint16_t *)ea2;\n+\n+\treturn ((w1[0] ^ w2[0]) | (w1[1] ^ w2[1]) | (w1[2] ^ w2[2])) == 0;\n }\n \n /**\n@@ -100,11 +99,9 @@ static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1,\n */\n static inline int rte_is_zero_ether_addr(const struct rte_ether_addr *ea)\n {\n-\tint i;\n-\tfor (i = 0; i < RTE_ETHER_ADDR_LEN; i++)\n-\t\tif (ea->addr_bytes[i] != 0x00)\n-\t\t\treturn 0;\n-\treturn 1;\n+\tconst unaligned_uint16_t *w = (const uint16_t *)ea;\n+\n+\treturn (w[0] | w[1] | w[2]) == 0;\n }\n \n /**\n", "prefixes": [ "v4", "4/8" ] }