Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54406/?format=api
{ "id": 54406, "url": "http://patches.dpdk.org/api/patches/54406/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190605100039.18029-4-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190605100039.18029-4-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190605100039.18029-4-maxime.coquelin@redhat.com", "date": "2019-06-05T10:00:38", "name": "[v3,3/4] net/virtio: fix segment data len in mergeable packed Rx path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bbc7b8ccb824d1b67a359f25673e01e010ebf270", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190605100039.18029-4-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 4904, "url": "http://patches.dpdk.org/api/series/4904/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4904", "date": "2019-06-05T10:00:35", "name": "et/virtio: Fix packet segmentation bug", "version": 3, "mbox": "http://patches.dpdk.org/series/4904/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54406/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54406/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EE8521BACB;\n\tWed, 5 Jun 2019 12:01:12 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 0F6491BA64;\n\tWed, 5 Jun 2019 12:01:09 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8272DC18B2CB;\n\tWed, 5 Jun 2019 10:01:06 +0000 (UTC)", "from localhost.localdomain (ovpn-112-53.ams2.redhat.com\n\t[10.36.112.53])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A116E1001E63;\n\tWed, 5 Jun 2019 10:01:04 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, ybrustin@cisco.com, tiwei.bie@intel.com,\n\tjfreimann@redhat.com, david.marchand@redhat.com", "Cc": "stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Wed, 5 Jun 2019 12:00:38 +0200", "Message-Id": "<20190605100039.18029-4-maxime.coquelin@redhat.com>", "In-Reply-To": "<20190605100039.18029-1-maxime.coquelin@redhat.com>", "References": "<20190605100039.18029-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]); Wed, 05 Jun 2019 10:01:08 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v3 3/4] net/virtio: fix segment data len in\n\tmergeable packed Rx path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Head segment data_len field is wrongly summed with the length\nof all the segments of the chain, whereas it should be the\nlength of of the first segment only.\n\nFixes: a76290c8f1cf (\"net/virtio: implement Rx path for packed queues\")\nCc: stable@dpdk.org\n\nReported-by: Yaroslav Brustinov <ybrustin@cisco.com>\nReviewed-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/virtio/virtio_rxtx.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex acee4fcc07..358cc86627 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -1875,7 +1875,6 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,\n \t\t\trxm->data_len = (uint16_t)(len[i]);\n \n \t\t\trx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);\n-\t\t\trx_pkts[nb_rx]->data_len += (uint16_t)(len[i]);\n \n \t\t\tif (prev)\n \t\t\t\tprev->next = rxm;\n@@ -1912,7 +1911,6 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,\n \t\t\t\tprev->next = rxm;\n \t\t\t\tprev = rxm;\n \t\t\t\trx_pkts[nb_rx]->pkt_len += len[extra_idx];\n-\t\t\t\trx_pkts[nb_rx]->data_len += len[extra_idx];\n \t\t\t\textra_idx += 1;\n \t\t\t}\n \t\t\tseg_res -= rcv_cnt;\n", "prefixes": [ "v3", "3/4" ] }