Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54399/?format=api
http://patches.dpdk.org/api/patches/54399/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190605094342.17563-3-tiwei.bie@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190605094342.17563-3-tiwei.bie@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190605094342.17563-3-tiwei.bie@intel.com", "date": "2019-06-05T09:43:39", "name": "[2/5] net/virtio: unmap port IO for legacy device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "aadd5ec1264ee1d495abd914a8b00bae46051bef", "submitter": { "id": 617, "url": "http://patches.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190605094342.17563-3-tiwei.bie@intel.com/mbox/", "series": [ { "id": 4903, "url": "http://patches.dpdk.org/api/series/4903/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4903", "date": "2019-06-05T09:43:37", "name": "virtio: release port upon close", "version": 1, "mbox": "http://patches.dpdk.org/series/4903/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54399/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54399/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 797EE1BACC;\n\tWed, 5 Jun 2019 11:45:08 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 2DD621B9CE;\n\tWed, 5 Jun 2019 11:45:03 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jun 2019 02:45:02 -0700", "from npg-dpdk-virtio-tbie-2.sh.intel.com ([10.67.104.151])\n\tby orsmga006.jf.intel.com with ESMTP; 05 Jun 2019 02:45:01 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tzhihong.wang@intel.com,\n\tdev@dpdk.org", "Cc": "stable@dpdk.org", "Date": "Wed, 5 Jun 2019 17:43:39 +0800", "Message-Id": "<20190605094342.17563-3-tiwei.bie@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190605094342.17563-1-tiwei.bie@intel.com>", "References": "<20190605094342.17563-1-tiwei.bie@intel.com>", "Subject": "[dpdk-dev] [PATCH 2/5] net/virtio: unmap port IO for legacy device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For legacy devices, we should also unmap the port IO\nresource on device removal.\n\nFixes: b8f04520ad71 (\"virtio: use PCI ioport API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Tiwei Bie <tiwei.bie@intel.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex df3a218a8..a2cedcc87 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1876,6 +1876,8 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)\n static int\n eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)\n {\n+\tstruct virtio_hw *hw = eth_dev->data->dev_private;\n+\n \tPMD_INIT_FUNC_TRACE();\n \n \tif (rte_eal_process_type() == RTE_PROC_SECONDARY)\n@@ -1888,8 +1890,11 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)\n \teth_dev->tx_pkt_burst = NULL;\n \teth_dev->rx_pkt_burst = NULL;\n \n-\tif (eth_dev->device)\n+\tif (eth_dev->device) {\n \t\trte_pci_unmap_device(RTE_ETH_DEV_TO_PCI(eth_dev));\n+\t\tif (!hw->modern)\n+\t\t\trte_pci_ioport_unmap(VTPCI_IO(hw));\n+\t}\n \n \tPMD_INIT_LOG(DEBUG, \"dev_uninit completed\");\n \n", "prefixes": [ "2/5" ] }{ "id": 54399, "url": "