Patch Comment List
List patch comments
GET /api/patches/54382/comments/?format=api
[ { "id": 96732, "web_url": "http://patches.dpdk.org/comment/96732/", "msgid": "<CAJFAV8wWAyVPudFP1DRMMewsjjKXLc4cS7d--CFYgsHg5MFoTw@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8wWAyVPudFP1DRMMewsjjKXLc4cS7d--CFYgsHg5MFoTw@mail.gmail.com", "date": "2019-06-05T09:35:04", "subject": "Re: [dpdk-dev] [PATCH v2 4/4] net/virtio: remove useless pointers\n\tchecks", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Wed, Jun 5, 2019 at 10:11 AM Maxime Coquelin <maxime.coquelin@redhat.com>\nwrote:\n\n> This patch removes uses checks on 'prev' pointer, as it\n> is always set before with a valid value.\n>\n> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n> ---\n> drivers/net/virtio/virtio_rxtx.c | 15 ++++-----------\n> 1 file changed, 4 insertions(+), 11 deletions(-)\n>\n> diff --git a/drivers/net/virtio/virtio_rxtx.c\n> b/drivers/net/virtio/virtio_rxtx.c\n> index 33dbc78906..fabd2e31d5 100644\n> --- a/drivers/net/virtio/virtio_rxtx.c\n> +++ b/drivers/net/virtio/virtio_rxtx.c\n> @@ -1517,9 +1517,7 @@ virtio_recv_pkts_inorder(void *rx_queue,\n>\n> rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);\n>\n> - if (prev)\n> - prev->next = rxm;\n> -\n> + prev->next = rxm;\n> prev = rxm;\n> seg_res -= 1;\n> }\n> @@ -1703,9 +1701,7 @@ virtio_recv_mergeable_pkts(void *rx_queue,\n> rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);\n> rx_pkts[nb_rx]->data_len += (uint16_t)(len[i]);\n>\n> - if (prev)\n> - prev->next = rxm;\n> -\n> + prev->next = rxm;\n> prev = rxm;\n> seg_res -= 1;\n> }\n> @@ -1879,9 +1875,7 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,\n> rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);\n> rx_pkts[nb_rx]->data_len += (uint16_t)(len[i]);\n>\n> - if (prev)\n> - prev->next = rxm;\n> -\n> + prev->next = rxm;\n> prev = rxm;\n> seg_res -= 1;\n> }\n> @@ -1924,8 +1918,7 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,\n> } else {\n> PMD_RX_LOG(ERR,\n> \"No enough segments for packet.\");\n> - if (prev)\n> - virtio_discard_rxbuf(vq, prev);\n> + virtio_discard_rxbuf(vq, prev);\n> rxvq->stats.errors++;\n> break;\n> }\n> --\n> 2.21.0\n>\n>\nReviewed-by: David Marchand <david.marchand@redhat.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8D9681BA9A;\n\tWed, 5 Jun 2019 11:35:16 +0200 (CEST)", "from mail-vs1-f68.google.com (mail-vs1-f68.google.com\n\t[209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 8269E1BA90\n\tfor <dev@dpdk.org>; Wed, 5 Jun 2019 11:35:15 +0200 (CEST)", "by mail-vs1-f68.google.com with SMTP id c24so15314340vsp.7\n\tfor <dev@dpdk.org>; Wed, 05 Jun 2019 02:35:15 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Zh7X2klEYoeLEapZJ0d7zgxra+jKeWiNkWLsmJCRn9Q=;\n\tb=WGoxMadqUOwUjfYfKli9lCePYJ968C+ELvjlCe4+TY8Wdq/MEhf/il9hiKBXbgSpCh\n\toQ2qM5efi3p7SmbmnQB1/wdzOCJQvZtNxOSGR8DWxSWCircxber6hE3PRPyQa5QDQB7d\n\t9Cn+Y9f1yX1Z9FSnlW8mtcovFIhbSWWPQhXjTj/an61JnCF1NeZEG26qHgJLq2hWMJ2D\n\tn9mR/BiGxq9gHFHNQ1PVjEBSUkRNAGML2GW0/NCxgMQ67DlmvRuRJyNi/5TmLrpS5daM\n\t6hCIrmq7sa/Hd8h74p3fCdZnsrJPA97PT+0PAJvV5KV9Ehp00SZq1csDTamj/C9mB+Eb\n\tvxcw==", "X-Gm-Message-State": "APjAAAU0I9vGSTGXsCKqEgt0pe0v3Wbe3H9+kkT9JuNON3eize33FjLN\n\tUsirHcjgAWWHyU8SvASyN21G2qHVkqhiSmTI4DdlxQ==", "X-Google-Smtp-Source": "APXvYqyUK9vpZb9nCMAF7p8ZI/J+FPteTGORR0o87adBrBHh0hittGJK+sWNr+HGTTiSORBuUxYZEo8k6XX0KAQGugU=", "X-Received": "by 2002:a67:e9ca:: with SMTP id\n\tq10mr8403383vso.105.1559727314969; \n\tWed, 05 Jun 2019 02:35:14 -0700 (PDT)", "MIME-Version": "1.0", "References": "<20190605081005.15716-1-maxime.coquelin@redhat.com>\n\t<20190605081005.15716-5-maxime.coquelin@redhat.com>", "In-Reply-To": "<20190605081005.15716-5-maxime.coquelin@redhat.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Wed, 5 Jun 2019 11:35:04 +0200", "Message-ID": "<CAJFAV8wWAyVPudFP1DRMMewsjjKXLc4cS7d--CFYgsHg5MFoTw@mail.gmail.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Cc": "dev <dev@dpdk.org>, ybrustin@cisco.com, Tiwei Bie <tiwei.bie@intel.com>, \n\tJens Freimann <jfreimann@redhat.com>, dpdk stable <stable@dpdk.org>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [PATCH v2 4/4] net/virtio: remove useless pointers\n\tchecks", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]