Patch Comment List
List patch comments
GET /api/patches/54381/comments/?format=api
[ { "id": 96731, "web_url": "http://patches.dpdk.org/comment/96731/", "msgid": "<CAJFAV8w+5KC-L=fAuSWgcYipvNrCEMS6Qoy5ur8zTOvMw8M6FA@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8w+5KC-L=fAuSWgcYipvNrCEMS6Qoy5ur8zTOvMw8M6FA@mail.gmail.com", "date": "2019-06-05T09:34:59", "subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH v2 3/4] net/virtio: fix segment\n\tdata len in mergeable packed Rx path", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Wed, Jun 5, 2019 at 10:11 AM Maxime Coquelin <maxime.coquelin@redhat.com>\nwrote:\n\n> Head segment data_len field is wrongly summed with the length\n> of all the segments of the chain, whereas it should be the\n> length of of the first segment only.\n>\n> Fixes: a76290c8f1cf (\"net/virtio: implement Rx path for packed queues\")\n> Cc: stable@dpdk.org\n>\n> Reported-by: Yaroslav Brustinov <ybrustin@cisco.com>\n> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n> ---\n> drivers/net/virtio/virtio_rxtx.c | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/drivers/net/virtio/virtio_rxtx.c\n> b/drivers/net/virtio/virtio_rxtx.c\n> index 9469ecb743..33dbc78906 100644\n> --- a/drivers/net/virtio/virtio_rxtx.c\n> +++ b/drivers/net/virtio/virtio_rxtx.c\n> @@ -1914,7 +1914,6 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,\n> prev->next = rxm;\n> prev = rxm;\n> rx_pkts[nb_rx]->pkt_len += len[extra_idx];\n> - rx_pkts[nb_rx]->data_len += len[extra_idx];\n> extra_idx += 1;\n> }\n> seg_res -= rcv_cnt;\n> --\n> 2.21.0\n>\n\nAnd another one, line 1880 :-)\nReviewed-by: David Marchand <david.marchand@redhat.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C630E1BA57;\n\tWed, 5 Jun 2019 11:35:11 +0200 (CEST)", "from mail-vs1-f67.google.com (mail-vs1-f67.google.com\n\t[209.85.217.67]) by dpdk.org (Postfix) with ESMTP id 96A271B9E1\n\tfor <dev@dpdk.org>; Wed, 5 Jun 2019 11:35:10 +0200 (CEST)", "by mail-vs1-f67.google.com with SMTP id v129so6048540vsb.11\n\tfor <dev@dpdk.org>; Wed, 05 Jun 2019 02:35:10 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=apfZbWdcvK7YWdWP1lJ+yH+z0B4lY/Gzu0Wx9s7nDaQ=;\n\tb=O7m8zwvEXszkgB9Vy4SwMZBRn/gesthDSXGqTcVxqALB8zdhrXF5VpTV4aQ20hHurI\n\t+NpwkbWLO36bAhrMMaQ4wWY9qYpdQ8JoWrhIPi/MgZ4+Egio8pv03GcvEGehtUmo4POQ\n\ta42Wxt8TT3BljLtAyT4Xr4uhzTsos5GzEEQlEcrg+pw1ibyGzt/U/yHhCktF8C09xc9O\n\tmgvgXA8pGvPa2xtXiNLW/1opbCDpWWfSWmQvEer7VqQ7ZKnbOLuR2qcBzEwspe25nA1w\n\tbRmmSszOf/EHFW75KcmP+tmYedtfgvrwmfuJvEscEdLJBkorzufsrwLq3FM+w4JWK05x\n\tn7UQ==", "X-Gm-Message-State": "APjAAAUvllM3fB34iaQBfHDBskTzNaGYHCtA0W4j1O+ok5gFzItOLJ1L\n\tjVyS/bHbIMuba5HCBJ/Njq2Yf3/Ca4bmSX4E/a6Eo3If", "X-Google-Smtp-Source": "APXvYqxoUAYcfi8XenZWLdXdMg+8tB8lgk7fbXfcs0vwpCAloj85t0uWiNoaL3MpsW8pXRaROmOLXwROOtCPqGP+8go=", "X-Received": "by 2002:a67:f998:: with SMTP id\n\tb24mr9337168vsq.180.1559727310054; \n\tWed, 05 Jun 2019 02:35:10 -0700 (PDT)", "MIME-Version": "1.0", "References": "<20190605081005.15716-1-maxime.coquelin@redhat.com>\n\t<20190605081005.15716-4-maxime.coquelin@redhat.com>", "In-Reply-To": "<20190605081005.15716-4-maxime.coquelin@redhat.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Wed, 5 Jun 2019 11:34:59 +0200", "Message-ID": "<CAJFAV8w+5KC-L=fAuSWgcYipvNrCEMS6Qoy5ur8zTOvMw8M6FA@mail.gmail.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Cc": "dev <dev@dpdk.org>, ybrustin@cisco.com, Tiwei Bie <tiwei.bie@intel.com>, \n\tJens Freimann <jfreimann@redhat.com>, dpdk stable <stable@dpdk.org>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH v2 3/4] net/virtio: fix segment\n\tdata len in mergeable packed Rx path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]