List comments

GET /api/patches/54379/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 96729,
        "web_url": "http://patches.dpdk.org/comment/96729/",
        "msgid": "<CAJFAV8wHERqt0rmqx8CL+1BS9WE9OuH4UMbNmE1fFyOjyTEZdg@mail.gmail.com>",
        "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8wHERqt0rmqx8CL+1BS9WE9OuH4UMbNmE1fFyOjyTEZdg@mail.gmail.com",
        "date": "2019-06-05T09:34:45",
        "subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] net/virtio: fix\n\tsegmented packet issue in in-order Rx path",
        "submitter": {
            "id": 1173,
            "url": "http://patches.dpdk.org/api/people/1173/",
            "name": "David Marchand",
            "email": "david.marchand@redhat.com"
        },
        "content": "On Wed, Jun 5, 2019 at 10:10 AM Maxime Coquelin <maxime.coquelin@redhat.com>\nwrote:\n\n> After having dequeued a burst of descriptors, there may be a\n> need to dequeue a few more if the last packet was segmented\n> and not complete. When it happens, the extra segments were\n> not properly attached to the mbuf chain, and so were lost.\n>\n> Also, head segment data_len field is wrongly summed with\n> the length of all the segments of the chain.\n>\n> This patch fixes both the mbuf chaining and head segment's\n> data_len field.\n>\n> Fixes: e5f456a98d3c (\"net/virtio: support in-order Rx and Tx\")\n> Cc: stable@dpdk.org\n>\n> Reported-by: Yaroslav Brustinov <ybrustin@cisco.com>\n> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n> ---\n>  drivers/net/virtio/virtio_rxtx.c | 4 +---\n>  1 file changed, 1 insertion(+), 3 deletions(-)\n>\n> diff --git a/drivers/net/virtio/virtio_rxtx.c\n> b/drivers/net/virtio/virtio_rxtx.c\n> index 1de28540cd..6b3baf0423 100644\n> --- a/drivers/net/virtio/virtio_rxtx.c\n> +++ b/drivers/net/virtio/virtio_rxtx.c\n> @@ -1424,7 +1424,7 @@ virtio_recv_pkts_inorder(void *rx_queue,\n>         struct virtqueue *vq = rxvq->vq;\n>         struct virtio_hw *hw = vq->hw;\n>         struct rte_mbuf *rxm;\n> -       struct rte_mbuf *prev;\n> +       struct rte_mbuf *prev = NULL;\n>         uint16_t nb_used, num, nb_rx;\n>         uint32_t len[VIRTIO_MBUF_BURST_SZ];\n>         struct rte_mbuf *rcv_pkts[VIRTIO_MBUF_BURST_SZ];\n> @@ -1516,7 +1516,6 @@ virtio_recv_pkts_inorder(void *rx_queue,\n>                         rxm->data_len = (uint16_t)(len[i]);\n>\n>                         rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);\n> -                       rx_pkts[nb_rx]->data_len += (uint16_t)(len[i]);\n>\n>                         if (prev)\n>                                 prev->next = rxm;\n> @@ -1536,7 +1535,6 @@ virtio_recv_pkts_inorder(void *rx_queue,\n>                 uint16_t rcv_cnt = RTE_MIN((uint16_t)seg_res,\n>                                         VIRTIO_MBUF_BURST_SZ);\n>\n> -               prev = rcv_pkts[nb_rx];\n>                 if (likely(VIRTQUEUE_NUSED(vq) >= rcv_cnt)) {\n>                         virtio_rmb(hw->weak_barriers);\n>                         num = virtqueue_dequeue_rx_inorder(vq, rcv_pkts,\n> len,\n>\n\nI think you have missed another data_len update line 1554.\n\nReviewed-by: David Marchand <david.marchand@redhat.com>",
        "headers": {
            "Subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] net/virtio: fix\n\tsegmented packet issue in in-order Rx path",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-Original-To": "patchwork@dpdk.org",
            "Message-ID": "<CAJFAV8wHERqt0rmqx8CL+1BS9WE9OuH4UMbNmE1fFyOjyTEZdg@mail.gmail.com>",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "From": "David Marchand <david.marchand@redhat.com>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "X-BeenThere": "dev@dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=PIrqucR2f0QMzuLTguWL/znFtVPcsg3Js+O0ebswRRo=;\n\tb=NFx6NRy7S1mlhbyU0xktYAKacxvvzs/dMCtuQaqgSMn6lOm+JmuMK64iijnU9plJpW\n\tnnQecDUCFmwYC+GxfnZMsssShpRbLHN9udHuP7IZAU1d1tq/rHmyVuL+i9/H0q0zyeSD\n\tHhamSUUs1rfrXNIxsoi2Oayz42lrsZk5+zqaxy8QrGv5xTlqngxsezl3r4FtY3yunHk7\n\tPJi1vnL/KbdrsqwQlZQt2lGWsy4+JftQH9OpqV2z4upTMErH6LBv4KXUuJRtLK+bA2ZN\n\t7UZBMSV73GnO+nYT/q9qhmiENK5iN2vUlJmcjY+0Sjm/GIFEZp/c+gQGMl7JJqSSLjZm\n\ttS7A==",
            "X-Gm-Message-State": "APjAAAUa0r3Tlnlq+Co3XM2/BAq2vLNWDa9u8KPLtqJFRyKHP8V6hieP\n\t5oRvxICpAE4bOuI65t82TKW50qj3K3vdOWNMZwEAwA==",
            "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15",
            "Date": "Wed, 5 Jun 2019 11:34:45 +0200",
            "In-Reply-To": "<20190605081005.15716-2-maxime.coquelin@redhat.com>",
            "X-Mailman-Version": "2.1.15",
            "Errors-To": "dev-bounces@dpdk.org",
            "References": "<20190605081005.15716-1-maxime.coquelin@redhat.com>\n\t<20190605081005.15716-2-maxime.coquelin@redhat.com>",
            "Delivered-To": "patchwork@dpdk.org",
            "Precedence": "list",
            "Received": [
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2835F1B9F0;\n\tWed,  5 Jun 2019 11:34:58 +0200 (CEST)",
                "from mail-vs1-f65.google.com (mail-vs1-f65.google.com\n\t[209.85.217.65]) by dpdk.org (Postfix) with ESMTP id BFD3E1B9BD\n\tfor <dev@dpdk.org>; Wed,  5 Jun 2019 11:34:56 +0200 (CEST)",
                "by mail-vs1-f65.google.com with SMTP id b10so15313587vsp.5\n\tfor <dev@dpdk.org>; Wed, 05 Jun 2019 02:34:56 -0700 (PDT)"
            ],
            "MIME-Version": "1.0",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Content-Type": "text/plain; charset=\"UTF-8\"",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "X-Received": "by 2002:a67:1bc6:: with SMTP id\n\tb189mr4085976vsb.39.1559727296156; \n\tWed, 05 Jun 2019 02:34:56 -0700 (PDT)",
            "Cc": "dev <dev@dpdk.org>, ybrustin@cisco.com, Tiwei Bie <tiwei.bie@intel.com>, \n\tJens Freimann <jfreimann@redhat.com>, dpdk stable <stable@dpdk.org>",
            "To": "Maxime Coquelin <maxime.coquelin@redhat.com>",
            "X-Google-Smtp-Source": "APXvYqx0ZtbH7h7gWc1CKEGMlAV/sMdRnq+sQu2PUpcZkFYGb19w2EButm65nz8ThxGxnvVmGNzDRXez7/n6HLL3qZw="
        }
    }
]