Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54379/?format=api
{ "id": 54379, "url": "http://patches.dpdk.org/api/patches/54379/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190605081005.15716-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190605081005.15716-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190605081005.15716-2-maxime.coquelin@redhat.com", "date": "2019-06-05T08:10:02", "name": "[v2,1/4] net/virtio: fix segmented packet issue in in-order Rx path", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3d5ca65aa1219d667ca8511304abfd75ace6f75a", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190605081005.15716-2-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 4899, "url": "http://patches.dpdk.org/api/series/4899/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4899", "date": "2019-06-05T08:10:01", "name": "net/virtio: Fix packet segmentation bug", "version": 2, "mbox": "http://patches.dpdk.org/series/4899/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54379/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54379/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A88A91B9AC;\n\tWed, 5 Jun 2019 10:10:25 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 4AE6A1B96B;\n\tWed, 5 Jun 2019 10:10:21 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id AE1343001814;\n\tWed, 5 Jun 2019 08:10:20 +0000 (UTC)", "from localhost.localdomain (ovpn-112-53.ams2.redhat.com\n\t[10.36.112.53])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id EE5B45F7C0;\n\tWed, 5 Jun 2019 08:10:17 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, ybrustin@cisco.com, tiwei.bie@intel.com,\n\tjfreimann@redhat.com", "Cc": "stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Wed, 5 Jun 2019 10:10:02 +0200", "Message-Id": "<20190605081005.15716-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20190605081005.15716-1-maxime.coquelin@redhat.com>", "References": "<20190605081005.15716-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.40]); Wed, 05 Jun 2019 08:10:20 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v2 1/4] net/virtio: fix segmented packet issue in\n\tin-order Rx path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "After having dequeued a burst of descriptors, there may be a\nneed to dequeue a few more if the last packet was segmented\nand not complete. When it happens, the extra segments were\nnot properly attached to the mbuf chain, and so were lost.\n\nAlso, head segment data_len field is wrongly summed with\nthe length of all the segments of the chain.\n\nThis patch fixes both the mbuf chaining and head segment's\ndata_len field.\n\nFixes: e5f456a98d3c (\"net/virtio: support in-order Rx and Tx\")\nCc: stable@dpdk.org\n\nReported-by: Yaroslav Brustinov <ybrustin@cisco.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/virtio/virtio_rxtx.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex 1de28540cd..6b3baf0423 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -1424,7 +1424,7 @@ virtio_recv_pkts_inorder(void *rx_queue,\n \tstruct virtqueue *vq = rxvq->vq;\n \tstruct virtio_hw *hw = vq->hw;\n \tstruct rte_mbuf *rxm;\n-\tstruct rte_mbuf *prev;\n+\tstruct rte_mbuf *prev = NULL;\n \tuint16_t nb_used, num, nb_rx;\n \tuint32_t len[VIRTIO_MBUF_BURST_SZ];\n \tstruct rte_mbuf *rcv_pkts[VIRTIO_MBUF_BURST_SZ];\n@@ -1516,7 +1516,6 @@ virtio_recv_pkts_inorder(void *rx_queue,\n \t\t\trxm->data_len = (uint16_t)(len[i]);\n \n \t\t\trx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);\n-\t\t\trx_pkts[nb_rx]->data_len += (uint16_t)(len[i]);\n \n \t\t\tif (prev)\n \t\t\t\tprev->next = rxm;\n@@ -1536,7 +1535,6 @@ virtio_recv_pkts_inorder(void *rx_queue,\n \t\tuint16_t rcv_cnt = RTE_MIN((uint16_t)seg_res,\n \t\t\t\t\tVIRTIO_MBUF_BURST_SZ);\n \n-\t\tprev = rcv_pkts[nb_rx];\n \t\tif (likely(VIRTQUEUE_NUSED(vq) >= rcv_cnt)) {\n \t\t\tvirtio_rmb(hw->weak_barriers);\n \t\t\tnum = virtqueue_dequeue_rx_inorder(vq, rcv_pkts, len,\n", "prefixes": [ "v2", "1/4" ] }