Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54370/?format=api
{ "id": 54370, "url": "http://patches.dpdk.org/api/patches/54370/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190605010852.28395-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190605010852.28395-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190605010852.28395-4-stephen@networkplumber.org", "date": "2019-06-05T01:08:49", "name": "[v3,3/6] ethdev: use rte_eth_unformat_addr", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d64fadbb5984768e9cb40cf1d9bf6c0cdd4c8ba5", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190605010852.28395-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 4895, "url": "http://patches.dpdk.org/api/series/4895/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4895", "date": "2019-06-05T01:08:46", "name": "net/ether: improvements and optimizations", "version": 3, "mbox": "http://patches.dpdk.org/series/4895/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54370/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54370/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E9A021B999;\n\tWed, 5 Jun 2019 03:09:04 +0200 (CEST)", "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n\t[209.85.210.195]) by dpdk.org (Postfix) with ESMTP id F3FE51B95B\n\tfor <dev@dpdk.org>; Wed, 5 Jun 2019 03:08:59 +0200 (CEST)", "by mail-pf1-f195.google.com with SMTP id d126so13802747pfd.2\n\tfor <dev@dpdk.org>; Tue, 04 Jun 2019 18:08:59 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\t12sm8645936pfi.60.2019.06.04.18.08.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 04 Jun 2019 18:08:57 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=LJP5NUGKYyva7BnvgS/UxCqLM/1j8w47JpFJi1u1tNU=;\n\tb=eJBA10FX5uN+CivOAq/DyLrGndQVQwKDS62lLVaC20IvsIgKj6qn8lVglz9mhh6MIJ\n\t6Bimw3mEK8Wi5v7Mnm2ryvwtK5NH3Za5SbKSY0hzrFJ1IuSG2ahHOkLKq3FTR7ZEg7S2\n\tdjMSrEvhRObJjDzRtNPnHwpmOPIdbzS2j0BxCnz5afxmNYlPa0HNtSPSAEzP/yex1903\n\tGIAUQMoVtSojE0Q8CJlQH6HFs9g20rr6Th8o8gEfgq3rP7rxo8urby9iWdbjXzVvjWVI\n\tXJWF6NtM5lK89Hol3dy9uYV/OwqAGB1lO4tND91J84XPHupQefaFwO5bAj867t4CPB5y\n\tQzrw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=LJP5NUGKYyva7BnvgS/UxCqLM/1j8w47JpFJi1u1tNU=;\n\tb=Ksja19YNZGCcv42S5PgZ48J6XkIIs81RTBDBz0lNEj+2gyT/rRunFI3zH4vXJOIRtB\n\tFFgw3rfJIR040KzxFeMl0bB3q63ux/JttZyJwQuFYLkJi+jbRFz+VD/6vLyrd/ts2EJj\n\tzjRBzChFT1zrt14wwAIAORi4UD5lolbSaq70TBu45QxmpOI7EH/fg6ucZim8gx4CEc5M\n\tdLdVnGTuZbG0Y5uYPL5X6YIkUkN2myFJCY5ZXEwGVGGfIWGDPd4fIqpy8QtX6wt6t7ac\n\twE/YKPNEcU7r8pPIxgbEczCcqMpuLnykiK6g+PbPedqcug+6zouVMvVBIG+7usWKpI/y\n\tbfMQ==", "X-Gm-Message-State": "APjAAAUNU2V0jl6Om4dW+tOH06ytw4S8CIsGa9w5c0QTGIjyVo3jU20W\n\t8LX8a3dt8/ZrADt8RkWMFBVmse1o3hE=", "X-Google-Smtp-Source": "APXvYqwMCmJvTRMiRdYnbm6PTw27gNPxPa51MQBCBQf3eeB48qoYDRLRa0v1q6tNZe5EwKb9cdG8/Q==", "X-Received": "by 2002:a63:234c:: with SMTP id u12mr737673pgm.264.1559696938927;\n\tTue, 04 Jun 2019 18:08:58 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 4 Jun 2019 18:08:49 -0700", "Message-Id": "<20190605010852.28395-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190605010852.28395-1-stephen@networkplumber.org>", "References": "<20190516180427.17270-1-stephen@networkplumber.org>\n\t<20190605010852.28395-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 3/6] ethdev: use rte_eth_unformat_addr", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use rte_eth_unformat_addr, so that ethdev can be built and work\nwithout the cmdline library. The dependency on cmdline was\nan arrangement of convenience anyway.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/Makefile | 1 -\n lib/librte_ethdev/Makefile | 2 +-\n lib/librte_ethdev/meson.build | 2 +-\n lib/librte_ethdev/rte_class_eth.c | 9 +--------\n 4 files changed, 3 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/Makefile b/lib/Makefile\nindex 791e0d9911d6..82b2c4bfa8ea 100644\n--- a/lib/Makefile\n+++ b/lib/Makefile\n@@ -25,7 +25,6 @@ DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += librte_ethdev\n DEPDIRS-librte_ethdev := librte_net librte_eal librte_mempool librte_ring\n DEPDIRS-librte_ethdev += librte_mbuf\n DEPDIRS-librte_ethdev += librte_kvargs\n-DEPDIRS-librte_ethdev += librte_cmdline\n DEPDIRS-librte_ethdev += librte_meter\n DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += librte_bbdev\n DEPDIRS-librte_bbdev := librte_eal librte_mempool librte_mbuf\ndiff --git a/lib/librte_ethdev/Makefile b/lib/librte_ethdev/Makefile\nindex 8d4a02630c4f..60bcc2227878 100644\n--- a/lib/librte_ethdev/Makefile\n+++ b/lib/librte_ethdev/Makefile\n@@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n LDLIBS += -lrte_net -lrte_eal -lrte_mempool -lrte_ring\n-LDLIBS += -lrte_mbuf -lrte_kvargs -lrte_cmdline -lrte_meter\n+LDLIBS += -lrte_mbuf -lrte_kvargs -lrte_meter\n \n EXPORT_MAP := rte_ethdev_version.map\n \ndiff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build\nindex 8d6165b2a7dd..f75d428c96d0 100644\n--- a/lib/librte_ethdev/meson.build\n+++ b/lib/librte_ethdev/meson.build\n@@ -26,4 +26,4 @@ headers = files('rte_ethdev.h',\n \t'rte_tm.h',\n \t'rte_tm_driver.h')\n \n-deps += ['net', 'kvargs', 'cmdline', 'meter']\n+deps += ['net', 'kvargs', 'meter']\ndiff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c\nindex 873a653532ad..6338355e2557 100644\n--- a/lib/librte_ethdev/rte_class_eth.c\n+++ b/lib/librte_ethdev/rte_class_eth.c\n@@ -4,7 +4,6 @@\n \n #include <string.h>\n \n-#include <cmdline_parse_etheraddr.h>\n #include <rte_class.h>\n #include <rte_compat.h>\n #include <rte_errno.h>\n@@ -43,19 +42,13 @@ static int\n eth_mac_cmp(const char *key __rte_unused,\n \t\tconst char *value, void *opaque)\n {\n-\tint ret;\n \tstruct rte_ether_addr mac;\n \tconst struct rte_eth_dev_data *data = opaque;\n \tstruct rte_eth_dev_info dev_info;\n \tuint32_t index;\n \n \t/* Parse devargs MAC address. */\n-\t/*\n-\t * cannot use ether_aton_r(value, &mac)\n-\t * because of include conflict with rte_ether.h\n-\t */\n-\tret = cmdline_parse_etheraddr(NULL, value, &mac, sizeof(mac));\n-\tif (ret < 0)\n+\tif (rte_ether_unformat_addr(value, &mac) < 0)\n \t\treturn -1; /* invalid devargs value */\n \n \t/* Return 0 if devargs MAC is matching one of the device MACs. */\n", "prefixes": [ "v3", "3/6" ] }