Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54342/?format=api
{ "id": 54342, "url": "http://patches.dpdk.org/api/patches/54342/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1559638792-8608-12-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1559638792-8608-12-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1559638792-8608-12-git-send-email-david.marchand@redhat.com", "date": "2019-06-04T08:59:49", "name": "[11/14] test/eal: check number of cores before running subtests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a6141fe9ce8db6b1bc608f7179d7e650358175f3", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1559638792-8608-12-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 4883, "url": "http://patches.dpdk.org/api/series/4883/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4883", "date": "2019-06-04T08:59:38", "name": "Unit tests fixes for CI", "version": 1, "mbox": "http://patches.dpdk.org/series/4883/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54342/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54342/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1EA3F1BC03;\n\tTue, 4 Jun 2019 11:01:00 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id A3A2A1BB5A\n\tfor <dev@dpdk.org>; Tue, 4 Jun 2019 11:00:57 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 230D0330259;\n\tTue, 4 Jun 2019 09:00:57 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-116-185.ams2.redhat.com\n\t[10.36.116.185])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 352445DD6D;\n\tTue, 4 Jun 2019 09:00:55 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net,\n\taconole@redhat.com,\n\tmsantana@redhat.com", "Date": "Tue, 4 Jun 2019 10:59:49 +0200", "Message-Id": "<1559638792-8608-12-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1559638792-8608-1-git-send-email-david.marchand@redhat.com>", "References": "<1559638792-8608-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]); Tue, 04 Jun 2019 09:00:57 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 11/14] test/eal: check number of cores before\n\trunning subtests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Michael Santana <msantana@redhat.com>\n\nThe eal flags unit test assumes that a certain number of cores are\navailable (4 and 8 cores), however this may not always be the case.\nIndividual developers may run the unit test on their local desktop\nwhich typically have 2 to 4 cores, in said case the test is bound\nto fail for lacking 4 or 8 cores.\n\nAdditionally, as we push forward introducing CI into DPDK we are limited\nto the hardware specification of CI services (e.g. Travis CI) that only\nhave 2 cores on their servers, in which case the test would fail.\n\nTo fix this we check available cores before running a subtest. This\napplies to subtests that are dedicated to test that the -l and --lcore\nflags work correctly. If not enough cores are available the subtest is\nsimply skipped, otherwise the subtest is run.\n\nSigned-off-by: Michael Santana <msantana@redhat.com>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n app/test/test_eal_flags.c | 15 ++++++++++++---\n 1 file changed, 12 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c\nindex 5e11b9f..cfa8a61 100644\n--- a/app/test/test_eal_flags.c\n+++ b/app/test/test_eal_flags.c\n@@ -19,7 +19,7 @@\n #include <limits.h>\n #include <fcntl.h>\n \n-#include <rte_per_lcore.h>\n+#include <rte_lcore.h>\n #include <rte_debug.h>\n #include <rte_string_fns.h>\n \n@@ -560,7 +560,9 @@ enum hugepage_action {\n \t\t \"process ran without error with invalid -l flag\\n\");\n \t\treturn -1;\n \t}\n-\tif (launch_proc(argv15) != 0) {\n+\tif (rte_lcore_is_enabled(0) && rte_lcore_is_enabled(1) &&\n+\t rte_lcore_is_enabled(2) && rte_lcore_is_enabled(3) &&\n+\t launch_proc(argv15) != 0) {\n \t\tprintf(\"Error - \"\n \t\t \"process did not run ok with valid corelist value\\n\");\n \t\treturn -1;\n@@ -579,7 +581,11 @@ enum hugepage_action {\n \t\treturn -1;\n \t}\n \n-\tif (launch_proc(argv29) != 0) {\n+\tif (rte_lcore_is_enabled(0) && rte_lcore_is_enabled(1) &&\n+\t rte_lcore_is_enabled(2) && rte_lcore_is_enabled(3) &&\n+\t rte_lcore_is_enabled(3) && rte_lcore_is_enabled(5) &&\n+\t rte_lcore_is_enabled(4) && rte_lcore_is_enabled(7) &&\n+\t launch_proc(argv29) != 0) {\n \t\tprintf(\"Error - \"\n \t\t \"process did not run ok with valid corelist value\\n\");\n \t\treturn -1;\n@@ -606,6 +612,9 @@ enum hugepage_action {\n \tsnprintf(prefix, sizeof(prefix), \"--file-prefix=%s\", tmp);\n #endif\n \n+\tif (!rte_lcore_is_enabled(0) || !rte_lcore_is_enabled(1))\n+\t\treturn TEST_SKIPPED;\n+\n \t/* --master-lcore flag but no value */\n \tconst char *argv1[] = { prgname, prefix, mp_flag,\n \t\t\t\t\"-c\", \"3\", \"--master-lcore\"};\n", "prefixes": [ "11/14" ] }