Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54325/?format=api
{ "id": 54325, "url": "http://patches.dpdk.org/api/patches/54325/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190604054248.68510-50-leyi.rong@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190604054248.68510-50-leyi.rong@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190604054248.68510-50-leyi.rong@intel.com", "date": "2019-06-04T05:42:48", "name": "[49/49] net/ice/base: changes for reducing ice add adv rule time", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "41a230383b56d61ccd902957fa5341ef1a1b9dc3", "submitter": { "id": 1204, "url": "http://patches.dpdk.org/api/people/1204/?format=api", "name": "Leyi Rong", "email": "leyi.rong@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190604054248.68510-50-leyi.rong@intel.com/mbox/", "series": [ { "id": 4879, "url": "http://patches.dpdk.org/api/series/4879/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4879", "date": "2019-06-04T05:41:59", "name": "shared code update", "version": 1, "mbox": "http://patches.dpdk.org/series/4879/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54325/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54325/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5A34F1BCAE;\n\tTue, 4 Jun 2019 07:45:37 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id EABEA1B9DD\n\tfor <dev@dpdk.org>; Tue, 4 Jun 2019 07:44:49 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Jun 2019 22:44:49 -0700", "from lrong-srv-03.sh.intel.com ([10.67.119.177])\n\tby fmsmga008.fm.intel.com with ESMTP; 03 Jun 2019 22:44:48 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Leyi Rong <leyi.rong@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Leyi Rong <leyi.rong@intel.com>,\n\tShivanshu Shukla <shivanshu.shukla@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Tue, 4 Jun 2019 13:42:48 +0800", "Message-Id": "<20190604054248.68510-50-leyi.rong@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190604054248.68510-1-leyi.rong@intel.com>", "References": "<20190604054248.68510-1-leyi.rong@intel.com>", "Subject": "[dpdk-dev] [PATCH 49/49] net/ice/base: changes for reducing ice add\n\tadv rule time", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "While calling ice_find_recp we were calling ice_get_recp_to_prof_map\neverytime we called ice_find_recp. ice_get_recp_to_prof_map is a very\nexpensive operation and we should try to reduce the number of times we\ncall this function. So moved it into ice_get_recp_frm_fw since we only\nneed to have fresh recp_to_profile mapping when we we check FW to see if\nthe recipe we are trying to add already exists in FW.\n\nSigned-off-by: Shivanshu Shukla <shivanshu.shukla@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Leyi Rong <leyi.rong@intel.com>\n---\n drivers/net/ice/base/ice_switch.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex 050526f04..1f95fb149 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -168,6 +168,8 @@ static ice_declare_bitmap(recipe_to_profile[ICE_MAX_NUM_RECIPES],\n \t\t\t ICE_MAX_NUM_PROFILES);\n static ice_declare_bitmap(available_result_ids, ICE_CHAIN_FV_INDEX_START + 1);\n \n+static void ice_get_recp_to_prof_map(struct ice_hw *hw);\n+\n /**\n * ice_get_recp_frm_fw - update SW bookkeeping from FW recipe entries\n * @hw: pointer to hardware structure\n@@ -189,6 +191,10 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid)\n \tstruct ice_prot_lkup_ext *lkup_exts;\n \tenum ice_status status;\n \n+\t/* Get recipe to profile map so that we can get the fv from\n+\t * lkups that we read for a recipe from FW.\n+\t */\n+\tice_get_recp_to_prof_map(hw);\n \t/* we need a buffer big enough to accommodate all the recipes */\n \ttmp = (struct ice_aqc_recipe_data_elem *)ice_calloc(hw,\n \t\tICE_MAX_NUM_RECIPES, sizeof(*tmp));\n@@ -4363,7 +4369,6 @@ static u16 ice_find_recp(struct ice_hw *hw, struct ice_prot_lkup_ext *lkup_exts)\n \tstruct ice_sw_recipe *recp;\n \tu16 i;\n \n-\tice_get_recp_to_prof_map(hw);\n \t/* Initialize available_result_ids which tracks available result idx */\n \tfor (i = 0; i <= ICE_CHAIN_FV_INDEX_START; i++)\n \t\tice_set_bit(ICE_CHAIN_FV_INDEX_START - i,\n", "prefixes": [ "49/49" ] }